From: Olaf Hering <olaf@aepfle.de>
To: qemu-block@nongnu.org
Cc: Stefano Stabellini <sstabellini@kernel.org>,
Anthony Perard <anthony.perard@citrix.com>,
Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>,
"open list:X86" <xen-devel@lists.xensource.com>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges
Date: Fri, 18 Nov 2016 11:30:03 +0100 [thread overview]
Message-ID: <20161118103003.GD5717@aepfle.de> (raw)
In-Reply-To: <20161118102452.5779-1-olaf@aepfle.de>
[-- Attachment #1: Type: text/plain, Size: 410 bytes --]
On Fri, Nov 18, Olaf Hering wrote:
> @@ -708,12 +743,10 @@ static int ioreq_runio_qemu_aio(struct ioreq *ioreq)
> + if (!blk_split_discard(ioreq, req->sector_number, req->nr_sectors)) {
> + goto err;
How is error handling supposed to work here?
Initially I forgot the "!", which just hung the mkfs command in domU.
I have not yet tried to force errors in other part of that function.
Olaf
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 163 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Olaf Hering <olaf@aepfle.de>
To: qemu-block@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Stefano Stabellini <sstabellini@kernel.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
Max Reitz <mreitz@redhat.com>,
"open list:X86" <xen-devel@lists.xensource.com>,
Anthony Perard <anthony.perard@citrix.com>
Subject: Re: [PATCH] xen_disk: convert discard input to byte ranges
Date: Fri, 18 Nov 2016 11:30:03 +0100 [thread overview]
Message-ID: <20161118103003.GD5717@aepfle.de> (raw)
In-Reply-To: <20161118102452.5779-1-olaf@aepfle.de>
[-- Attachment #1: Type: text/plain, Size: 410 bytes --]
On Fri, Nov 18, Olaf Hering wrote:
> @@ -708,12 +743,10 @@ static int ioreq_runio_qemu_aio(struct ioreq *ioreq)
> + if (!blk_split_discard(ioreq, req->sector_number, req->nr_sectors)) {
> + goto err;
How is error handling supposed to work here?
Initially I forgot the "!", which just hung the mkfs command in domU.
I have not yet tried to force errors in other part of that function.
Olaf
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 163 bytes --]
next prev parent reply other threads:[~2016-11-18 10:30 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 10:24 [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges Olaf Hering
2016-11-18 10:24 ` Olaf Hering
2016-11-18 10:30 ` Olaf Hering [this message]
2016-11-18 10:30 ` Olaf Hering
2016-11-23 10:49 ` [Qemu-devel] " Olaf Hering
2016-11-23 10:49 ` Olaf Hering
2016-11-23 11:02 ` [Qemu-devel] " Olaf Hering
2016-11-23 11:02 ` Olaf Hering
2016-11-23 18:51 ` [Qemu-devel] " Stefano Stabellini
2016-11-23 18:51 ` Stefano Stabellini
2016-11-18 13:43 ` [Qemu-devel] " Eric Blake
2016-11-18 13:43 ` Eric Blake
2016-11-18 14:19 ` Olaf Hering
2016-11-18 14:19 ` Olaf Hering
2016-11-18 14:35 ` Eric Blake
2016-11-18 14:35 ` Eric Blake
2016-11-18 15:38 ` Kevin Wolf
2016-11-18 15:38 ` Kevin Wolf
2016-11-18 16:39 ` Eric Blake
2016-11-18 16:39 ` Eric Blake
2016-11-18 17:41 ` Olaf Hering
2016-11-18 17:41 ` Olaf Hering
2016-11-18 18:50 ` Eric Blake
2016-11-18 18:50 ` Eric Blake
2016-11-22 16:12 ` Olaf Hering
2016-11-22 16:12 ` Olaf Hering
2016-11-22 16:32 ` Eric Blake
2016-11-22 16:32 ` Eric Blake
2016-11-22 17:00 ` Olaf Hering
2016-11-22 17:00 ` Olaf Hering
2016-11-22 17:11 ` Eric Blake
2016-11-22 17:11 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161118103003.GD5717@aepfle.de \
--to=olaf@aepfle.de \
--cc=anthony.perard@citrix.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.