From: Olaf Hering <olaf@aepfle.de>
To: Stefano Stabellini <sstabellini@kernel.org>,
Anthony Perard <anthony.perard@citrix.com>,
Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>
Cc: qemu-block@nongnu.org,
"open list:X86" <xen-devel@lists.xensource.com>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Subject: Re: [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges
Date: Wed, 23 Nov 2016 12:02:19 +0100 [thread overview]
Message-ID: <20161123110219.GD19126@aepfle.de> (raw)
In-Reply-To: <20161123104950.GC19126@aepfle.de>
[-- Attachment #1: Type: text/plain, Size: 1399 bytes --]
On Wed, Nov 23, Olaf Hering wrote:
> > > + if (!blk_split_discard(ioreq, req->sector_number, req->nr_sectors)) {
> > > + goto err;
> > How is error handling supposed to work here?
In the guest the cmd is stuck, instead of getting an IO error:
[ 91.966404] mkfs.ext4 D 0000000000000000 0 2878 2831 0x00000000
[ 91.966406] ffff88002204bc48 ffff880030530480 ffff88002fae5800 ffff88002204c000
[ 91.966407] 0000000000000000 7fffffffffffffff 0000000000008000 00000000024000c0
[ 91.966409] ffff88002204bc60 ffffffff815dd985 ffff880038815c00 ffff88002204bd08
[ 91.966409] Call Trace:
[ 91.966413] [<ffffffff815dd985>] schedule+0x35/0x80
[ 91.966416] [<ffffffff815e02c7>] schedule_timeout+0x237/0x2d0
[ 91.966419] [<ffffffff815dcf46>] io_schedule_timeout+0xa6/0x110
[ 91.966421] [<ffffffff815de2f3>] wait_for_completion_io+0xa3/0x110
[ 91.966425] [<ffffffff812d7b00>] submit_bio_wait+0x50/0x60
[ 91.966430] [<ffffffff812e9168>] blkdev_issue_discard+0x78/0xb0
[ 91.966433] [<ffffffff812eee2b>] blk_ioctl_discard+0x7b/0xa0
[ 91.966436] [<ffffffff812efa20>] blkdev_ioctl+0x730/0x920
[ 91.966440] [<ffffffff812318fd>] block_ioctl+0x3d/0x40
[ 91.966444] [<ffffffff8120cd6d>] do_vfs_ioctl+0x2cd/0x4a0
[ 91.966453] [<ffffffff8120cfb4>] SyS_ioctl+0x74/0x80
[ 91.966456] [<ffffffff815e142e>] entry_SYSCALL_64_fastpath+0x12/0x6d
Olaf
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 163 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: Olaf Hering <olaf@aepfle.de>
To: Stefano Stabellini <sstabellini@kernel.org>,
Anthony Perard <anthony.perard@citrix.com>,
Kevin Wolf <kwolf@redhat.com>, Max Reitz <mreitz@redhat.com>
Cc: "open list:X86" <xen-devel@lists.xensource.com>,
"open list:All patches CC here" <qemu-devel@nongnu.org>,
qemu-block@nongnu.org
Subject: Re: [PATCH] xen_disk: convert discard input to byte ranges
Date: Wed, 23 Nov 2016 12:02:19 +0100 [thread overview]
Message-ID: <20161123110219.GD19126@aepfle.de> (raw)
In-Reply-To: <20161123104950.GC19126@aepfle.de>
[-- Attachment #1: Type: text/plain, Size: 1399 bytes --]
On Wed, Nov 23, Olaf Hering wrote:
> > > + if (!blk_split_discard(ioreq, req->sector_number, req->nr_sectors)) {
> > > + goto err;
> > How is error handling supposed to work here?
In the guest the cmd is stuck, instead of getting an IO error:
[ 91.966404] mkfs.ext4 D 0000000000000000 0 2878 2831 0x00000000
[ 91.966406] ffff88002204bc48 ffff880030530480 ffff88002fae5800 ffff88002204c000
[ 91.966407] 0000000000000000 7fffffffffffffff 0000000000008000 00000000024000c0
[ 91.966409] ffff88002204bc60 ffffffff815dd985 ffff880038815c00 ffff88002204bd08
[ 91.966409] Call Trace:
[ 91.966413] [<ffffffff815dd985>] schedule+0x35/0x80
[ 91.966416] [<ffffffff815e02c7>] schedule_timeout+0x237/0x2d0
[ 91.966419] [<ffffffff815dcf46>] io_schedule_timeout+0xa6/0x110
[ 91.966421] [<ffffffff815de2f3>] wait_for_completion_io+0xa3/0x110
[ 91.966425] [<ffffffff812d7b00>] submit_bio_wait+0x50/0x60
[ 91.966430] [<ffffffff812e9168>] blkdev_issue_discard+0x78/0xb0
[ 91.966433] [<ffffffff812eee2b>] blk_ioctl_discard+0x7b/0xa0
[ 91.966436] [<ffffffff812efa20>] blkdev_ioctl+0x730/0x920
[ 91.966440] [<ffffffff812318fd>] block_ioctl+0x3d/0x40
[ 91.966444] [<ffffffff8120cd6d>] do_vfs_ioctl+0x2cd/0x4a0
[ 91.966453] [<ffffffff8120cfb4>] SyS_ioctl+0x74/0x80
[ 91.966456] [<ffffffff815e142e>] entry_SYSCALL_64_fastpath+0x12/0x6d
Olaf
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 163 bytes --]
next prev parent reply other threads:[~2016-11-23 11:02 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-18 10:24 [Qemu-devel] [PATCH] xen_disk: convert discard input to byte ranges Olaf Hering
2016-11-18 10:24 ` Olaf Hering
2016-11-18 10:30 ` [Qemu-devel] " Olaf Hering
2016-11-18 10:30 ` Olaf Hering
2016-11-23 10:49 ` [Qemu-devel] " Olaf Hering
2016-11-23 10:49 ` Olaf Hering
2016-11-23 11:02 ` Olaf Hering [this message]
2016-11-23 11:02 ` Olaf Hering
2016-11-23 18:51 ` [Qemu-devel] " Stefano Stabellini
2016-11-23 18:51 ` Stefano Stabellini
2016-11-18 13:43 ` [Qemu-devel] " Eric Blake
2016-11-18 13:43 ` Eric Blake
2016-11-18 14:19 ` Olaf Hering
2016-11-18 14:19 ` Olaf Hering
2016-11-18 14:35 ` Eric Blake
2016-11-18 14:35 ` Eric Blake
2016-11-18 15:38 ` Kevin Wolf
2016-11-18 15:38 ` Kevin Wolf
2016-11-18 16:39 ` Eric Blake
2016-11-18 16:39 ` Eric Blake
2016-11-18 17:41 ` Olaf Hering
2016-11-18 17:41 ` Olaf Hering
2016-11-18 18:50 ` Eric Blake
2016-11-18 18:50 ` Eric Blake
2016-11-22 16:12 ` Olaf Hering
2016-11-22 16:12 ` Olaf Hering
2016-11-22 16:32 ` Eric Blake
2016-11-22 16:32 ` Eric Blake
2016-11-22 17:00 ` Olaf Hering
2016-11-22 17:00 ` Olaf Hering
2016-11-22 17:11 ` Eric Blake
2016-11-22 17:11 ` Eric Blake
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161123110219.GD19126@aepfle.de \
--to=olaf@aepfle.de \
--cc=anthony.perard@citrix.com \
--cc=kwolf@redhat.com \
--cc=mreitz@redhat.com \
--cc=qemu-block@nongnu.org \
--cc=qemu-devel@nongnu.org \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xensource.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.