All of lore.kernel.org
 help / color / mirror / Atom feed
From: thomas.petazzoni@free-electrons.com (Thomas Petazzoni)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 09/13] ARM: dts: armada-375: Fixup soc DT warning
Date: Fri, 18 Nov 2016 14:38:35 +0100	[thread overview]
Message-ID: <20161118143835.660cf275@free-electrons.com> (raw)
In-Reply-To: <877f81b013.fsf@free-electrons.com>

Hello,

On Fri, 18 Nov 2016 10:38:32 +0100, Gregory CLEMENT wrote:

> >> > unit address? It doesn't have a 'reg' property if I remember
> >> > correctly.    
> >> 
> >> But it has a range property.  
> >
> > And? There are multiple ranges, and you randomly took the first one for
> > the unit address of the soc node?  
> 
> Not randomly I followed the same rules that for the regs mentioned in
> the ePAPR paragraph 2.2.1.1:
> 
> "The unit-address should match the first address specified in the reg
> property of the node."

But it doesn't say anything about the ranges property. Isn't the dtc
warning in fact over-zealous? The ePAPR says that the unit address
should be the first address of the reg property, but doesn't say
anything about the ranges property.

What I dislike is that there absolutely nothing that forces the ranges
to be written in this order. In another board, it can be written in a
completely different order, which means that the unit address would be
different, which is really silly.

I continue to believe this rule doesn't make sense, and the soc node
shouldn't have a unit address. Maybe Rob or Mark (who is not in Cc, for
some reason?) should say a word about this?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com

WARNING: multiple messages have this Message-ID (diff)
From: Thomas Petazzoni <thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Gregory CLEMENT
	<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
	Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
	Sebastian Hesselbarth
	<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v3 09/13] ARM: dts: armada-375: Fixup soc DT warning
Date: Fri, 18 Nov 2016 14:38:35 +0100	[thread overview]
Message-ID: <20161118143835.660cf275@free-electrons.com> (raw)
In-Reply-To: <877f81b013.fsf-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>

Hello,

On Fri, 18 Nov 2016 10:38:32 +0100, Gregory CLEMENT wrote:

> >> > unit address? It doesn't have a 'reg' property if I remember
> >> > correctly.    
> >> 
> >> But it has a range property.  
> >
> > And? There are multiple ranges, and you randomly took the first one for
> > the unit address of the soc node?  
> 
> Not randomly I followed the same rules that for the regs mentioned in
> the ePAPR paragraph 2.2.1.1:
> 
> "The unit-address should match the first address specified in the reg
> property of the node."

But it doesn't say anything about the ranges property. Isn't the dtc
warning in fact over-zealous? The ePAPR says that the unit address
should be the first address of the reg property, but doesn't say
anything about the ranges property.

What I dislike is that there absolutely nothing that forces the ranges
to be written in this order. In another board, it can be written in a
completely different order, which means that the unit address would be
different, which is really silly.

I continue to believe this rule doesn't make sense, and the soc node
shouldn't have a unit address. Maybe Rob or Mark (who is not in Cc, for
some reason?) should say a word about this?

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux and Kernel engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

  reply	other threads:[~2016-11-18 13:38 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-11-17 23:08 [PATCH v3 00/13] Various Armada 375 DT warning fixup Gregory CLEMENT
2016-11-17 23:08 ` Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 01/13] ARM: dts: armada-375: Add node labels Gregory CLEMENT
2016-11-17 23:08   ` Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 02/13] ARM: dts: armada-375: Use the " Gregory CLEMENT
2016-11-17 23:08   ` Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 03/13] ARM: dts: armada-375: Fixup mdio DT warning Gregory CLEMENT
2016-11-17 23:08   ` Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 04/13] ARM: dts: armada-375: Fixup bootrom " Gregory CLEMENT
2016-11-17 23:08   ` Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 05/13] ARM: dts: armada-375: Fixup devbus " Gregory CLEMENT
2016-11-17 23:08   ` Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 06/13] ARM: dts: armada-375: Fixup sa-ram " Gregory CLEMENT
2016-11-17 23:08   ` Gregory CLEMENT
2016-11-18  8:59   ` Thomas Petazzoni
2016-11-18  8:59     ` Thomas Petazzoni
2016-11-18 12:06     ` Gregory CLEMENT
2016-11-18 12:06       ` Gregory CLEMENT
2016-11-18 13:35       ` Thomas Petazzoni
2016-11-18 13:35         ` Thomas Petazzoni
2016-11-17 23:08 ` [PATCH v3 07/13] ARM: dts: armada-375: Fixup pcie DT warnings Gregory CLEMENT
2016-11-17 23:08   ` Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 08/13] ARM: dts: armada-375: Fixup pinctrl " Gregory CLEMENT
2016-11-17 23:08   ` Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 09/13] ARM: dts: armada-375: Fixup soc DT warning Gregory CLEMENT
2016-11-17 23:08   ` Gregory CLEMENT
2016-11-18  8:54   ` Thomas Petazzoni
2016-11-18  8:54     ` Thomas Petazzoni
2016-11-18  9:01     ` Gregory CLEMENT
2016-11-18  9:01       ` Gregory CLEMENT
2016-11-18  9:12       ` Thomas Petazzoni
2016-11-18  9:12         ` Thomas Petazzoni
2016-11-18  9:38         ` Gregory CLEMENT
2016-11-18  9:38           ` Gregory CLEMENT
2016-11-18 13:38           ` Thomas Petazzoni [this message]
2016-11-18 13:38             ` Thomas Petazzoni
2016-11-17 23:08 ` [PATCH v3 10/13] ARM: dts: armada-375: Fixup internal-regs " Gregory CLEMENT
2016-11-17 23:08   ` Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 11/13] ARM: dts: armada-375: Remove skeleton.dtsi Gregory CLEMENT
2016-11-17 23:08   ` Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 12/13] ARM: dts: armada-375: Fixup memory DT warning Gregory CLEMENT
2016-11-17 23:08   ` Gregory CLEMENT
2016-11-17 23:08 ` [PATCH v3 13/13] ARM: dts: armada-375: Fixup ethernet child " Gregory CLEMENT
2016-11-17 23:08   ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161118143835.660cf275@free-electrons.com \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.