* [PATCH] drm/i915/bxt: Correct dual-link MIPI port control.
@ 2016-11-21 22:24 Bob Paauwe
2016-11-21 23:15 ` ✓ Fi.CI.BAT: success for " Patchwork
2016-11-22 13:00 ` [PATCH] " Ville Syrjälä
0 siblings, 2 replies; 4+ messages in thread
From: Bob Paauwe @ 2016-11-21 22:24 UTC (permalink / raw)
To: intel-gfx
For BXT, there is only one bit that enables/disables dual-link mode
and not different bits depending on which pipe is being used.
Signed-off-by: Bob Paauwe <bob.j.paauwe@intel.com>
---
drivers/gpu/drm/i915/intel_dsi.c | 5 ++++-
1 file changed, 4 insertions(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
index 4e0d025..a35c141 100644
--- a/drivers/gpu/drm/i915/intel_dsi.c
+++ b/drivers/gpu/drm/i915/intel_dsi.c
@@ -476,7 +476,10 @@ static void intel_dsi_port_enable(struct intel_encoder *encoder)
if (intel_dsi->ports == (BIT(PORT_A) | BIT(PORT_C))) {
temp |= (intel_dsi->dual_link - 1)
<< DUAL_LINK_MODE_SHIFT;
- temp |= intel_crtc->pipe ?
+ if (IS_BROXTON(dev_priv))
+ temp |= LANE_CONFIGURATION_DUAL_LINK_A;
+ else
+ temp |= intel_crtc->pipe ?
LANE_CONFIGURATION_DUAL_LINK_B :
LANE_CONFIGURATION_DUAL_LINK_A;
}
--
2.7.4
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply related [flat|nested] 4+ messages in thread* ✓ Fi.CI.BAT: success for drm/i915/bxt: Correct dual-link MIPI port control.
2016-11-21 22:24 [PATCH] drm/i915/bxt: Correct dual-link MIPI port control Bob Paauwe
@ 2016-11-21 23:15 ` Patchwork
2016-11-22 13:00 ` [PATCH] " Ville Syrjälä
1 sibling, 0 replies; 4+ messages in thread
From: Patchwork @ 2016-11-21 23:15 UTC (permalink / raw)
To: Bob Paauwe; +Cc: intel-gfx
== Series Details ==
Series: drm/i915/bxt: Correct dual-link MIPI port control.
URL : https://patchwork.freedesktop.org/series/15690/
State : success
== Summary ==
Series 15690v1 drm/i915/bxt: Correct dual-link MIPI port control.
https://patchwork.freedesktop.org/api/1.0/series/15690/revisions/1/mbox/
Test drv_module_reload_basic:
dmesg-warn -> PASS (fi-skl-6770hq)
fi-bdw-5557u total:244 pass:229 dwarn:0 dfail:0 fail:0 skip:15
fi-bsw-n3050 total:244 pass:204 dwarn:0 dfail:0 fail:0 skip:40
fi-bxt-t5700 total:244 pass:216 dwarn:0 dfail:0 fail:0 skip:28
fi-byt-j1900 total:244 pass:216 dwarn:0 dfail:0 fail:0 skip:28
fi-byt-n2820 total:244 pass:212 dwarn:0 dfail:0 fail:0 skip:32
fi-hsw-4770 total:244 pass:224 dwarn:0 dfail:0 fail:0 skip:20
fi-hsw-4770r total:244 pass:224 dwarn:0 dfail:0 fail:0 skip:20
fi-ilk-650 total:244 pass:191 dwarn:0 dfail:0 fail:0 skip:53
fi-ivb-3520m total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22
fi-ivb-3770 total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22
fi-kbl-7200u total:244 pass:222 dwarn:0 dfail:0 fail:0 skip:22
fi-skl-6260u total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14
fi-skl-6700hq total:244 pass:223 dwarn:0 dfail:0 fail:0 skip:21
fi-skl-6700k total:244 pass:222 dwarn:1 dfail:0 fail:0 skip:21
fi-skl-6770hq total:244 pass:230 dwarn:0 dfail:0 fail:0 skip:14
fi-snb-2520m total:244 pass:212 dwarn:0 dfail:0 fail:0 skip:32
fi-snb-2600 total:244 pass:211 dwarn:0 dfail:0 fail:0 skip:33
eeec5e7742b23082dd20523c8baa08fe495175e4 drm-intel-nightly: 2016y-11m-21d-18h-22m-22s UTC integration manifest
db004b2 drm/i915/bxt: Correct dual-link MIPI port control.
== Logs ==
For more details see: https://intel-gfx-ci.01.org/CI/Patchwork_3075/
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915/bxt: Correct dual-link MIPI port control.
2016-11-21 22:24 [PATCH] drm/i915/bxt: Correct dual-link MIPI port control Bob Paauwe
2016-11-21 23:15 ` ✓ Fi.CI.BAT: success for " Patchwork
@ 2016-11-22 13:00 ` Ville Syrjälä
2016-11-23 20:26 ` Ville Syrjälä
1 sibling, 1 reply; 4+ messages in thread
From: Ville Syrjälä @ 2016-11-22 13:00 UTC (permalink / raw)
To: Bob Paauwe; +Cc: intel-gfx
On Mon, Nov 21, 2016 at 02:24:06PM -0800, Bob Paauwe wrote:
> For BXT, there is only one bit that enables/disables dual-link mode
> and not different bits depending on which pipe is being used.
>
> Signed-off-by: Bob Paauwe <bob.j.paauwe@intel.com>
> ---
> drivers/gpu/drm/i915/intel_dsi.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
> index 4e0d025..a35c141 100644
> --- a/drivers/gpu/drm/i915/intel_dsi.c
> +++ b/drivers/gpu/drm/i915/intel_dsi.c
> @@ -476,7 +476,10 @@ static void intel_dsi_port_enable(struct intel_encoder *encoder)
> if (intel_dsi->ports == (BIT(PORT_A) | BIT(PORT_C))) {
> temp |= (intel_dsi->dual_link - 1)
> << DUAL_LINK_MODE_SHIFT;
> - temp |= intel_crtc->pipe ?
> + if (IS_BROXTON(dev_priv))
> + temp |= LANE_CONFIGURATION_DUAL_LINK_A;
> + else
> + temp |= intel_crtc->pipe ?
> LANE_CONFIGURATION_DUAL_LINK_B :
> LANE_CONFIGURATION_DUAL_LINK_A;
Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] drm/i915/bxt: Correct dual-link MIPI port control.
2016-11-22 13:00 ` [PATCH] " Ville Syrjälä
@ 2016-11-23 20:26 ` Ville Syrjälä
0 siblings, 0 replies; 4+ messages in thread
From: Ville Syrjälä @ 2016-11-23 20:26 UTC (permalink / raw)
To: Bob Paauwe; +Cc: intel-gfx
On Tue, Nov 22, 2016 at 03:00:14PM +0200, Ville Syrjälä wrote:
> On Mon, Nov 21, 2016 at 02:24:06PM -0800, Bob Paauwe wrote:
> > For BXT, there is only one bit that enables/disables dual-link mode
> > and not different bits depending on which pipe is being used.
> >
> > Signed-off-by: Bob Paauwe <bob.j.paauwe@intel.com>
> > ---
> > drivers/gpu/drm/i915/intel_dsi.c | 5 ++++-
> > 1 file changed, 4 insertions(+), 1 deletion(-)
> >
> > diff --git a/drivers/gpu/drm/i915/intel_dsi.c b/drivers/gpu/drm/i915/intel_dsi.c
> > index 4e0d025..a35c141 100644
> > --- a/drivers/gpu/drm/i915/intel_dsi.c
> > +++ b/drivers/gpu/drm/i915/intel_dsi.c
> > @@ -476,7 +476,10 @@ static void intel_dsi_port_enable(struct intel_encoder *encoder)
> > if (intel_dsi->ports == (BIT(PORT_A) | BIT(PORT_C))) {
> > temp |= (intel_dsi->dual_link - 1)
> > << DUAL_LINK_MODE_SHIFT;
> > - temp |= intel_crtc->pipe ?
> > + if (IS_BROXTON(dev_priv))
> > + temp |= LANE_CONFIGURATION_DUAL_LINK_A;
> > + else
> > + temp |= intel_crtc->pipe ?
> > LANE_CONFIGURATION_DUAL_LINK_B :
> > LANE_CONFIGURATION_DUAL_LINK_A;
>
> Reviewed-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
And pushed to dinq. Thanks for the patch.
--
Ville Syrjälä
Intel OTC
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2016-11-23 20:26 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2016-11-21 22:24 [PATCH] drm/i915/bxt: Correct dual-link MIPI port control Bob Paauwe
2016-11-21 23:15 ` ✓ Fi.CI.BAT: success for " Patchwork
2016-11-22 13:00 ` [PATCH] " Ville Syrjälä
2016-11-23 20:26 ` Ville Syrjälä
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.