From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: open list <linux-kernel@vger.kernel.org>,
dri-devel@lists.freedesktop.org,
"open list:VIRTIO GPU DRIVER"
<virtualization@lists.linux-foundation.org>
Subject: Re: [PATCH] drm/virtio: fix framebuffer sparse warning
Date: Mon, 28 Nov 2016 17:28:24 +0200 [thread overview]
Message-ID: <20161128172814-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1480320322-23362-1-git-send-email-kraxel@redhat.com>
On Mon, Nov 28, 2016 at 09:05:21AM +0100, Gerd Hoffmann wrote:
> virtio uses normal ram as backing storage for the framebuffer, so we
> should assign the address to new screen_buffer (added by commit
> 17a7b0b4d9749f80d365d7baff5dec2f54b0e992) instead of screen_base.
>
> Reported-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/gpu/drm/virtio/virtgpu_fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_fb.c b/drivers/gpu/drm/virtio/virtgpu_fb.c
> index 2242a80..dc2976c 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_fb.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_fb.c
> @@ -337,7 +337,7 @@ static int virtio_gpufb_create(struct drm_fb_helper *helper,
> info->fbops = &virtio_gpufb_ops;
> info->pixmap.flags = FB_PIXMAP_SYSTEM;
>
> - info->screen_base = obj->vmap;
> + info->screen_buffer = obj->vmap;
> info->screen_size = obj->gem_base.size;
> drm_fb_helper_fill_fix(info, fb->pitches[0], fb->depth);
> drm_fb_helper_fill_var(info, &vfbdev->helper,
> --
> 1.8.3.1
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Gerd Hoffmann <kraxel@redhat.com>
Cc: dri-devel@lists.freedesktop.org, David Airlie <airlied@linux.ie>,
"open list:VIRTIO GPU DRIVER"
<virtualization@lists.linux-foundation.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] drm/virtio: fix framebuffer sparse warning
Date: Mon, 28 Nov 2016 17:28:24 +0200 [thread overview]
Message-ID: <20161128172814-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <1480320322-23362-1-git-send-email-kraxel@redhat.com>
On Mon, Nov 28, 2016 at 09:05:21AM +0100, Gerd Hoffmann wrote:
> virtio uses normal ram as backing storage for the framebuffer, so we
> should assign the address to new screen_buffer (added by commit
> 17a7b0b4d9749f80d365d7baff5dec2f54b0e992) instead of screen_base.
>
> Reported-by: Michael S. Tsirkin <mst@redhat.com>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
> ---
> drivers/gpu/drm/virtio/virtgpu_fb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_fb.c b/drivers/gpu/drm/virtio/virtgpu_fb.c
> index 2242a80..dc2976c 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_fb.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_fb.c
> @@ -337,7 +337,7 @@ static int virtio_gpufb_create(struct drm_fb_helper *helper,
> info->fbops = &virtio_gpufb_ops;
> info->pixmap.flags = FB_PIXMAP_SYSTEM;
>
> - info->screen_base = obj->vmap;
> + info->screen_buffer = obj->vmap;
> info->screen_size = obj->gem_base.size;
> drm_fb_helper_fill_fix(info, fb->pitches[0], fb->depth);
> drm_fb_helper_fill_var(info, &vfbdev->helper,
> --
> 1.8.3.1
next prev parent reply other threads:[~2016-11-28 15:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-28 8:05 [PATCH] drm/virtio: fix framebuffer sparse warning Gerd Hoffmann
2016-11-28 8:05 ` Gerd Hoffmann
2016-11-28 15:28 ` Michael S. Tsirkin
2016-11-28 15:28 ` Michael S. Tsirkin [this message]
2016-11-28 15:28 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161128172814-mutt-send-email-mst@kernel.org \
--to=mst@redhat.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=kraxel@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=virtualization@lists.linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.