Re: Re: [PATCH] usb:hub: readibility and consistency in coding style

From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: Atul Raj <atul.r@samsung.com>
Cc: "alcooperx@gmail.com" <alcooperx@gmail.com>,
	"mathias.nyman@linux.intel.com" <mathias.nyman@linux.intel.com>,
	Pankaj Singh <pankaj.s4@samsung.com>,
	Viresh Kumar <viresh.kumar@linaro.org>,
	"oneukum@suse.com" <oneukum@suse.com>,
	"atulraj.nith@gmail.com" <atulraj.nith@gmail.com>,
	"dri-devel@lists.freedesktop.org"
	<dri-devel@lists.freedesktop.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"stern@rowland.harvard.edu" <stern@rowland.harvard.edu>,
	"hansy@nvidia.com" <hansy@nvidia.com>,
	"baolu.lu@linux.intel.com" <baolu.lu@linux.intel.com>
Subject: Re: Re: [PATCH] usb:hub: readibility and consistency in coding style
Date: Wed, 30 Nov 2016 14:49:42 +0100	[thread overview]
Message-ID: <20161130134942.GB937@kroah.com> (raw)
In-Reply-To: <20161130123521epcms5p3aa0bd43d60fa69c7c7fbc1bbe7fa0099@epcms5p3>

A: http://en.wikipedia.org/wiki/Top_post
Q: Were do I find info about this thing called top-posting?
A: Because it messes up the order in which people normally read text.
Q: Why is top-posting such a bad thing?
A: Top-posting.
Q: What is the most annoying thing in e-mail?

A: No.
Q: Should I include quotations after my reply?

http://daringfireball.net/2007/07/on_top

On Wed, Nov 30, 2016 at 12:35:21PM +0000, Atul Raj wrote:
> Hi Greg,
> 
> I am so happy to get a mail from you and I am really sorry Greg that I disappointed you.
> I will take utmost care in future.
> I will send you correct patch in sometime.
> for your ques
> "Also, why are you including a ton of people who have nothing to do with
> usb patches on this one?"
> 
> I got the name of people from get_maintainer.pl

When using get_maintainer.pl on this patch it does not include the
dri-devel list, so I don't think you used it correctly.

> from now I will include only you.
> is it ok??

No, do it correctly.

> one more thing in another mail you replied to me as
> On Wed, Nov 30, 2016 at 11:40:28AM +0000, Atul Raj wrote:
> >  changes in v2
> >         - added braces as suggested.
> 
> Why is this here?
> 
> > 
> >  drivers/usb/core/hub.c | 3 ++-
> >  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> do you disagree with viresh comment of braces???

I disagree that this is a valid changelog comment, please read
Documentation/SubmittingPatches for the correct way to do this.

Again, if you don't have experience doing this, please work in the
drivers/staging/ directory first, not in the "core" kernel.

thanks,

greg k-h
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel