remoteproc/ste: Hide config option by default

remoteproc/ste: Hide config option by default

[Jean Delvare]

Back in July 2014 I asked around what was the intended target
platform for the STE Modem remoteproc driver, so that I could add the
proper hardware dependency to its config option. The answer I got was
that there was no known publicly available hardware needing it and it
was unlikely that there ever would.

Still there were objections to deleting the driver, which I do not
really understand, but I do respect. But as there is no point in
presenting the config option by default, let's hide it unless
build-testing.

Signed-off-by: Jean Delvare <jdelvare@suse.de>
Cc: Ohad Ben-Cohen <ohad@wizery.com>
Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Dmitry Tarnyagin <dmitry.tarnyagin@lockless.no>
Cc: Suman Anna <s-anna@ti.com>
---
As suggested by Linus Walleij over 2 years ago, sorry for not
following up back then:
  https://lkml.org/lkml/2014/7/25/218

The driver could also be moved to staging/.

 drivers/remoteproc/Kconfig |    3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

--- linux-4.9-rc7.orig/drivers/remoteproc/Kconfig	2016-11-08 15:01:12.247924911 +0100
+++ linux-4.9-rc7/drivers/remoteproc/Kconfig	2016-12-01 09:23:57.379218183 +0100
@@ -34,11 +34,12 @@ config OMAP_REMOTEPROC
 config STE_MODEM_RPROC
 	tristate "STE-Modem remoteproc support"
 	depends on HAS_DMA
+	depends on COMPILE_TEST
 	select REMOTEPROC
 	default n
 	help
 	  Say y or m here to support STE-Modem shared memory driver.
-	  This can be either built-in or a loadable module.
+	  Note that there is no known available system needing this driver.
 	  If unsure say N.
 
 config WKUP_M3_RPROC


-- 
Jean Delvare
SUSE L3 Support

Re: remoteproc/ste: Hide config option by default

[Linus Walleij]

On Thu, Dec 1, 2016 at 9:49 AM, Jean Delvare <jdelvare@suse.de> wrote:

> Back in July 2014 I asked around what was the intended target
> platform for the STE Modem remoteproc driver, so that I could add the
> proper hardware dependency to its config option. The answer I got was
> that there was no known publicly available hardware needing it and it
> was unlikely that there ever would.
>
> Still there were objections to deleting the driver, which I do not
> really understand, but I do respect. But as there is no point in
> presenting the config option by default, let's hide it unless
> build-testing.
>
> Signed-off-by: Jean Delvare <jdelvare@suse.de>
> Cc: Ohad Ben-Cohen <ohad@wizery.com>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Linus Walleij <linus.walleij@linaro.org>
> Cc: Dmitry Tarnyagin <dmitry.tarnyagin@lockless.no>
> Cc: Suman Anna <s-anna@ti.com>
> ---
> As suggested by Linus Walleij over 2 years ago, sorry for not
> following up back then:
>   https://lkml.org/lkml/2014/7/25/218
>
> The driver could also be moved to staging/.

Acked-by: Linus Walleij <linus.walleij@linaro.org>

Also for moving it to staging, if you want. Or deleting it.

Yours,
Linus Walleij

Re: remoteproc/ste: Hide config option by default

[Bjorn Andersson]

On Fri 02 Dec 02:08 PST 2016, Linus Walleij wrote:

> On Thu, Dec 1, 2016 at 9:49 AM, Jean Delvare <jdelvare@suse.de> wrote:
> 
> > Back in July 2014 I asked around what was the intended target
> > platform for the STE Modem remoteproc driver, so that I could add the
> > proper hardware dependency to its config option. The answer I got was
> > that there was no known publicly available hardware needing it and it
> > was unlikely that there ever would.
> >
> > Still there were objections to deleting the driver, which I do not
> > really understand, but I do respect. But as there is no point in
> > presenting the config option by default, let's hide it unless
> > build-testing.
> >
> > Signed-off-by: Jean Delvare <jdelvare@suse.de>
> > Cc: Ohad Ben-Cohen <ohad@wizery.com>
> > Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> > Cc: Linus Walleij <linus.walleij@linaro.org>
> > Cc: Dmitry Tarnyagin <dmitry.tarnyagin@lockless.no>
> > Cc: Suman Anna <s-anna@ti.com>
> > ---
> > As suggested by Linus Walleij over 2 years ago, sorry for not
> > following up back then:
> >   https://lkml.org/lkml/2014/7/25/218
> >
> > The driver could also be moved to staging/.
> 
> Acked-by: Linus Walleij <linus.walleij@linaro.org>
> 
> Also for moving it to staging, if you want. Or deleting it.
> 

If there's no known present or future users of this code I would prefer
that we just drop it - it will stay with us in the git history if
someone wants it back.


I do not want to see it moved to staging, I still need to maintain it
when the internal remoteproc APIs changes.

Regards,
Bjorn