All of lore.kernel.org
 help / color / mirror / Atom feed
From: gregkh at linuxfoundation.org <gregkh@linuxfoundation.org>
To: "Dilger, Andreas" <andreas.dilger@intel.com>
Cc: "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"lustre-devel@lists.lustre.org" <lustre-devel@lists.lustre.org>,
	"jsimmons@infradead.org" <jsimmons@infradead.org>,
	"Drokin, Oleg" <oleg.drokin@intel.com>
Subject: [lustre-devel] Remaining work needed for moving Lustre out of staging
Date: Sat, 3 Dec 2016 09:55:50 +0100	[thread overview]
Message-ID: <20161203085550.GA5375@kroah.com> (raw)
In-Reply-To: <1E1B324A-F545-417D-9C35-550FA58665C7@intel.com>

On Fri, Dec 02, 2016 at 09:53:08PM +0000, Dilger, Andreas wrote:
> Al,
> Greg recently raised the issue of what still needs to be done to
> move the Lustre code out of staging/ and into the fs/ tree. 
> 
> James has been doing a great job of cleaning up various checkpatch
> issues and keeping the code updated with the latest fixes, but we
> were wondering what you were aware of that needed to be cleaned
> up in Lustre?

Is the whole "mixing kernel structures in userspace structures" all
resolved now?  For some reason I thought that you had kernel locks being
passed to userspace and then back into the kernel, but it's been a long
time since I last looked...

If you feel you are ready for a "real" review, I'll be glad to go over
the code before the vfs people look at it, just let me know.  No need to
bother them if you still have basic things wrong that I can find...

thanks,

greg k-h

WARNING: multiple messages have this Message-ID (diff)
From: "gregkh@linuxfoundation.org" <gregkh@linuxfoundation.org>
To: "Dilger, Andreas" <andreas.dilger@intel.com>
Cc: "viro@zeniv.linux.org.uk" <viro@zeniv.linux.org.uk>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"lustre-devel@lists.lustre.org" <lustre-devel@lists.lustre.org>,
	"jsimmons@infradead.org" <jsimmons@infradead.org>,
	"Drokin, Oleg" <oleg.drokin@intel.com>
Subject: Re: Remaining work needed for moving Lustre out of staging
Date: Sat, 3 Dec 2016 09:55:50 +0100	[thread overview]
Message-ID: <20161203085550.GA5375@kroah.com> (raw)
In-Reply-To: <1E1B324A-F545-417D-9C35-550FA58665C7@intel.com>

On Fri, Dec 02, 2016 at 09:53:08PM +0000, Dilger, Andreas wrote:
> Al,
> Greg recently raised the issue of what still needs to be done to
> move the Lustre code out of staging/ and into the fs/ tree. 
> 
> James has been doing a great job of cleaning up various checkpatch
> issues and keeping the code updated with the latest fixes, but we
> were wondering what you were aware of that needed to be cleaned
> up in Lustre?

Is the whole "mixing kernel structures in userspace structures" all
resolved now?  For some reason I thought that you had kernel locks being
passed to userspace and then back into the kernel, but it's been a long
time since I last looked...

If you feel you are ready for a "real" review, I'll be glad to go over
the code before the vfs people look at it, just let me know.  No need to
bother them if you still have basic things wrong that I can find...

thanks,

greg k-h

  reply	other threads:[~2016-12-03  8:55 UTC|newest]

Thread overview: 24+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-02 21:53 [lustre-devel] Remaining work needed for moving Lustre out of staging Dilger, Andreas
2016-12-02 21:53 ` Dilger, Andreas
2016-12-03  8:55 ` gregkh at linuxfoundation.org [this message]
2016-12-03  8:55   ` gregkh
2016-12-06 15:34   ` [lustre-devel] " Oleg Drokin
2016-12-06 15:34     ` Oleg Drokin
2016-12-06 16:15     ` [lustre-devel] " Greg KH
2016-12-06 16:15       ` Greg KH
2016-12-06 17:50       ` [lustre-devel] " Oleg Drokin
2016-12-06 17:50         ` Oleg Drokin
2016-12-06 18:05         ` Greg KH
2016-12-06 18:05           ` Greg KH
2016-12-06 18:05         ` Andreas Dilger
2016-12-06 18:05           ` Andreas Dilger
2016-12-07 19:57           ` James Simmons
2016-12-07 19:57             ` James Simmons
2016-12-06 18:07         ` Mike Marshall
2016-12-06 18:07           ` Mike Marshall
2016-12-06 18:14           ` [lustre-devel] " Oleg Drokin
2016-12-06 18:14             ` Oleg Drokin
2016-12-06 18:52             ` Mike Marshall
2016-12-06 18:52               ` Mike Marshall
2016-12-07 19:05     ` James Simmons
2016-12-07 19:05       ` James Simmons

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161203085550.GA5375@kroah.com \
    --to=gregkh@linuxfoundation.org \
    --cc=andreas.dilger@intel.com \
    --cc=jsimmons@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=lustre-devel@lists.lustre.org \
    --cc=oleg.drokin@intel.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.