From: Dan Carpenter <dan.carpenter@oracle.com>
To: James Simmons <jsimmons@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
Oleg Drokin <oleg.drokin@intel.com>, Ben Evans <bevans@cray.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions
Date: Mon, 5 Dec 2016 23:50:05 +0300 [thread overview]
Message-ID: <20161205205005.GA31243@mwanda> (raw)
In-Reply-To: <1480707650-24089-4-git-send-email-jsimmons@infradead.org>
On Fri, Dec 02, 2016 at 02:40:47PM -0500, James Simmons wrote:
> - __u32 local_flags = 0;
> + u32 local_flags = 0;
> - if (local_flags != 0) {
> + if (local_flags) {
Please avoid these unrelated white space changes.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: James Simmons <jsimmons@infradead.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
Oleg Drokin <oleg.drokin@intel.com>, Ben Evans <bevans@cray.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions
Date: Mon, 5 Dec 2016 23:50:05 +0300 [thread overview]
Message-ID: <20161205205005.GA31243@mwanda> (raw)
In-Reply-To: <1480707650-24089-4-git-send-email-jsimmons@infradead.org>
On Fri, Dec 02, 2016 at 02:40:47PM -0500, James Simmons wrote:
> - __u32 local_flags = 0;
> + u32 local_flags = 0;
> - if (local_flags != 0) {
> + if (local_flags) {
Please avoid these unrelated white space changes.
regards,
dan carpenter
next prev parent reply other threads:[~2016-12-05 20:50 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 19:40 [lustre-devel] [PATCH 0/6] Fix ups to make lustre_idl.h a proper UAPI header James Simmons
2016-12-02 19:40 ` James Simmons
2016-12-02 19:40 ` [lustre-devel] [PATCH 1/6] staging: lustre: headers: move swab functions to new header files James Simmons
2016-12-02 19:40 ` James Simmons
2016-12-02 19:40 ` [lustre-devel] [PATCH 2/6] staging: lustre: headers: sort headers affected by swab move James Simmons
2016-12-02 19:40 ` James Simmons
2016-12-06 9:32 ` [lustre-devel] " Greg Kroah-Hartman
2016-12-06 9:32 ` Greg Kroah-Hartman
2016-12-02 19:40 ` [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions James Simmons
2016-12-02 19:40 ` James Simmons
2016-12-03 13:27 ` [lustre-devel] " kbuild test robot
2016-12-03 13:27 ` kbuild test robot
2016-12-05 20:50 ` Dan Carpenter [this message]
2016-12-05 20:50 ` Dan Carpenter
2016-12-05 21:55 ` [lustre-devel] " Dilger, Andreas
2016-12-05 21:55 ` Dilger, Andreas
2016-12-05 22:06 ` Dan Carpenter
2016-12-05 22:06 ` Dan Carpenter
2016-12-07 19:18 ` James Simmons
2016-12-07 19:18 ` James Simmons
2016-12-06 9:36 ` Greg Kroah-Hartman
2016-12-06 9:36 ` Greg Kroah-Hartman
2016-12-07 19:13 ` [lustre-devel] " James Simmons
2016-12-07 19:13 ` James Simmons
2016-12-02 19:40 ` [lustre-devel] [PATCH 4/6] staging: lustre: headers: sort headers affected by obdo move James Simmons
2016-12-02 19:40 ` James Simmons
2016-12-02 19:40 ` [lustre-devel] [PATCH 5/6] staging: lustre: headers: Move functions out of lustre_idl.h James Simmons
2016-12-02 19:40 ` James Simmons
2016-12-05 20:54 ` [lustre-devel] " Dan Carpenter
2016-12-05 20:54 ` Dan Carpenter
2016-12-02 19:40 ` [lustre-devel] [PATCH 6/6] staging: lustre: headers: use proper byteorder functions in lustre_idl.h James Simmons
2016-12-02 19:40 ` James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161205205005.GA31243@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andreas.dilger@intel.com \
--cc=bevans@cray.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.