From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Dilger, Andreas" <andreas.dilger@intel.com>
Cc: James Simmons <jsimmons@infradead.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Drokin, Oleg" <oleg.drokin@intel.com>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions
Date: Tue, 6 Dec 2016 01:06:47 +0300 [thread overview]
Message-ID: <20161205220647.GD8244@mwanda> (raw)
In-Reply-To: <2394CAB0-41C1-4F3B-AF94-03D302F6ABF5@intel.com>
Sorry, I was unclear. I have no problem with white space changes on
their own or when they are on the same line as something else you're
changing.
What I meant is that when you're just moving functions around then don't
mix unrelated white space changes into that patch. I have automated
scripts for reviewing moving code around but slight changes mean that I
have to review it manually line by line to spot the difference. I can
review a one liner cleanup in about 10 seconds but it's finding the line
which changed that's the problem in this case.
And I'm also fine with this patch since I already reviewed it, but in
the future, please avoid the temptation to do cleanups until after.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: "Dilger, Andreas" <andreas.dilger@intel.com>
Cc: James Simmons <jsimmons@infradead.org>,
"devel@driverdev.osuosl.org" <devel@driverdev.osuosl.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
"Drokin, Oleg" <oleg.drokin@intel.com>,
Lustre Development List <lustre-devel@lists.lustre.org>
Subject: Re: [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions
Date: Tue, 6 Dec 2016 01:06:47 +0300 [thread overview]
Message-ID: <20161205220647.GD8244@mwanda> (raw)
In-Reply-To: <2394CAB0-41C1-4F3B-AF94-03D302F6ABF5@intel.com>
Sorry, I was unclear. I have no problem with white space changes on
their own or when they are on the same line as something else you're
changing.
What I meant is that when you're just moving functions around then don't
mix unrelated white space changes into that patch. I have automated
scripts for reviewing moving code around but slight changes mean that I
have to review it manually line by line to spot the difference. I can
review a one liner cleanup in about 10 seconds but it's finding the line
which changed that's the problem in this case.
And I'm also fine with this patch since I already reviewed it, but in
the future, please avoid the temptation to do cleanups until after.
regards,
dan carpenter
next prev parent reply other threads:[~2016-12-05 22:06 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 19:40 [lustre-devel] [PATCH 0/6] Fix ups to make lustre_idl.h a proper UAPI header James Simmons
2016-12-02 19:40 ` James Simmons
2016-12-02 19:40 ` [lustre-devel] [PATCH 1/6] staging: lustre: headers: move swab functions to new header files James Simmons
2016-12-02 19:40 ` James Simmons
2016-12-02 19:40 ` [lustre-devel] [PATCH 2/6] staging: lustre: headers: sort headers affected by swab move James Simmons
2016-12-02 19:40 ` James Simmons
2016-12-06 9:32 ` [lustre-devel] " Greg Kroah-Hartman
2016-12-06 9:32 ` Greg Kroah-Hartman
2016-12-02 19:40 ` [lustre-devel] [PATCH 3/6] staging: lustre: obdclass: Create a header for obdo related functions James Simmons
2016-12-02 19:40 ` James Simmons
2016-12-03 13:27 ` [lustre-devel] " kbuild test robot
2016-12-03 13:27 ` kbuild test robot
2016-12-05 20:50 ` [lustre-devel] " Dan Carpenter
2016-12-05 20:50 ` Dan Carpenter
2016-12-05 21:55 ` [lustre-devel] " Dilger, Andreas
2016-12-05 21:55 ` Dilger, Andreas
2016-12-05 22:06 ` Dan Carpenter [this message]
2016-12-05 22:06 ` Dan Carpenter
2016-12-07 19:18 ` James Simmons
2016-12-07 19:18 ` James Simmons
2016-12-06 9:36 ` Greg Kroah-Hartman
2016-12-06 9:36 ` Greg Kroah-Hartman
2016-12-07 19:13 ` [lustre-devel] " James Simmons
2016-12-07 19:13 ` James Simmons
2016-12-02 19:40 ` [lustre-devel] [PATCH 4/6] staging: lustre: headers: sort headers affected by obdo move James Simmons
2016-12-02 19:40 ` James Simmons
2016-12-02 19:40 ` [lustre-devel] [PATCH 5/6] staging: lustre: headers: Move functions out of lustre_idl.h James Simmons
2016-12-02 19:40 ` James Simmons
2016-12-05 20:54 ` [lustre-devel] " Dan Carpenter
2016-12-05 20:54 ` Dan Carpenter
2016-12-02 19:40 ` [lustre-devel] [PATCH 6/6] staging: lustre: headers: use proper byteorder functions in lustre_idl.h James Simmons
2016-12-02 19:40 ` James Simmons
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161205220647.GD8244@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.