From: Christoph Hellwig <hch@infradead.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, Jason Wang <jasowang@redhat.com>,
linux-kbuild@vger.kernel.org, Michal Marek <mmarek@suse.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
David Airlie <airlied@linux.ie>,
Gerd Hoffmann <kraxel@redhat.com>,
Ohad Ben-Cohen <ohad@wizery.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
Jens Axboe <axboe@fb.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Asias He <asias@redhat.com>,
linux-crypto@vger.kernel.org, dri-devel@lists.freedesktop.org,
Subject: Re: [PATCH 10/10] virtio: enable endian checks for sparse builds
Date: Tue, 6 Dec 2016 23:30:21 -0800 [thread overview]
Message-ID: <20161207073021.GA26970@infradead.org> (raw)
In-Reply-To: <1481038106-24899-11-git-send-email-mst@redhat.com>
On Tue, Dec 06, 2016 at 05:41:05PM +0200, Michael S. Tsirkin wrote:
> __CHECK_ENDIAN__ isn't on by default presumably because
> it triggers too many sparse warnings for correct code.
> But virtio is now clean of these warnings, and
> we want to keep it this way - enable this for
> sparse builds.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Nah. Please just enable it globally when using sparse. I actually
had a chat with Linus about that a while ago and he seemed generally
fine with it, I just didn't manage to actually do it..
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, Jason Wang <jasowang@redhat.com>,
linux-kbuild@vger.kernel.org, Michal Marek <mmarek@suse.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
David Airlie <airlied@linux.ie>,
Gerd Hoffmann <kraxel@redhat.com>,
Ohad Ben-Cohen <ohad@wizery.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
Jens Axboe <axboe@fb.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Asias He <asias@redhat.com>,
linux-crypto@vger.kernel.org, dri-devel@lists.freedesktop.org,
virtualization@lists.linux-foundation.org,
netdev@vger.kernel.org, linux-remoteproc@vger.kernel.org,
linux-s390@vger.kernel.org, kvm@vger.kernel.org,
linux-scsi@vger.kernel.org, v9fs-developer@lists.sourceforge.net
Subject: Re: [PATCH 10/10] virtio: enable endian checks for sparse builds
Date: Tue, 6 Dec 2016 23:30:21 -0800 [thread overview]
Message-ID: <20161207073021.GA26970@infradead.org> (raw)
In-Reply-To: <1481038106-24899-11-git-send-email-mst@redhat.com>
On Tue, Dec 06, 2016 at 05:41:05PM +0200, Michael S. Tsirkin wrote:
> __CHECK_ENDIAN__ isn't on by default presumably because
> it triggers too many sparse warnings for correct code.
> But virtio is now clean of these warnings, and
> we want to keep it this way - enable this for
> sparse builds.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Nah. Please just enable it globally when using sparse. I actually
had a chat with Linus about that a while ago and he seemed generally
fine with it, I just didn't manage to actually do it..
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: "Michael S. Tsirkin" <mst@redhat.com>
Cc: linux-kernel@vger.kernel.org, Jason Wang <jasowang@redhat.com>,
linux-kbuild@vger.kernel.org, Michal Marek <mmarek@suse.com>,
Arnd Bergmann <arnd@arndb.de>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Matt Mackall <mpm@selenic.com>,
Herbert Xu <herbert@gondor.apana.org.au>,
David Airlie <airlied@linux.ie>,
Gerd Hoffmann <kraxel@redhat.com>,
Ohad Ben-Cohen <ohad@wizery.com>,
Christian Borntraeger <borntraeger@de.ibm.com>,
Cornelia Huck <cornelia.huck@de.ibm.com>,
"James E.J. Bottomley" <jejb@linux.vnet.ibm.com>,
"David S. Miller" <davem@davemloft.net>,
Jens Axboe <axboe@fb.com>,
Neil Armstrong <narmstrong@baylibre.com>,
Stefan Hajnoczi <stefanha@redhat.com>,
Asias He <asias@redhat.com>,
linux-crypto@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH 10/10] virtio: enable endian checks for sparse builds
Date: Tue, 6 Dec 2016 23:30:21 -0800 [thread overview]
Message-ID: <20161207073021.GA26970@infradead.org> (raw)
In-Reply-To: <1481038106-24899-11-git-send-email-mst@redhat.com>
On Tue, Dec 06, 2016 at 05:41:05PM +0200, Michael S. Tsirkin wrote:
> __CHECK_ENDIAN__ isn't on by default presumably because
> it triggers too many sparse warnings for correct code.
> But virtio is now clean of these warnings, and
> we want to keep it this way - enable this for
> sparse builds.
>
> Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Nah. Please just enable it globally when using sparse. I actually
had a chat with Linus about that a while ago and he seemed generally
fine with it, I just didn't manage to actually do it..
next prev parent reply other threads:[~2016-12-07 7:30 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-06 15:40 [PATCH 00/10] virtio: sparse fixes Michael S. Tsirkin
2016-12-06 15:40 ` Michael S. Tsirkin
2016-12-06 15:40 ` [PATCH 01/10] virtio_console: drop unused config fields Michael S. Tsirkin
2016-12-06 15:40 ` Michael S. Tsirkin
2016-12-07 4:12 ` Jason Wang
2016-12-07 4:12 ` Jason Wang
2016-12-06 15:40 ` [PATCH 02/10] drm/virtio: fix endianness in primary_plane_update Michael S. Tsirkin
2016-12-06 15:40 ` Michael S. Tsirkin
2016-12-07 4:13 ` Jason Wang
2016-12-07 4:13 ` Jason Wang
2016-12-06 15:40 ` [PATCH 03/10] drm/virtio: fix lock context imbalance Michael S. Tsirkin
2016-12-06 15:40 ` Michael S. Tsirkin
2016-12-06 15:40 ` Michael S. Tsirkin
2016-12-07 4:13 ` Jason Wang
2016-12-07 4:13 ` Jason Wang
2016-12-06 15:40 ` [PATCH 04/10] drm/virtio: annotate virtio_gpu_queue_ctrl_buffer_locked Michael S. Tsirkin
2016-12-06 15:40 ` Michael S. Tsirkin
2016-12-07 4:15 ` Jason Wang
2016-12-07 4:15 ` Jason Wang
2016-12-06 15:40 ` Michael S. Tsirkin
2016-12-06 15:40 ` [PATCH 05/10] vhost: make interval tree static inline Michael S. Tsirkin
2016-12-06 15:40 ` Michael S. Tsirkin
2016-12-07 4:16 ` Jason Wang
2016-12-07 4:16 ` Jason Wang
2016-12-06 15:40 ` [PATCH 06/10] vhost: add missing __user annotations Michael S. Tsirkin
2016-12-06 15:40 ` Michael S. Tsirkin
2016-12-07 4:17 ` Jason Wang
2016-12-07 4:17 ` Jason Wang
2016-12-06 15:40 ` [PATCH 07/10] vsock/virtio: add a missing __le annotation Michael S. Tsirkin
2016-12-06 15:40 ` Michael S. Tsirkin
2016-12-07 4:19 ` Jason Wang
2016-12-07 4:19 ` Jason Wang
2016-12-07 14:09 ` Stefan Hajnoczi
2016-12-07 14:09 ` Stefan Hajnoczi
2016-12-06 15:41 ` [PATCH 08/10] vsock/virtio: mark an internal function static Michael S. Tsirkin
2016-12-07 4:21 ` Jason Wang
2016-12-07 4:21 ` Jason Wang
2016-12-08 14:25 ` Michael S. Tsirkin
2016-12-08 14:25 ` Michael S. Tsirkin
2016-12-12 1:56 ` Jason Wang
2016-12-12 1:56 ` Jason Wang
2016-12-07 14:09 ` Stefan Hajnoczi
2016-12-07 14:09 ` Stefan Hajnoczi
2016-12-06 15:41 ` Michael S. Tsirkin
2016-12-06 15:41 ` [PATCH 09/10] vsock/virtio: fix src/dst cid format Michael S. Tsirkin
2016-12-06 15:41 ` Michael S. Tsirkin
2016-12-07 4:31 ` Jason Wang
2016-12-07 4:31 ` Jason Wang
2016-12-11 2:54 ` Michael S. Tsirkin
2016-12-11 2:54 ` Michael S. Tsirkin
2016-12-07 14:09 ` Stefan Hajnoczi
2016-12-07 14:09 ` Stefan Hajnoczi
2016-12-06 15:41 ` [PATCH 10/10] virtio: enable endian checks for sparse builds Michael S. Tsirkin
2016-12-06 15:41 ` Michael S. Tsirkin
2016-12-06 15:41 ` Michael S. Tsirkin
2016-12-07 5:27 ` Jason Wang
2016-12-07 5:27 ` Jason Wang
2016-12-07 6:25 ` Johannes Berg
2016-12-07 6:25 ` Johannes Berg
2016-12-07 13:22 ` Michael S. Tsirkin
2016-12-07 13:22 ` Michael S. Tsirkin
2016-12-07 13:22 ` Michael S. Tsirkin
2016-12-07 7:30 ` Christoph Hellwig [this message]
2016-12-07 7:30 ` Christoph Hellwig
2016-12-07 7:30 ` Christoph Hellwig
2016-12-07 7:30 ` Christoph Hellwig
2016-12-07 14:09 ` Stefan Hajnoczi
2016-12-07 14:09 ` Stefan Hajnoczi
2016-12-06 15:41 ` Michael S. Tsirkin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207073021.GA26970@infradead.org \
--to=hch@infradead.org \
--cc=airlied@linux.ie \
--cc=arnd@arndb.de \
--cc=asias@redhat.com \
--cc=axboe@fb.com \
--cc=borntraeger@de.ibm.com \
--cc=cornelia.huck@de.ibm.com \
--cc=davem@davemloft.net \
--cc=dri-devel@lists.freedesktop.org \
--cc=gregkh@linuxfoundation.org \
--cc=herbert@gondor.apana.org.au \
--cc=jasowang@redhat.com \
--cc=jejb@linux.vnet.ibm.com \
--cc=kraxel@redhat.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=mpm@selenic.com \
--cc=mst@redhat.com \
--cc=narmstrong@baylibre.com \
--cc=ohad@wizery.com \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.