All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: kvm@vger.kernel.org, netdev@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	virtualization@lists.linux-foundation.org,
	Stefan Hajnoczi <stefanha@redhat.com>,
	"David S. Miller" <davem@davemloft.net>
Subject: Re: [PATCH 08/10] vsock/virtio: mark an internal function static
Date: Thu, 8 Dec 2016 16:25:55 +0200	[thread overview]
Message-ID: <20161208162458-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <487d3d4a-7a53-cb45-2cfd-5eb68d9b73f0@redhat.com>

On Wed, Dec 07, 2016 at 12:21:22PM +0800, Jason Wang wrote:
> 
> 
> On 2016年12月06日 23:41, Michael S. Tsirkin wrote:
> > virtio_transport_alloc_pkt is only used locally, make it static.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >   net/vmw_vsock/virtio_transport_common.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c
> > index a53b3a1..6120384 100644
> > --- a/net/vmw_vsock/virtio_transport_common.c
> > +++ b/net/vmw_vsock/virtio_transport_common.c
> > @@ -32,7 +32,7 @@ static const struct virtio_transport *virtio_transport_get_ops(void)
> >   	return container_of(t, struct virtio_transport, transport);
> >   }
> > -struct virtio_vsock_pkt *
> > +static struct virtio_vsock_pkt *
> >   virtio_transport_alloc_pkt(struct virtio_vsock_pkt_info *info,
> >   			   size_t len,
> >   			   u32 src_cid,
> 
> Git grep shows it was used by tracing.

True but trace_virtio_transport_alloc_pkt is also local to
virtio_transport_common.c

-- 
MST
_______________________________________________
Virtualization mailing list
Virtualization@lists.linux-foundation.org
https://lists.linuxfoundation.org/mailman/listinfo/virtualization

WARNING: multiple messages have this Message-ID (diff)
From: "Michael S. Tsirkin" <mst@redhat.com>
To: Jason Wang <jasowang@redhat.com>
Cc: linux-kernel@vger.kernel.org,
	Stefan Hajnoczi <stefanha@redhat.com>,
	"David S. Miller" <davem@davemloft.net>,
	kvm@vger.kernel.org, virtualization@lists.linux-foundation.org,
	netdev@vger.kernel.org
Subject: Re: [PATCH 08/10] vsock/virtio: mark an internal function static
Date: Thu, 8 Dec 2016 16:25:55 +0200	[thread overview]
Message-ID: <20161208162458-mutt-send-email-mst@kernel.org> (raw)
In-Reply-To: <487d3d4a-7a53-cb45-2cfd-5eb68d9b73f0@redhat.com>

On Wed, Dec 07, 2016 at 12:21:22PM +0800, Jason Wang wrote:
> 
> 
> On 2016年12月06日 23:41, Michael S. Tsirkin wrote:
> > virtio_transport_alloc_pkt is only used locally, make it static.
> > 
> > Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
> > ---
> >   net/vmw_vsock/virtio_transport_common.c | 2 +-
> >   1 file changed, 1 insertion(+), 1 deletion(-)
> > 
> > diff --git a/net/vmw_vsock/virtio_transport_common.c b/net/vmw_vsock/virtio_transport_common.c
> > index a53b3a1..6120384 100644
> > --- a/net/vmw_vsock/virtio_transport_common.c
> > +++ b/net/vmw_vsock/virtio_transport_common.c
> > @@ -32,7 +32,7 @@ static const struct virtio_transport *virtio_transport_get_ops(void)
> >   	return container_of(t, struct virtio_transport, transport);
> >   }
> > -struct virtio_vsock_pkt *
> > +static struct virtio_vsock_pkt *
> >   virtio_transport_alloc_pkt(struct virtio_vsock_pkt_info *info,
> >   			   size_t len,
> >   			   u32 src_cid,
> 
> Git grep shows it was used by tracing.

True but trace_virtio_transport_alloc_pkt is also local to
virtio_transport_common.c

-- 
MST

  reply	other threads:[~2016-12-08 14:25 UTC|newest]

Thread overview: 69+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-06 15:40 [PATCH 00/10] virtio: sparse fixes Michael S. Tsirkin
2016-12-06 15:40 ` Michael S. Tsirkin
2016-12-06 15:40 ` [PATCH 01/10] virtio_console: drop unused config fields Michael S. Tsirkin
2016-12-06 15:40   ` Michael S. Tsirkin
2016-12-07  4:12   ` Jason Wang
2016-12-07  4:12     ` Jason Wang
2016-12-06 15:40 ` [PATCH 02/10] drm/virtio: fix endianness in primary_plane_update Michael S. Tsirkin
2016-12-06 15:40 ` Michael S. Tsirkin
2016-12-07  4:13   ` Jason Wang
2016-12-07  4:13     ` Jason Wang
2016-12-06 15:40 ` [PATCH 03/10] drm/virtio: fix lock context imbalance Michael S. Tsirkin
2016-12-06 15:40   ` Michael S. Tsirkin
2016-12-07  4:13   ` Jason Wang
2016-12-07  4:13     ` Jason Wang
2016-12-06 15:40 ` Michael S. Tsirkin
2016-12-06 15:40 ` [PATCH 04/10] drm/virtio: annotate virtio_gpu_queue_ctrl_buffer_locked Michael S. Tsirkin
2016-12-06 15:40 ` Michael S. Tsirkin
2016-12-06 15:40   ` Michael S. Tsirkin
2016-12-07  4:15   ` Jason Wang
2016-12-07  4:15     ` Jason Wang
2016-12-06 15:40 ` [PATCH 05/10] vhost: make interval tree static inline Michael S. Tsirkin
2016-12-06 15:40   ` Michael S. Tsirkin
2016-12-07  4:16   ` Jason Wang
2016-12-07  4:16     ` Jason Wang
2016-12-06 15:40 ` [PATCH 06/10] vhost: add missing __user annotations Michael S. Tsirkin
2016-12-06 15:40 ` Michael S. Tsirkin
2016-12-07  4:17   ` Jason Wang
2016-12-07  4:17     ` Jason Wang
2016-12-06 15:40 ` [PATCH 07/10] vsock/virtio: add a missing __le annotation Michael S. Tsirkin
2016-12-06 15:40   ` Michael S. Tsirkin
2016-12-07  4:19   ` Jason Wang
2016-12-07  4:19     ` Jason Wang
2016-12-07 14:09   ` Stefan Hajnoczi
2016-12-07 14:09     ` Stefan Hajnoczi
2016-12-06 15:41 ` [PATCH 08/10] vsock/virtio: mark an internal function static Michael S. Tsirkin
2016-12-06 15:41 ` Michael S. Tsirkin
2016-12-07  4:21   ` Jason Wang
2016-12-07  4:21     ` Jason Wang
2016-12-08 14:25     ` Michael S. Tsirkin [this message]
2016-12-08 14:25       ` Michael S. Tsirkin
2016-12-12  1:56       ` Jason Wang
2016-12-12  1:56       ` Jason Wang
2016-12-07 14:09   ` Stefan Hajnoczi
2016-12-07 14:09     ` Stefan Hajnoczi
2016-12-06 15:41 ` [PATCH 09/10] vsock/virtio: fix src/dst cid format Michael S. Tsirkin
2016-12-06 15:41 ` Michael S. Tsirkin
2016-12-07  4:31   ` Jason Wang
2016-12-11  2:54     ` Michael S. Tsirkin
2016-12-11  2:54     ` Michael S. Tsirkin
2016-12-07  4:31   ` Jason Wang
2016-12-07 14:09   ` Stefan Hajnoczi
2016-12-07 14:09     ` Stefan Hajnoczi
2016-12-06 15:41 ` [PATCH 10/10] virtio: enable endian checks for sparse builds Michael S. Tsirkin
2016-12-06 15:41   ` Michael S. Tsirkin
2016-12-06 15:41   ` Michael S. Tsirkin
2016-12-07  5:27   ` Jason Wang
2016-12-07  5:27     ` Jason Wang
2016-12-07  6:25   ` Johannes Berg
2016-12-07  6:25     ` Johannes Berg
2016-12-07 13:22     ` Michael S. Tsirkin
2016-12-07 13:22       ` Michael S. Tsirkin
2016-12-07 13:22       ` Michael S. Tsirkin
2016-12-07  7:30   ` Christoph Hellwig
2016-12-07  7:30     ` Christoph Hellwig
2016-12-07  7:30     ` Christoph Hellwig
2016-12-07  7:30   ` Christoph Hellwig
2016-12-07 14:09   ` Stefan Hajnoczi
2016-12-07 14:09     ` Stefan Hajnoczi
2016-12-06 15:41 ` Michael S. Tsirkin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161208162458-mutt-send-email-mst@kernel.org \
    --to=mst@redhat.com \
    --cc=davem@davemloft.net \
    --cc=jasowang@redhat.com \
    --cc=kvm@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=stefanha@redhat.com \
    --cc=virtualization@lists.linux-foundation.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.