From: Dan Carpenter <dan.carpenter@oracle.com>
To: Quentin Lambert <lambert.quentin@gmail.com>
Cc: devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Oleg Drokin <oleg.drokin@intel.com>,
lustre-devel@lists.lustre.org
Subject: Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to
Date: Wed, 07 Dec 2016 19:22:37 +0000 [thread overview]
Message-ID: <20161207192237.GP8176@mwanda> (raw)
In-Reply-To: <46ee428d-016f-e532-9824-4ddbe8a0cc8b@gmail.com>
On Wed, Dec 07, 2016 at 04:42:30PM +0100, Quentin Lambert wrote:
>
>
> On 12/07/2016 04:33 PM, Dan Carpenter wrote:
> >Lustre is kind of a mess with regards to keeping user and kernel
> >pointers separate. It's not going to be easy to fix.
> Fair enough.
> I am trying to make a contribution to drivers/staging using sparse.
> With that in mind, do you still fill I should keep clear of lustre?
> I feel that actually doing the work properly could be a meaningful
> learning experience.
It's just that you're the fifth person to look at lustre __user
annotations and it doesn't end well. You need to be a lustre expert
who can test things.
But for other lustre things, feel free.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Quentin Lambert <lambert.quentin@gmail.com>
Cc: devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Oleg Drokin <oleg.drokin@intel.com>,
lustre-devel@lists.lustre.org
Subject: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space
Date: Wed, 7 Dec 2016 22:22:37 +0300 [thread overview]
Message-ID: <20161207192237.GP8176@mwanda> (raw)
In-Reply-To: <46ee428d-016f-e532-9824-4ddbe8a0cc8b@gmail.com>
On Wed, Dec 07, 2016 at 04:42:30PM +0100, Quentin Lambert wrote:
>
>
> On 12/07/2016 04:33 PM, Dan Carpenter wrote:
> >Lustre is kind of a mess with regards to keeping user and kernel
> >pointers separate. It's not going to be easy to fix.
> Fair enough.
> I am trying to make a contribution to drivers/staging using sparse.
> With that in mind, do you still fill I should keep clear of lustre?
> I feel that actually doing the work properly could be a meaningful
> learning experience.
It's just that you're the fifth person to look at lustre __user
annotations and it doesn't end well. You need to be a lustre expert
who can test things.
But for other lustre things, feel free.
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Quentin Lambert <lambert.quentin@gmail.com>
Cc: devel@driverdev.osuosl.org,
Andreas Dilger <andreas.dilger@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
Oleg Drokin <oleg.drokin@intel.com>,
lustre-devel@lists.lustre.org
Subject: Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space
Date: Wed, 7 Dec 2016 22:22:37 +0300 [thread overview]
Message-ID: <20161207192237.GP8176@mwanda> (raw)
In-Reply-To: <46ee428d-016f-e532-9824-4ddbe8a0cc8b@gmail.com>
On Wed, Dec 07, 2016 at 04:42:30PM +0100, Quentin Lambert wrote:
>
>
> On 12/07/2016 04:33 PM, Dan Carpenter wrote:
> >Lustre is kind of a mess with regards to keeping user and kernel
> >pointers separate. It's not going to be easy to fix.
> Fair enough.
> I am trying to make a contribution to drivers/staging using sparse.
> With that in mind, do you still fill I should keep clear of lustre?
> I feel that actually doing the work properly could be a meaningful
> learning experience.
It's just that you're the fifth person to look at lustre __user
annotations and it doesn't end well. You need to be a lustre expert
who can test things.
But for other lustre things, feel free.
regards,
dan carpenter
next prev parent reply other threads:[~2016-12-07 19:22 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 17:33 [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space Quentin Lambert
2016-12-02 17:33 ` Quentin Lambert
2016-12-02 17:33 ` [lustre-devel] " Quentin Lambert
2016-12-05 20:52 ` Dan Carpenter
2016-12-05 20:52 ` Dan Carpenter
2016-12-05 20:52 ` [lustre-devel] " Dan Carpenter
2016-12-05 22:58 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to Oleg Drokin
2016-12-05 22:58 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space Oleg Drokin
2016-12-05 22:58 ` Oleg Drokin
2016-12-06 13:48 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to Quentin Lambert
2016-12-06 13:48 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space Quentin Lambert
2016-12-06 13:48 ` Quentin Lambert
2016-12-07 15:20 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to Quentin Lambert
2016-12-07 15:20 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space Quentin Lambert
2016-12-07 15:20 ` Quentin Lambert
2016-12-07 15:32 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to Dan Carpenter
2016-12-07 15:32 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space Dan Carpenter
2016-12-07 15:32 ` Dan Carpenter
2016-12-07 15:33 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to Dan Carpenter
2016-12-07 15:33 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space Dan Carpenter
2016-12-07 15:33 ` Dan Carpenter
2016-12-07 15:42 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to Quentin Lambert
2016-12-07 15:42 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space Quentin Lambert
2016-12-07 15:42 ` Quentin Lambert
2016-12-07 19:22 ` Dan Carpenter [this message]
2016-12-07 19:22 ` Dan Carpenter
2016-12-07 19:22 ` Dan Carpenter
2016-12-07 19:52 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to James Simmons
2016-12-07 19:52 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space James Simmons
2016-12-07 19:52 ` James Simmons
2016-12-07 17:10 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to Oleg Drokin
2016-12-07 17:10 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space Oleg Drokin
2016-12-07 17:10 ` Oleg Drokin
2016-12-07 17:22 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to Oleg Drokin
2016-12-07 17:22 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space Oleg Drokin
2016-12-07 17:22 ` Oleg Drokin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207192237.GP8176@mwanda \
--to=dan.carpenter@oracle.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=lambert.quentin@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.