From: Quentin Lambert <lambert.quentin@gmail.com>
To: Oleg Drokin <oleg.drokin@intel.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>,
James Simmons <jsimmons@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to
Date: Wed, 07 Dec 2016 15:20:06 +0000 [thread overview]
Message-ID: <33d23121-e5ca-0e14-bfbb-632f883e0948@gmail.com> (raw)
In-Reply-To: <81821426-c32c-c45a-e9a3-82f9818fc986@gmail.com>
Hi all,
I am looking at the drivers/staging/lustre/lustre/llite/dir.c:
1469 /* Call mdc_iocontrol */
1470 rc = obd_iocontrol(LL_IOC_FID2MDTIDX, exp,
sizeof(fid), &fid,
1471 &index);
1472 if (rc)
and sparse says:
drivers/staging/lustre/lustre/llite/dir.c:1471:37: warning: incorrect
type in argument 5 (different address spaces)
I was wondering if there was any value to add a cast to fix the warning?
And I guess this solution would also apply in my original patch to
drivers/staging/lustre/lnet/lnet/lib-socket.c
Quentin
WARNING: multiple messages have this Message-ID (diff)
From: Quentin Lambert <lambert.quentin@gmail.com>
To: Oleg Drokin <oleg.drokin@intel.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>,
James Simmons <jsimmons@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space
Date: Wed, 7 Dec 2016 16:20:06 +0100 [thread overview]
Message-ID: <33d23121-e5ca-0e14-bfbb-632f883e0948@gmail.com> (raw)
In-Reply-To: <81821426-c32c-c45a-e9a3-82f9818fc986@gmail.com>
Hi all,
I am looking at the drivers/staging/lustre/lustre/llite/dir.c:
1469 /* Call mdc_iocontrol */
1470 rc = obd_iocontrol(LL_IOC_FID2MDTIDX, exp,
sizeof(fid), &fid,
1471 &index);
1472 if (rc)
and sparse says:
drivers/staging/lustre/lustre/llite/dir.c:1471:37: warning: incorrect
type in argument 5 (different address spaces)
I was wondering if there was any value to add a cast to fix the warning?
And I guess this solution would also apply in my original patch to
drivers/staging/lustre/lnet/lnet/lib-socket.c
Quentin
WARNING: multiple messages have this Message-ID (diff)
From: Quentin Lambert <lambert.quentin@gmail.com>
To: Oleg Drokin <oleg.drokin@intel.com>
Cc: Andreas Dilger <andreas.dilger@intel.com>,
James Simmons <jsimmons@infradead.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
lustre-devel@lists.lustre.org, devel@driverdev.osuosl.org,
linux-kernel@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space
Date: Wed, 7 Dec 2016 16:20:06 +0100 [thread overview]
Message-ID: <33d23121-e5ca-0e14-bfbb-632f883e0948@gmail.com> (raw)
In-Reply-To: <81821426-c32c-c45a-e9a3-82f9818fc986@gmail.com>
Hi all,
I am looking at the drivers/staging/lustre/lustre/llite/dir.c:
1469 /* Call mdc_iocontrol */
1470 rc = obd_iocontrol(LL_IOC_FID2MDTIDX, exp,
sizeof(fid), &fid,
1471 &index);
1472 if (rc)
and sparse says:
drivers/staging/lustre/lustre/llite/dir.c:1471:37: warning: incorrect
type in argument 5 (different address spaces)
I was wondering if there was any value to add a cast to fix the warning?
And I guess this solution would also apply in my original patch to
drivers/staging/lustre/lnet/lnet/lib-socket.c
Quentin
next prev parent reply other threads:[~2016-12-07 15:20 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-02 17:33 [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space Quentin Lambert
2016-12-02 17:33 ` Quentin Lambert
2016-12-02 17:33 ` [lustre-devel] " Quentin Lambert
2016-12-05 20:52 ` Dan Carpenter
2016-12-05 20:52 ` Dan Carpenter
2016-12-05 20:52 ` [lustre-devel] " Dan Carpenter
2016-12-05 22:58 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to Oleg Drokin
2016-12-05 22:58 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space Oleg Drokin
2016-12-05 22:58 ` Oleg Drokin
2016-12-06 13:48 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to Quentin Lambert
2016-12-06 13:48 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space Quentin Lambert
2016-12-06 13:48 ` Quentin Lambert
2016-12-07 15:20 ` Quentin Lambert [this message]
2016-12-07 15:20 ` Quentin Lambert
2016-12-07 15:20 ` Quentin Lambert
2016-12-07 15:32 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to Dan Carpenter
2016-12-07 15:32 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space Dan Carpenter
2016-12-07 15:32 ` Dan Carpenter
2016-12-07 15:33 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to Dan Carpenter
2016-12-07 15:33 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space Dan Carpenter
2016-12-07 15:33 ` Dan Carpenter
2016-12-07 15:42 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to Quentin Lambert
2016-12-07 15:42 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space Quentin Lambert
2016-12-07 15:42 ` Quentin Lambert
2016-12-07 19:22 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to Dan Carpenter
2016-12-07 19:22 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space Dan Carpenter
2016-12-07 19:22 ` Dan Carpenter
2016-12-07 19:52 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to James Simmons
2016-12-07 19:52 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space James Simmons
2016-12-07 19:52 ` James Simmons
2016-12-07 17:10 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to Oleg Drokin
2016-12-07 17:10 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space Oleg Drokin
2016-12-07 17:10 ` Oleg Drokin
2016-12-07 17:22 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to Oleg Drokin
2016-12-07 17:22 ` [lustre-devel] [PATCH] staging: lustre: Fix a spatch warning due to an assignment from kernel to user space Oleg Drokin
2016-12-07 17:22 ` Oleg Drokin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=33d23121-e5ca-0e14-bfbb-632f883e0948@gmail.com \
--to=lambert.quentin@gmail.com \
--cc=andreas.dilger@intel.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=jsimmons@infradead.org \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lustre-devel@lists.lustre.org \
--cc=oleg.drokin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.