All of lore.kernel.org
 help / color / mirror / Atom feed
From: keith.busch@intel.com (Keith Busch)
Subject: [PATCH] nvme: use the correct msix vector for each queue
Date: Wed, 7 Dec 2016 17:44:14 -0500	[thread overview]
Message-ID: <20161207224414.GE22478@localhost.localdomain> (raw)
In-Reply-To: <20161207220348.8572-1-ddstreet@ieee.org>

On Wed, Dec 07, 2016@05:03:48PM -0500, Dan Streetman wrote:
> Change each queue's cq_vector to match its qid, instead of qid - 1.
> 
> The first queue is always the admin queue, and the remaining queues are
> I/O queues.  The interrupt vectors they use are all in the same array,
> however, the vector indexes for the admin and I/O queues are setup
> differently; the admin queue's cq_vector is manually set to 0, while
> each I/O queue's cq_vector is set to qid - 1.  Since the admin queue
> is qid 0, and the I/O queues start at qid 1, using qid - 1 is wrong for the
> I/O queues, as it makes the first I/O queue (qid 1) share the vector from
> the admin queue (qid 0), and no queue uses the last interrupt vector.
> Instead, each I/O queue should set their cq_vector to qid.

pci_alloc_irq_vectors doesn't know you intend to make the first
vector special, so it's going to come up with a CPU affinity from
blk_mq_pci_map_queues that clashes with what you've programmed in the
IO completion queues.

WARNING: multiple messages have this Message-ID (diff)
From: Keith Busch <keith.busch@intel.com>
To: Dan Streetman <ddstreet@ieee.org>
Cc: Jens Axboe <axboe@fb.com>,
	linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org,
	Dan Streetman <dan.streetman@canonical.com>
Subject: Re: [PATCH] nvme: use the correct msix vector for each queue
Date: Wed, 7 Dec 2016 17:44:14 -0500	[thread overview]
Message-ID: <20161207224414.GE22478@localhost.localdomain> (raw)
In-Reply-To: <20161207220348.8572-1-ddstreet@ieee.org>

On Wed, Dec 07, 2016 at 05:03:48PM -0500, Dan Streetman wrote:
> Change each queue's cq_vector to match its qid, instead of qid - 1.
> 
> The first queue is always the admin queue, and the remaining queues are
> I/O queues.  The interrupt vectors they use are all in the same array,
> however, the vector indexes for the admin and I/O queues are setup
> differently; the admin queue's cq_vector is manually set to 0, while
> each I/O queue's cq_vector is set to qid - 1.  Since the admin queue
> is qid 0, and the I/O queues start at qid 1, using qid - 1 is wrong for the
> I/O queues, as it makes the first I/O queue (qid 1) share the vector from
> the admin queue (qid 0), and no queue uses the last interrupt vector.
> Instead, each I/O queue should set their cq_vector to qid.

pci_alloc_irq_vectors doesn't know you intend to make the first
vector special, so it's going to come up with a CPU affinity from
blk_mq_pci_map_queues that clashes with what you've programmed in the
IO completion queues.

  reply	other threads:[~2016-12-07 22:44 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-07 22:03 [PATCH] nvme: use the correct msix vector for each queue Dan Streetman
2016-12-07 22:03 ` Dan Streetman
2016-12-07 22:44 ` Keith Busch [this message]
2016-12-07 22:44   ` Keith Busch
2016-12-07 22:36   ` Dan Streetman
2016-12-07 22:36     ` Dan Streetman
2016-12-07 22:49     ` Keith Busch
2016-12-07 22:49       ` Keith Busch
2016-12-07 22:46       ` Christoph Hellwig
2016-12-07 22:46         ` Christoph Hellwig
2016-12-07 22:49         ` Dan Streetman
2016-12-07 22:49           ` Dan Streetman
2016-12-07 22:46       ` Dan Streetman
2016-12-07 22:46         ` Dan Streetman
2016-12-07 23:05         ` Keith Busch
2016-12-07 23:05           ` Keith Busch

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161207224414.GE22478@localhost.localdomain \
    --to=keith.busch@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.