From: hch@infradead.org (Christoph Hellwig)
Subject: [PATCH] nvme: use the correct msix vector for each queue
Date: Wed, 7 Dec 2016 14:46:28 -0800 [thread overview]
Message-ID: <20161207224627.GA16018@infradead.org> (raw)
In-Reply-To: <20161207224941.GA25959@localhost.localdomain>
On Wed, Dec 07, 2016@05:49:42PM -0500, Keith Busch wrote:
> I'm just saying that blk-mq's hctx mapping will end up choosing a queue
> who's vector is mapped to a different CPU, and we don't want that.
Right. For 4.10 we could use the pci_alloc_irq_vectors_affinity helper
to set away a pre_vector IFF we want a separate vector for the admin
queue.
> We are currently sharing the first IO queue's interrupt vector with
> the admin queue's on purpose. Are you saying there's something wrong
> with that?
But given that the sharing was done intentionally and we had a long
discussion on it back then there should be no real reason to change
the assignment in NVMe.
WARNING: multiple messages have this Message-ID (diff)
From: Christoph Hellwig <hch@infradead.org>
To: Keith Busch <keith.busch@intel.com>
Cc: Dan Streetman <ddstreet@ieee.org>, Jens Axboe <axboe@fb.com>,
Dan Streetman <dan.streetman@canonical.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: use the correct msix vector for each queue
Date: Wed, 7 Dec 2016 14:46:28 -0800 [thread overview]
Message-ID: <20161207224627.GA16018@infradead.org> (raw)
In-Reply-To: <20161207224941.GA25959@localhost.localdomain>
On Wed, Dec 07, 2016 at 05:49:42PM -0500, Keith Busch wrote:
> I'm just saying that blk-mq's hctx mapping will end up choosing a queue
> who's vector is mapped to a different CPU, and we don't want that.
Right. For 4.10 we could use the pci_alloc_irq_vectors_affinity helper
to set away a pre_vector IFF we want a separate vector for the admin
queue.
> We are currently sharing the first IO queue's interrupt vector with
> the admin queue's on purpose. Are you saying there's something wrong
> with that?
But given that the sharing was done intentionally and we had a long
discussion on it back then there should be no real reason to change
the assignment in NVMe.
next prev parent reply other threads:[~2016-12-07 22:46 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-07 22:03 [PATCH] nvme: use the correct msix vector for each queue Dan Streetman
2016-12-07 22:03 ` Dan Streetman
2016-12-07 22:44 ` Keith Busch
2016-12-07 22:44 ` Keith Busch
2016-12-07 22:36 ` Dan Streetman
2016-12-07 22:36 ` Dan Streetman
2016-12-07 22:49 ` Keith Busch
2016-12-07 22:49 ` Keith Busch
2016-12-07 22:46 ` Christoph Hellwig [this message]
2016-12-07 22:46 ` Christoph Hellwig
2016-12-07 22:49 ` Dan Streetman
2016-12-07 22:49 ` Dan Streetman
2016-12-07 22:46 ` Dan Streetman
2016-12-07 22:46 ` Dan Streetman
2016-12-07 23:05 ` Keith Busch
2016-12-07 23:05 ` Keith Busch
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161207224627.GA16018@infradead.org \
--to=hch@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.