From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: davem@davemloft.net, maxime.ripard@free-electrons.com,
wens@csie.org, linux-kernel@vger.kernel.org,
linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] crypto: sun4i-ss: support the Security System PRNG
Date: Thu, 8 Dec 2016 10:24:00 +0100 [thread overview]
Message-ID: <20161208092400.GA9743@Red> (raw)
In-Reply-To: <20161208090618.GB22932@gondor.apana.org.au>
On Thu, Dec 08, 2016 at 05:06:18PM +0800, Herbert Xu wrote:
> On Wed, Dec 07, 2016 at 01:51:27PM +0100, Corentin Labbe wrote:
> >
> > So I must expose it as a crypto_rng ?
>
> If it is to be exposed at all then algif_rng would be the best
> place.
>
I have badly said my question.
So I need to use the HW PRNG in a crypto_rng "provider" that could be thereafter used from user space via algif_rng. right ?
> > Could you explain why PRNG must not be used as hw_random ?
>
> The hwrng interface was always meant to be an interface for real
> hardware random number generators. People rely on that so we
> should not provide bogus entropy sources through this interface.
>
Why not adding a KCONFIG HW_RANDOM_ACCEPT_ALSO_PRNG with big warning ?
Or a HW_PRNG Kconfig which do the same than hwrandom with /dev/prng ?
With that it will be much easier to convert in-tree PRNG that you want to remove.
Regards
Corentin Labbe
WARNING: multiple messages have this Message-ID (diff)
From: clabbe.montjoie@gmail.com (Corentin Labbe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] crypto: sun4i-ss: support the Security System PRNG
Date: Thu, 8 Dec 2016 10:24:00 +0100 [thread overview]
Message-ID: <20161208092400.GA9743@Red> (raw)
In-Reply-To: <20161208090618.GB22932@gondor.apana.org.au>
On Thu, Dec 08, 2016 at 05:06:18PM +0800, Herbert Xu wrote:
> On Wed, Dec 07, 2016 at 01:51:27PM +0100, Corentin Labbe wrote:
> >
> > So I must expose it as a crypto_rng ?
>
> If it is to be exposed at all then algif_rng would be the best
> place.
>
I have badly said my question.
So I need to use the HW PRNG in a crypto_rng "provider" that could be thereafter used from user space via algif_rng. right ?
> > Could you explain why PRNG must not be used as hw_random ?
>
> The hwrng interface was always meant to be an interface for real
> hardware random number generators. People rely on that so we
> should not provide bogus entropy sources through this interface.
>
Why not adding a KCONFIG HW_RANDOM_ACCEPT_ALSO_PRNG with big warning ?
Or a HW_PRNG Kconfig which do the same than hwrandom with /dev/prng ?
With that it will be much easier to convert in-tree PRNG that you want to remove.
Regards
Corentin Labbe
next prev parent reply other threads:[~2016-12-08 9:24 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 10:48 [PATCH v2] crypto: sun4i-ss: support the Security System PRNG Corentin Labbe
2016-12-05 10:48 ` Corentin Labbe
2016-12-05 10:48 ` Corentin Labbe
2016-12-05 12:37 ` Herbert Xu
2016-12-05 12:37 ` Herbert Xu
2016-12-05 12:57 ` Corentin Labbe
2016-12-05 12:57 ` Corentin Labbe
2016-12-07 12:09 ` Herbert Xu
2016-12-07 12:09 ` Herbert Xu
2016-12-07 12:51 ` Corentin Labbe
2016-12-07 12:51 ` Corentin Labbe
2016-12-07 12:51 ` Corentin Labbe
2016-12-08 9:06 ` Herbert Xu
2016-12-08 9:06 ` Herbert Xu
2016-12-08 9:24 ` Corentin Labbe [this message]
2016-12-08 9:24 ` Corentin Labbe
2016-12-08 11:01 ` PrasannaKumar Muralidharan
2016-12-08 11:01 ` PrasannaKumar Muralidharan
2016-12-13 14:10 ` Corentin Labbe
2016-12-13 14:10 ` Corentin Labbe
2016-12-13 15:23 ` PrasannaKumar Muralidharan
2016-12-13 15:23 ` PrasannaKumar Muralidharan
2016-12-13 15:33 ` Corentin Labbe
2016-12-13 15:33 ` Corentin Labbe
2016-12-13 15:33 ` Corentin Labbe
2016-12-14 5:05 ` Herbert Xu
2016-12-14 5:05 ` Herbert Xu
2016-12-14 6:03 ` Corentin Labbe
2016-12-14 6:03 ` Corentin Labbe
2016-12-14 19:17 ` PrasannaKumar Muralidharan
2016-12-14 19:17 ` PrasannaKumar Muralidharan
2016-12-14 19:17 ` PrasannaKumar Muralidharan
2016-12-15 6:09 ` Herbert Xu
2016-12-15 6:09 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161208092400.GA9743@Red \
--to=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.