From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
linux-kernel@vger.kernel.org, Chen-Yu Tsai <wens@csie.org>,
linux-crypto@vger.kernel.org, maxime.ripard@free-electrons.com,
davem@davemloft.net, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] crypto: sun4i-ss: support the Security System PRNG
Date: Tue, 13 Dec 2016 16:33:15 +0100 [thread overview]
Message-ID: <20161213153315.GC10647@Red> (raw)
In-Reply-To: <CANc+2y5zegViTsPnuWZwWLUwdRk+ac6upaWOjH7iRFL_zEBxGg@mail.gmail.com>
On Tue, Dec 13, 2016 at 08:53:54PM +0530, PrasannaKumar Muralidharan wrote:
> > What do you think about those two solutions ?
>
> I prefer the second solution's idea of using two files (/dev/hwrng and
> /dev/hwprng). Upon having a quick glance it looks like (based on
> current_rng == prng check) that your current implementation allows
> only one rng device to be in use at a time. It would be better to have
> both usable at the same time. So applications that need pseudo random
> data at high speed can use /dev/prng while applications that require
> true random number can use /dev/rng. Please feel free to correct if my
> understanding of the code is incorrect. Along with this change I think
> changing the algif_rng to use this code if this solution is going to
> be used.
>
No, there could be both device at the same time.
WARNING: multiple messages have this Message-ID (diff)
From: clabbe.montjoie@gmail.com (Corentin Labbe)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] crypto: sun4i-ss: support the Security System PRNG
Date: Tue, 13 Dec 2016 16:33:15 +0100 [thread overview]
Message-ID: <20161213153315.GC10647@Red> (raw)
In-Reply-To: <CANc+2y5zegViTsPnuWZwWLUwdRk+ac6upaWOjH7iRFL_zEBxGg@mail.gmail.com>
On Tue, Dec 13, 2016 at 08:53:54PM +0530, PrasannaKumar Muralidharan wrote:
> > What do you think about those two solutions ?
>
> I prefer the second solution's idea of using two files (/dev/hwrng and
> /dev/hwprng). Upon having a quick glance it looks like (based on
> current_rng == prng check) that your current implementation allows
> only one rng device to be in use at a time. It would be better to have
> both usable at the same time. So applications that need pseudo random
> data at high speed can use /dev/prng while applications that require
> true random number can use /dev/rng. Please feel free to correct if my
> understanding of the code is incorrect. Along with this change I think
> changing the algif_rng to use this code if this solution is going to
> be used.
>
No, there could be both device at the same time.
WARNING: multiple messages have this Message-ID (diff)
From: Corentin Labbe <clabbe.montjoie@gmail.com>
To: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
Cc: Herbert Xu <herbert@gondor.apana.org.au>,
davem@davemloft.net, maxime.ripard@free-electrons.com,
Chen-Yu Tsai <wens@csie.org>,
linux-kernel@vger.kernel.org, linux-crypto@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v2] crypto: sun4i-ss: support the Security System PRNG
Date: Tue, 13 Dec 2016 16:33:15 +0100 [thread overview]
Message-ID: <20161213153315.GC10647@Red> (raw)
In-Reply-To: <CANc+2y5zegViTsPnuWZwWLUwdRk+ac6upaWOjH7iRFL_zEBxGg@mail.gmail.com>
On Tue, Dec 13, 2016 at 08:53:54PM +0530, PrasannaKumar Muralidharan wrote:
> > What do you think about those two solutions ?
>
> I prefer the second solution's idea of using two files (/dev/hwrng and
> /dev/hwprng). Upon having a quick glance it looks like (based on
> current_rng == prng check) that your current implementation allows
> only one rng device to be in use at a time. It would be better to have
> both usable at the same time. So applications that need pseudo random
> data at high speed can use /dev/prng while applications that require
> true random number can use /dev/rng. Please feel free to correct if my
> understanding of the code is incorrect. Along with this change I think
> changing the algif_rng to use this code if this solution is going to
> be used.
>
No, there could be both device at the same time.
next prev parent reply other threads:[~2016-12-13 15:33 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-05 10:48 [PATCH v2] crypto: sun4i-ss: support the Security System PRNG Corentin Labbe
2016-12-05 10:48 ` Corentin Labbe
2016-12-05 10:48 ` Corentin Labbe
2016-12-05 12:37 ` Herbert Xu
2016-12-05 12:37 ` Herbert Xu
2016-12-05 12:57 ` Corentin Labbe
2016-12-05 12:57 ` Corentin Labbe
2016-12-07 12:09 ` Herbert Xu
2016-12-07 12:09 ` Herbert Xu
2016-12-07 12:51 ` Corentin Labbe
2016-12-07 12:51 ` Corentin Labbe
2016-12-07 12:51 ` Corentin Labbe
2016-12-08 9:06 ` Herbert Xu
2016-12-08 9:06 ` Herbert Xu
2016-12-08 9:24 ` Corentin Labbe
2016-12-08 9:24 ` Corentin Labbe
2016-12-08 11:01 ` PrasannaKumar Muralidharan
2016-12-08 11:01 ` PrasannaKumar Muralidharan
2016-12-13 14:10 ` Corentin Labbe
2016-12-13 14:10 ` Corentin Labbe
2016-12-13 15:23 ` PrasannaKumar Muralidharan
2016-12-13 15:23 ` PrasannaKumar Muralidharan
2016-12-13 15:33 ` Corentin Labbe [this message]
2016-12-13 15:33 ` Corentin Labbe
2016-12-13 15:33 ` Corentin Labbe
2016-12-14 5:05 ` Herbert Xu
2016-12-14 5:05 ` Herbert Xu
2016-12-14 6:03 ` Corentin Labbe
2016-12-14 6:03 ` Corentin Labbe
2016-12-14 19:17 ` PrasannaKumar Muralidharan
2016-12-14 19:17 ` PrasannaKumar Muralidharan
2016-12-14 19:17 ` PrasannaKumar Muralidharan
2016-12-15 6:09 ` Herbert Xu
2016-12-15 6:09 ` Herbert Xu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161213153315.GC10647@Red \
--to=clabbe.montjoie@gmail.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maxime.ripard@free-electrons.com \
--cc=prasannatsmkumar@gmail.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.