All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
To: Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org>
Cc: Felipe Balbi <balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Sekhar Nori <nsekhar-l0cyMroinI0@public.gmane.org>,
	linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] usb: dwc3: omap: remove devm_request_threaded_irq
Date: Fri, 9 Dec 2016 13:59:58 -0800	[thread overview]
Message-ID: <20161209215958.GN4920@atomide.com> (raw)
In-Reply-To: <20161209205508.6456-1-grygorii.strashko-l0cyMroinI0@public.gmane.org>

* Grygorii Strashko <grygorii.strashko-l0cyMroinI0@public.gmane.org> [161209 12:55]:
> Switch back from devm_request_threaded_irq() to request_threaded_irq() to
> avoid races between interrupt handler execution and PM runtime in error
> handling code path in probe and in dwc3_omap_remove():

Can't you just call disable_irq() on the exit path instead of removing
devm?

Regards,

Tony
--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] usb: dwc3: omap: remove devm_request_threaded_irq
Date: Fri, 9 Dec 2016 13:59:58 -0800	[thread overview]
Message-ID: <20161209215958.GN4920@atomide.com> (raw)
In-Reply-To: <20161209205508.6456-1-grygorii.strashko@ti.com>

* Grygorii Strashko <grygorii.strashko@ti.com> [161209 12:55]:
> Switch back from devm_request_threaded_irq() to request_threaded_irq() to
> avoid races between interrupt handler execution and PM runtime in error
> handling code path in probe and in dwc3_omap_remove():

Can't you just call disable_irq() on the exit path instead of removing
devm?

Regards,

Tony

  parent reply	other threads:[~2016-12-09 21:59 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-09 20:55 [PATCH] usb: dwc3: omap: remove devm_request_threaded_irq Grygorii Strashko
2016-12-09 20:55 ` Grygorii Strashko
     [not found] ` <20161209205508.6456-1-grygorii.strashko-l0cyMroinI0@public.gmane.org>
2016-12-09 21:59   ` Tony Lindgren [this message]
2016-12-09 21:59     ` Tony Lindgren
     [not found]     ` <20161209215958.GN4920-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-12-09 22:46       ` Grygorii Strashko
2016-12-09 22:46         ` Grygorii Strashko
     [not found]         ` <db75608b-f92c-6bfa-80a9-a3ab3adf7c23-l0cyMroinI0@public.gmane.org>
2016-12-09 23:04           ` Tony Lindgren
2016-12-09 23:04             ` Tony Lindgren
     [not found]             ` <20161209230457.GO4920-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-12-09 23:32               ` Grygorii Strashko
2016-12-09 23:32                 ` Grygorii Strashko
     [not found]                 ` <e394c44c-3ae3-b0ac-2b02-a886ca2510bd-l0cyMroinI0@public.gmane.org>
2016-12-09 23:37                   ` Tony Lindgren
2016-12-09 23:37                     ` Tony Lindgren
     [not found]                     ` <20161209233728.GP4920-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2016-12-09 23:44                       ` Grygorii Strashko
2016-12-09 23:44                         ` Grygorii Strashko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161209215958.GN4920@atomide.com \
    --to=tony-4v6ys6ai5vpbdgjk7y7tuq@public.gmane.org \
    --cc=balbi-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org \
    --cc=grygorii.strashko-l0cyMroinI0@public.gmane.org \
    --cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
    --cc=linux-omap-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=nsekhar-l0cyMroinI0@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.