All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Sebastian Reichel <sre@kernel.org>
Cc: "Pavel Machek" <pavel@ucw.cz>,
	"Pali Rohár" <pali.rohar@gmail.com>,
	"kernel list" <linux-kernel@vger.kernel.org>,
	linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
	linux-omap@vger.kernel.org, khilman@kernel.org,
	aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com,
	patrikbachan@gmail.com, serge@hallyn.com, abcloriens@gmail.com
Subject: Re: partial bluetooth success on n900 [was Re: bluetooth/uart timeout handling]
Date: Wed, 14 Dec 2016 07:10:56 -0800	[thread overview]
Message-ID: <20161214151056.GX4920@atomide.com> (raw)
In-Reply-To: <20161214133158.mwvs574l4otbc7hf@earth>

* Sebastian Reichel <sre@kernel.org> [161214 05:32]:
> Hi Pali & Pavel,
> 
> On Wed, Dec 14, 2016 at 01:53:23PM +0100, Pavel Machek wrote:
> > > > [  220.248596] tty ttyO1: Radio packet sent
> > > > [  220.249328] Bluetooth: hci0: Frame reassembly failed (-84)
> > > > [  220.272949] tty ttyO1: wakeup received: 1 -> 0
> > > > [  221.283477] tty ttyO1: radio packet timeout!
> > > > [  221.283630] enqueue: hu c304cc80 skb cd4a9b40
> > > > [  223.363372] Bluetooth: hci0 command 0xfc18 tx timeout
> > > > pavel@n900:~$
> > > 
> > > In log are still some failures, but ... is bluetooth working now?
> 
> I could scan for devices. The code is still racy, though. It's
> most likely related to the newly introduced idle code. (Without
> sending the BT module to correctly idle the bcm2048 does not
> work correctly at all)
> 
> I was quite busy the last few weeks and did not manage to find
> much time for kernel work. Now I will first have to catch up
> with my power-supply tree.
> 
> > It is... for Sebastian. I'm playing with camera now.
> > 
> > > I see that you applied this patch: 
> > > https://git.kernel.org/cgit/linux/kernel/git/pavel/linux-n900.git/commit/?id=051aa3fbf03ac770d8344690f5a936a7f04c6884
> > > 
> > > Looks like that pinmux is in DTS file incorrect. Can somebody verify it? 
> > > Maybe Tony?
> > 
> > Yes, it is. Sebastian was pretty certain about that.
> 
> Yes, I'm certain. The bootloader enables the pullup resistors.
> Note, that the wrong DTS entry is not in mainline. My bluetooth
> branch has a fixed DTS patch instead of a fixup patch on top of
> the broken one:
> 
> https://git.kernel.org/cgit/linux/kernel/git/sre/linux-n900.git/commit/?h=nokia-bluetooth-dev&id=6b63c111a979d100cfbdd76cb4a6bbadace35216

Maybe send it so we can merge it as a fix during the early -rc
cycle?

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: partial bluetooth success on n900 [was Re: bluetooth/uart timeout handling]
Date: Wed, 14 Dec 2016 07:10:56 -0800	[thread overview]
Message-ID: <20161214151056.GX4920@atomide.com> (raw)
In-Reply-To: <20161214133158.mwvs574l4otbc7hf@earth>

* Sebastian Reichel <sre@kernel.org> [161214 05:32]:
> Hi Pali & Pavel,
> 
> On Wed, Dec 14, 2016 at 01:53:23PM +0100, Pavel Machek wrote:
> > > > [  220.248596] tty ttyO1: Radio packet sent
> > > > [  220.249328] Bluetooth: hci0: Frame reassembly failed (-84)
> > > > [  220.272949] tty ttyO1: wakeup received: 1 -> 0
> > > > [  221.283477] tty ttyO1: radio packet timeout!
> > > > [  221.283630] enqueue: hu c304cc80 skb cd4a9b40
> > > > [  223.363372] Bluetooth: hci0 command 0xfc18 tx timeout
> > > > pavel at n900:~$
> > > 
> > > In log are still some failures, but ... is bluetooth working now?
> 
> I could scan for devices. The code is still racy, though. It's
> most likely related to the newly introduced idle code. (Without
> sending the BT module to correctly idle the bcm2048 does not
> work correctly at all)
> 
> I was quite busy the last few weeks and did not manage to find
> much time for kernel work. Now I will first have to catch up
> with my power-supply tree.
> 
> > It is... for Sebastian. I'm playing with camera now.
> > 
> > > I see that you applied this patch: 
> > > https://git.kernel.org/cgit/linux/kernel/git/pavel/linux-n900.git/commit/?id=051aa3fbf03ac770d8344690f5a936a7f04c6884
> > > 
> > > Looks like that pinmux is in DTS file incorrect. Can somebody verify it? 
> > > Maybe Tony?
> > 
> > Yes, it is. Sebastian was pretty certain about that.
> 
> Yes, I'm certain. The bootloader enables the pullup resistors.
> Note, that the wrong DTS entry is not in mainline. My bluetooth
> branch has a fixed DTS patch instead of a fixup patch on top of
> the broken one:
> 
> https://git.kernel.org/cgit/linux/kernel/git/sre/linux-n900.git/commit/?h=nokia-bluetooth-dev&id=6b63c111a979d100cfbdd76cb4a6bbadace35216

Maybe send it so we can merge it as a fix during the early -rc
cycle?

Regards,

Tony

  reply	other threads:[~2016-12-14 15:10 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <20161016002454.ul5rdqwubvkct4pf@earth>
     [not found] ` <20161016090959.GA377@amd>
     [not found]   ` <20161016173911.arxynrja6vely3d5@earth>
     [not found]     ` <20161017085137.GA6628@amd>
     [not found]       ` <20161018224259.jrwbaal27irzjqyo@earth>
2016-10-19  9:25         ` partial bluetooth success on n900 [was Re: bluetooth/uart timeout handling] Pavel Machek
2016-10-19  9:25           ` Pavel Machek
2016-10-19  9:25           ` Pavel Machek
2016-12-14 12:21           ` Pali Rohár
2016-12-14 12:21             ` Pali Rohár
2016-12-14 12:53             ` Pavel Machek
2016-12-14 12:53               ` Pavel Machek
2016-12-14 13:31               ` Sebastian Reichel
2016-12-14 13:31                 ` Sebastian Reichel
2016-12-14 13:31                 ` Sebastian Reichel
2016-12-14 15:10                 ` Tony Lindgren [this message]
2016-12-14 15:10                   ` Tony Lindgren
2016-12-14 15:52                   ` Sebastian Reichel
2016-12-14 15:52                     ` Sebastian Reichel
2016-12-14 16:02                     ` Tony Lindgren
2016-12-14 16:02                       ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161214151056.GX4920@atomide.com \
    --to=tony@atomide.com \
    --cc=aaro.koskinen@iki.fi \
    --cc=abcloriens@gmail.com \
    --cc=ivo.g.dimitrov.75@gmail.com \
    --cc=khilman@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=pali.rohar@gmail.com \
    --cc=patrikbachan@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=serge@hallyn.com \
    --cc=sre@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.