From: Tony Lindgren <tony@atomide.com>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: Vaneet Narang <v.narang@samsung.com>,
paul@pwsan.com, linux@armlinux.org.uk,
linux-kernel@vger.kernel.org, ajeet.y@samsung.com,
bcousson@baylibre.com, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, pankaj.m@samsung.com
Subject: Re: [PATCH v3] mach-omap2: fixing wrong strcat for Non-NULL terminated string
Date: Tue, 27 Dec 2016 09:40:18 -0800 [thread overview]
Message-ID: <20161227174018.GT4920@atomide.com> (raw)
In-Reply-To: <1481170230-2120-1-git-send-email-maninder1.s@samsung.com>
* Maninder Singh <maninder1.s@samsung.com> [161207 20:16]:
> Issue caught with static analysis tool:
> "Dangerous usage of 'name' (strncpy doesn't always 0-terminate it)"
>
> Use strlcpy _includes_ the NUL terminator, and strlcat() which ensures
> that it won't overflow the buffer.
Applying into omap-for-v4.10/fixes thanks.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3] mach-omap2: fixing wrong strcat for Non-NULL terminated string
Date: Tue, 27 Dec 2016 09:40:18 -0800 [thread overview]
Message-ID: <20161227174018.GT4920@atomide.com> (raw)
In-Reply-To: <1481170230-2120-1-git-send-email-maninder1.s@samsung.com>
* Maninder Singh <maninder1.s@samsung.com> [161207 20:16]:
> Issue caught with static analysis tool:
> "Dangerous usage of 'name' (strncpy doesn't always 0-terminate it)"
>
> Use strlcpy _includes_ the NUL terminator, and strlcat() which ensures
> that it won't overflow the buffer.
Applying into omap-for-v4.10/fixes thanks.
Tony
WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Maninder Singh <maninder1.s@samsung.com>
Cc: bcousson@baylibre.com, paul@pwsan.com, linux@armlinux.org.uk,
linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, pankaj.m@samsung.com,
ajeet.y@samsung.com, Vaneet Narang <v.narang@samsung.com>
Subject: Re: [PATCH v3] mach-omap2: fixing wrong strcat for Non-NULL terminated string
Date: Tue, 27 Dec 2016 09:40:18 -0800 [thread overview]
Message-ID: <20161227174018.GT4920@atomide.com> (raw)
In-Reply-To: <1481170230-2120-1-git-send-email-maninder1.s@samsung.com>
* Maninder Singh <maninder1.s@samsung.com> [161207 20:16]:
> Issue caught with static analysis tool:
> "Dangerous usage of 'name' (strncpy doesn't always 0-terminate it)"
>
> Use strlcpy _includes_ the NUL terminator, and strlcat() which ensures
> that it won't overflow the buffer.
Applying into omap-for-v4.10/fixes thanks.
Tony
next prev parent reply other threads:[~2016-12-27 17:40 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-08 4:10 [PATCH v3] mach-omap2: fixing wrong strcat for Non-NULL terminated string Maninder Singh
2016-12-08 4:10 ` Maninder Singh
2016-12-27 17:40 ` Tony Lindgren [this message]
2016-12-27 17:40 ` Tony Lindgren
2016-12-27 17:40 ` Tony Lindgren
-- strict thread matches above, loose matches on Subject: below --
2016-12-05 5:27 Maninder Singh
2016-12-05 5:27 ` Maninder Singh
2016-12-06 17:08 ` Tony Lindgren
2016-12-06 17:08 ` Tony Lindgren
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161227174018.GT4920@atomide.com \
--to=tony@atomide.com \
--cc=ajeet.y@samsung.com \
--cc=bcousson@baylibre.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maninder1.s@samsung.com \
--cc=pankaj.m@samsung.com \
--cc=paul@pwsan.com \
--cc=v.narang@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.