All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "André Przywara" <andre.przywara@arm.com>,
	linux-sunxi <linux-sunxi@googlegroups.com>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"Icenowy Zheng" <icenowy@aosc.xyz>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Maxime Ripard" <maxime.ripard@free-electrons.com>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>
Subject: Re: [linux-sunxi] [PATCH 1/2] drivers: pinctrl: add driver for Allwinner H5 SoC
Date: Fri, 30 Dec 2016 11:42:11 -0800	[thread overview]
Message-ID: <20161230194210.GE3940@atomide.com> (raw)
In-Reply-To: <CACRpkdYQhfid3VRcaj=7as_+Zg=pX3Svp9FJ_W_Ft8nVuoZqKQ@mail.gmail.com>

* Linus Walleij <linus.walleij@linaro.org> [161230 04:56]:
> On Mon, Dec 26, 2016 at 3:33 PM, André Przywara <andre.przywara@arm.com> wrote:
> 
> > So while this patch technically looks correct, I was wondering if we
> > should really explore the possibility of making the whole of sunxi
> > pinctrl DT controlled.
> > I brought this up a while ago, but people weren't overly enthusiastic
> > about it, though their argument weren't really convincing to me[1].
> >
> > So:
> > As this "driver" here is basically a table linking GPIO bit settings
> > (the actual mux value) to names and every pin we care about needs to be
> > enumerated in the DT anyway, why not just add something like:
> > allwinner,pinmux = <4>;
> > to each pin(group) in the DT and get rid of this "driver" file here
> > entirely?
> 
> I'm open to that if you can use pinctrl-single which is in the kernel
> for this purpose only, and is used with both OMAPs and HiSilicon.
> 
> It recently was improved and will be improved more in this cycle,
> see for example:
> commit 42124bc598f64f84b3335d5a058304207695b84f
> pinctrl: Introduce generic #pinctrl-cells and pinctrl_parse_index_with_args
> 
> > (...) Also I guess the common sunxi
> > pinctrl driver code needs some significant rework.
> 
> I would guess is just needs replacing with pinctrl-single in that case.

And if pinctrl-single won't work then it is now also be easier to make
hardware specific drivers too using #pinctrl-cells + GENERIC_PINCTRL_GROUPS +
GENERIC_PINMUX_FUNCTIONS.

Regards,

Tony


_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [linux-sunxi] [PATCH 1/2] drivers: pinctrl: add driver for Allwinner H5 SoC
Date: Fri, 30 Dec 2016 11:42:11 -0800	[thread overview]
Message-ID: <20161230194210.GE3940@atomide.com> (raw)
In-Reply-To: <CACRpkdYQhfid3VRcaj=7as_+Zg=pX3Svp9FJ_W_Ft8nVuoZqKQ@mail.gmail.com>

* Linus Walleij <linus.walleij@linaro.org> [161230 04:56]:
> On Mon, Dec 26, 2016 at 3:33 PM, Andr? Przywara <andre.przywara@arm.com> wrote:
> 
> > So while this patch technically looks correct, I was wondering if we
> > should really explore the possibility of making the whole of sunxi
> > pinctrl DT controlled.
> > I brought this up a while ago, but people weren't overly enthusiastic
> > about it, though their argument weren't really convincing to me[1].
> >
> > So:
> > As this "driver" here is basically a table linking GPIO bit settings
> > (the actual mux value) to names and every pin we care about needs to be
> > enumerated in the DT anyway, why not just add something like:
> > allwinner,pinmux = <4>;
> > to each pin(group) in the DT and get rid of this "driver" file here
> > entirely?
> 
> I'm open to that if you can use pinctrl-single which is in the kernel
> for this purpose only, and is used with both OMAPs and HiSilicon.
> 
> It recently was improved and will be improved more in this cycle,
> see for example:
> commit 42124bc598f64f84b3335d5a058304207695b84f
> pinctrl: Introduce generic #pinctrl-cells and pinctrl_parse_index_with_args
> 
> > (...) Also I guess the common sunxi
> > pinctrl driver code needs some significant rework.
> 
> I would guess is just needs replacing with pinctrl-single in that case.

And if pinctrl-single won't work then it is now also be easier to make
hardware specific drivers too using #pinctrl-cells + GENERIC_PINCTRL_GROUPS +
GENERIC_PINMUX_FUNCTIONS.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: "André Przywara" <andre.przywara@arm.com>,
	"Icenowy Zheng" <icenowy@aosc.xyz>,
	"Catalin Marinas" <catalin.marinas@arm.com>,
	"Maxime Ripard" <maxime.ripard@free-electrons.com>,
	"Chen-Yu Tsai" <wens@csie.org>,
	"linux-arm-kernel@lists.infradead.org"
	<linux-arm-kernel@lists.infradead.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>,
	linux-sunxi <linux-sunxi@googlegroups.com>
Subject: Re: [linux-sunxi] [PATCH 1/2] drivers: pinctrl: add driver for Allwinner H5 SoC
Date: Fri, 30 Dec 2016 11:42:11 -0800	[thread overview]
Message-ID: <20161230194210.GE3940@atomide.com> (raw)
In-Reply-To: <CACRpkdYQhfid3VRcaj=7as_+Zg=pX3Svp9FJ_W_Ft8nVuoZqKQ@mail.gmail.com>

* Linus Walleij <linus.walleij@linaro.org> [161230 04:56]:
> On Mon, Dec 26, 2016 at 3:33 PM, André Przywara <andre.przywara@arm.com> wrote:
> 
> > So while this patch technically looks correct, I was wondering if we
> > should really explore the possibility of making the whole of sunxi
> > pinctrl DT controlled.
> > I brought this up a while ago, but people weren't overly enthusiastic
> > about it, though their argument weren't really convincing to me[1].
> >
> > So:
> > As this "driver" here is basically a table linking GPIO bit settings
> > (the actual mux value) to names and every pin we care about needs to be
> > enumerated in the DT anyway, why not just add something like:
> > allwinner,pinmux = <4>;
> > to each pin(group) in the DT and get rid of this "driver" file here
> > entirely?
> 
> I'm open to that if you can use pinctrl-single which is in the kernel
> for this purpose only, and is used with both OMAPs and HiSilicon.
> 
> It recently was improved and will be improved more in this cycle,
> see for example:
> commit 42124bc598f64f84b3335d5a058304207695b84f
> pinctrl: Introduce generic #pinctrl-cells and pinctrl_parse_index_with_args
> 
> > (...) Also I guess the common sunxi
> > pinctrl driver code needs some significant rework.
> 
> I would guess is just needs replacing with pinctrl-single in that case.

And if pinctrl-single won't work then it is now also be easier to make
hardware specific drivers too using #pinctrl-cells + GENERIC_PINCTRL_GROUPS +
GENERIC_PINMUX_FUNCTIONS.

Regards,

Tony

  reply	other threads:[~2016-12-30 19:42 UTC|newest]

Thread overview: 39+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-12-23 12:50 [PATCH 1/2] drivers: pinctrl: add driver for Allwinner H5 SoC Icenowy Zheng
2016-12-23 12:50 ` Icenowy Zheng
     [not found] ` <20161223125001.1176-1-icenowy-ymACFijhrKM@public.gmane.org>
2016-12-23 12:50   ` [PATCH 2/2] arm64: allwinner: Kconfig: add essential pinctrl driver for H5 Icenowy Zheng
2016-12-23 12:50     ` Icenowy Zheng
2016-12-26 14:33   ` [PATCH 1/2] drivers: pinctrl: add driver for Allwinner H5 SoC André Przywara
2016-12-26 14:33     ` [linux-sunxi] " André Przywara
2016-12-26 14:33     ` André Przywara
     [not found]     ` <1280f095-ab03-93f8-14d2-99d13ba1ce55-5wv7dgnIgG8@public.gmane.org>
2016-12-30 12:55       ` Linus Walleij
2016-12-30 12:55         ` [linux-sunxi] " Linus Walleij
2016-12-30 12:55         ` Linus Walleij
2016-12-30 19:42         ` Tony Lindgren [this message]
2016-12-30 19:42           ` Tony Lindgren
2016-12-30 19:42           ` Tony Lindgren
     [not found]         ` <CACRpkdYQhfid3VRcaj=7as_+Zg=pX3Svp9FJ_W_Ft8nVuoZqKQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-05 22:42           ` Maxime Ripard
2017-01-05 22:42             ` [linux-sunxi] " Maxime Ripard
2017-01-05 22:42             ` Maxime Ripard
2017-01-09  0:16             ` André Przywara
2017-01-09  0:16               ` [linux-sunxi] " André Przywara
2017-01-09  0:16               ` André Przywara
2017-01-16 16:31               ` Maxime Ripard
2017-01-16 16:31                 ` Maxime Ripard
2017-01-16 16:31                 ` Maxime Ripard
2017-01-18  9:44                 ` Andre Przywara
2017-01-18  9:44                   ` [linux-sunxi] " Andre Przywara
2017-01-18  9:44                   ` Andre Przywara
     [not found]                   ` <87a535d3-1170-c388-ce7d-4921e69f4cab-5wv7dgnIgG8@public.gmane.org>
2017-01-19  9:23                     ` Linus Walleij
2017-01-19  9:23                       ` [linux-sunxi] " Linus Walleij
2017-01-19  9:23                       ` Linus Walleij
     [not found]                       ` <CACRpkdaTVY7Of5bKyk81xA2kUnZVMQ8LnWEJosg7Ns3s5nAEYQ-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2017-01-19 13:11                         ` Icenowy Zheng
2017-01-19 13:11                           ` [linux-sunxi] " Icenowy Zheng
     [not found]                           ` <128701484831509-mf8Frdr2Tdlxpj1cXAZ9Bg@public.gmane.org>
2017-01-19 17:29                             ` Maxime Ripard
2017-01-19 17:29                               ` [linux-sunxi] " Maxime Ripard
2017-01-19 17:29                               ` Maxime Ripard
2017-01-19 17:41                     ` Maxime Ripard
2017-01-19 17:41                       ` [linux-sunxi] " Maxime Ripard
2017-01-19 17:41                       ` Maxime Ripard
2017-01-26 10:03                       ` Linus Walleij
2017-01-26 10:03                         ` [linux-sunxi] " Linus Walleij
2017-01-26 10:03                         ` Linus Walleij

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20161230194210.GE3940@atomide.com \
    --to=tony@atomide.com \
    --cc=andre.przywara@arm.com \
    --cc=catalin.marinas@arm.com \
    --cc=icenowy@aosc.xyz \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@googlegroups.com \
    --cc=maxime.ripard@free-electrons.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.