From: Mark Rutland <mark.rutland@arm.com>
To: Christopher Covington <cov@codeaurora.org>
Cc: kvm@vger.kernel.org, Marc Zyngier <marc.zyngier@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
timur@codeaurora.org, Will Deacon <will.deacon@arm.com>,
linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Paolo Bonzini <pbonzini@redhat.com>,
kvmarm@lists.cs.columbia.edu
Subject: Re: [PATCH v2 4/5] arm64: Use __tlbi_dsb() macros in KVM code
Date: Tue, 3 Jan 2017 15:57:56 +0000 [thread overview]
Message-ID: <20170103155756.GB14183@leverpostej> (raw)
In-Reply-To: <20161229224335.13531-4-cov@codeaurora.org>
On Thu, Dec 29, 2016 at 05:43:34PM -0500, Christopher Covington wrote:
> Refactor the KVM code to use the newly introduced __tlbi_dsb macros, which
> will allow an errata workaround that repeats tlbi dsb sequences to only
> change one location. This is not intended to change the generated assembly
> and comparing before and after vmlinux objdump shows no functional changes.
> @@ -40,9 +41,7 @@ void __hyp_text __kvm_tlb_flush_vmid_ipa(struct kvm *kvm, phys_addr_t ipa)
> * complete (S1 + S2) walk based on the old Stage-2 mapping if
> * the Stage-1 invalidation happened first.
> */
> - dsb(ish);
Looks like this got accidentally removed. AFAICT it is still necessary.
> - asm volatile("tlbi vmalle1is" : : );
> - dsb(ish);
> + __tlbi_dsb(vmalle1is, ish);
> isb();
Thanks,
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2 4/5] arm64: Use __tlbi_dsb() macros in KVM code
Date: Tue, 3 Jan 2017 15:57:56 +0000 [thread overview]
Message-ID: <20170103155756.GB14183@leverpostej> (raw)
In-Reply-To: <20161229224335.13531-4-cov@codeaurora.org>
On Thu, Dec 29, 2016 at 05:43:34PM -0500, Christopher Covington wrote:
> Refactor the KVM code to use the newly introduced __tlbi_dsb macros, which
> will allow an errata workaround that repeats tlbi dsb sequences to only
> change one location. This is not intended to change the generated assembly
> and comparing before and after vmlinux objdump shows no functional changes.
> @@ -40,9 +41,7 @@ void __hyp_text __kvm_tlb_flush_vmid_ipa(struct kvm *kvm, phys_addr_t ipa)
> * complete (S1 + S2) walk based on the old Stage-2 mapping if
> * the Stage-1 invalidation happened first.
> */
> - dsb(ish);
Looks like this got accidentally removed. AFAICT it is still necessary.
> - asm volatile("tlbi vmalle1is" : : );
> - dsb(ish);
> + __tlbi_dsb(vmalle1is, ish);
> isb();
Thanks,
Mark.
WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Christopher Covington <cov@codeaurora.org>
Cc: "Paolo Bonzini" <pbonzini@redhat.com>,
"Radim Krčmář" <rkrcmar@redhat.com>,
"Christoffer Dall" <christoffer.dall@linaro.org>,
"Marc Zyngier" <marc.zyngier@arm.com>,
"Catalin Marinas" <catalin.marinas@arm.com>,
"Will Deacon" <will.deacon@arm.com>,
kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kvmarm@lists.cs.columbia.edu, linux-kernel@vger.kernel.org,
shankerd@codeaurora.org, timur@codeaurora.org
Subject: Re: [PATCH v2 4/5] arm64: Use __tlbi_dsb() macros in KVM code
Date: Tue, 3 Jan 2017 15:57:56 +0000 [thread overview]
Message-ID: <20170103155756.GB14183@leverpostej> (raw)
In-Reply-To: <20161229224335.13531-4-cov@codeaurora.org>
On Thu, Dec 29, 2016 at 05:43:34PM -0500, Christopher Covington wrote:
> Refactor the KVM code to use the newly introduced __tlbi_dsb macros, which
> will allow an errata workaround that repeats tlbi dsb sequences to only
> change one location. This is not intended to change the generated assembly
> and comparing before and after vmlinux objdump shows no functional changes.
> @@ -40,9 +41,7 @@ void __hyp_text __kvm_tlb_flush_vmid_ipa(struct kvm *kvm, phys_addr_t ipa)
> * complete (S1 + S2) walk based on the old Stage-2 mapping if
> * the Stage-1 invalidation happened first.
> */
> - dsb(ish);
Looks like this got accidentally removed. AFAICT it is still necessary.
> - asm volatile("tlbi vmalle1is" : : );
> - dsb(ish);
> + __tlbi_dsb(vmalle1is, ish);
> isb();
Thanks,
Mark.
next prev parent reply other threads:[~2017-01-03 15:57 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-29 22:43 [PATCH v2 1/5] arm64: Define Falkor v1 CPU Christopher Covington
2016-12-29 22:43 ` Christopher Covington
2016-12-29 22:43 ` Christopher Covington
2016-12-29 22:43 ` [PATCH v2 2/5] arm64: Work around Falkor erratum 1003 Christopher Covington
2016-12-29 22:43 ` Christopher Covington
2016-12-29 22:43 ` Christopher Covington
2016-12-29 23:02 ` Timur Tabi
2016-12-29 23:02 ` Timur Tabi
2017-01-06 15:39 ` Christopher Covington
2017-01-06 15:39 ` Christopher Covington
2017-01-06 15:51 ` Timur Tabi
2017-01-06 15:51 ` Timur Tabi
2016-12-29 23:08 ` Timur Tabi
2016-12-29 23:08 ` Timur Tabi
2017-01-06 15:44 ` Christopher Covington
2017-01-06 15:44 ` Christopher Covington
2017-01-06 15:49 ` Timur Tabi
2017-01-06 15:49 ` Timur Tabi
2016-12-30 2:44 ` kbuild test robot
2016-12-30 2:44 ` kbuild test robot
2016-12-30 2:44 ` kbuild test robot
2017-01-03 15:55 ` Mark Rutland
2017-01-03 15:55 ` Mark Rutland
2017-01-03 15:55 ` Mark Rutland
2017-01-06 15:49 ` Christopher Covington
2017-01-06 15:49 ` Christopher Covington
2017-01-06 15:49 ` Christopher Covington
2017-01-04 10:33 ` Christoffer Dall
2017-01-04 10:33 ` Christoffer Dall
2017-01-04 10:33 ` Christoffer Dall
2017-01-11 13:11 ` Christopher Covington
2017-01-11 13:11 ` Christopher Covington
2017-01-11 13:11 ` Christopher Covington
2016-12-29 22:43 ` [PATCH v2 3/5] arm64: Create and use __tlbi_dsb() macros Christopher Covington
2016-12-29 22:43 ` Christopher Covington
2016-12-29 22:43 ` Christopher Covington
2016-12-29 22:43 ` [PATCH v2 4/5] arm64: Use __tlbi_dsb() macros in KVM code Christopher Covington
2016-12-29 22:43 ` Christopher Covington
2016-12-29 22:43 ` Christopher Covington
2017-01-03 15:57 ` Mark Rutland [this message]
2017-01-03 15:57 ` Mark Rutland
2017-01-03 15:57 ` Mark Rutland
2017-01-06 15:51 ` Christopher Covington
2017-01-06 15:51 ` Christopher Covington
2017-01-06 16:05 ` Mark Rutland
2017-01-06 16:05 ` Mark Rutland
2017-01-06 16:05 ` Mark Rutland
2016-12-29 22:43 ` [PATCH v2 5/5] arm64: Work around Falkor erratum 1009 Christopher Covington
2016-12-29 22:43 ` Christopher Covington
2016-12-29 22:43 ` Christopher Covington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170103155756.GB14183@leverpostej \
--to=mark.rutland@arm.com \
--cc=catalin.marinas@arm.com \
--cc=cov@codeaurora.org \
--cc=kvm@vger.kernel.org \
--cc=kvmarm@lists.cs.columbia.edu \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marc.zyngier@arm.com \
--cc=pbonzini@redhat.com \
--cc=timur@codeaurora.org \
--cc=will.deacon@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.