All of lore.kernel.org
 help / color / mirror / Atom feed
From: mark.rutland@arm.com (Mark Rutland)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCHv2 4/5] arm: mvebu: Add device tree for 98DX3236 SoCs
Date: Thu, 5 Jan 2017 13:58:37 +0000	[thread overview]
Message-ID: <20170105135837.GC25333@leverpostej> (raw)
In-Reply-To: <20170105033641.6212-5-chris.packham@alliedtelesis.co.nz>

On Thu, Jan 05, 2017 at 04:36:40PM +1300, Chris Packham wrote:
> +		internal-regs {
> +			coreclk: mvebu-sar at 18230 {
> +				compatible = "marvell,mv98dx3236-core-clock";
> +			};
> +
> +			cpuclk: clock-complex at 18700 {
> +				compatible = "marvell,mv98dx3236-cpu-clock";
> +			};
> +
> +			corediv-clock at 18740 {
> +				compatible = "marvell,mv98dx3236-corediv-clock";
> +				reg = <0xf8268 0xc>;
> +				base = <&dfx>;
> +				#clock-cells = <1>;
> +				clocks = <&mainpll>;
> +				clock-output-names = "nand";
> +			};

[...]

> +		};
> +
> +		dfx-registers {
> +			compatible = "simple-bus";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			ranges = <0 MBUS_ID(0x08, 0x00) 0 0x100000>;
> +
> +			dfx: dfx at 0 {
> +				compatible = "simple-bus";
> +				reg = <0 0x100000>;
> +			};
> +		};

What is this dfx-registers, exactly? It has no children, so why is it a
simple-bus?

>From the above, and the patch adding the corediv driver, it looks like
the corediv-clock actually lives in this block, so I don't understand
why the corediv-clock is sitting in internal-regs with a sideband
reference to dfx.

Thanks,
Mark.

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>
To: Chris Packham
	<chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
	Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
	Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>,
	Gregory Clement
	<gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
	Sebastian Hesselbarth
	<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
	Russell King <linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org>,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
	linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCHv2 4/5] arm: mvebu: Add device tree for 98DX3236 SoCs
Date: Thu, 5 Jan 2017 13:58:37 +0000	[thread overview]
Message-ID: <20170105135837.GC25333@leverpostej> (raw)
In-Reply-To: <20170105033641.6212-5-chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>

On Thu, Jan 05, 2017 at 04:36:40PM +1300, Chris Packham wrote:
> +		internal-regs {
> +			coreclk: mvebu-sar@18230 {
> +				compatible = "marvell,mv98dx3236-core-clock";
> +			};
> +
> +			cpuclk: clock-complex@18700 {
> +				compatible = "marvell,mv98dx3236-cpu-clock";
> +			};
> +
> +			corediv-clock@18740 {
> +				compatible = "marvell,mv98dx3236-corediv-clock";
> +				reg = <0xf8268 0xc>;
> +				base = <&dfx>;
> +				#clock-cells = <1>;
> +				clocks = <&mainpll>;
> +				clock-output-names = "nand";
> +			};

[...]

> +		};
> +
> +		dfx-registers {
> +			compatible = "simple-bus";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			ranges = <0 MBUS_ID(0x08, 0x00) 0 0x100000>;
> +
> +			dfx: dfx@0 {
> +				compatible = "simple-bus";
> +				reg = <0 0x100000>;
> +			};
> +		};

What is this dfx-registers, exactly? It has no children, so why is it a
simple-bus?

>From the above, and the patch adding the corediv driver, it looks like
the corediv-clock actually lives in this block, so I don't understand
why the corediv-clock is sitting in internal-regs with a sideband
reference to dfx.

Thanks,
Mark.
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

WARNING: multiple messages have this Message-ID (diff)
From: Mark Rutland <mark.rutland@arm.com>
To: Chris Packham <chris.packham@alliedtelesis.co.nz>
Cc: linux-arm-kernel@lists.infradead.org,
	Rob Herring <robh+dt@kernel.org>,
	Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
	Gregory Clement <gregory.clement@free-electrons.com>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Russell King <linux@armlinux.org.uk>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv2 4/5] arm: mvebu: Add device tree for 98DX3236 SoCs
Date: Thu, 5 Jan 2017 13:58:37 +0000	[thread overview]
Message-ID: <20170105135837.GC25333@leverpostej> (raw)
In-Reply-To: <20170105033641.6212-5-chris.packham@alliedtelesis.co.nz>

On Thu, Jan 05, 2017 at 04:36:40PM +1300, Chris Packham wrote:
> +		internal-regs {
> +			coreclk: mvebu-sar@18230 {
> +				compatible = "marvell,mv98dx3236-core-clock";
> +			};
> +
> +			cpuclk: clock-complex@18700 {
> +				compatible = "marvell,mv98dx3236-cpu-clock";
> +			};
> +
> +			corediv-clock@18740 {
> +				compatible = "marvell,mv98dx3236-corediv-clock";
> +				reg = <0xf8268 0xc>;
> +				base = <&dfx>;
> +				#clock-cells = <1>;
> +				clocks = <&mainpll>;
> +				clock-output-names = "nand";
> +			};

[...]

> +		};
> +
> +		dfx-registers {
> +			compatible = "simple-bus";
> +			#address-cells = <1>;
> +			#size-cells = <1>;
> +			ranges = <0 MBUS_ID(0x08, 0x00) 0 0x100000>;
> +
> +			dfx: dfx@0 {
> +				compatible = "simple-bus";
> +				reg = <0 0x100000>;
> +			};
> +		};

What is this dfx-registers, exactly? It has no children, so why is it a
simple-bus?

>From the above, and the patch adding the corediv driver, it looks like
the corediv-clock actually lives in this block, so I don't understand
why the corediv-clock is sitting in internal-regs with a sideband
reference to dfx.

Thanks,
Mark.

  parent reply	other threads:[~2017-01-05 13:58 UTC|newest]

Thread overview: 129+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-05  3:36 [PATCHv2 0/5] Support for Marvell switches with integrated CPUs Chris Packham
2017-01-05  3:36 ` Chris Packham
2017-01-05  3:36 ` Chris Packham
2017-01-05  3:36 ` [PATCHv2 1/5] clk: mvebu: support for 98DX3236 SoC Chris Packham
2017-01-05  3:36   ` Chris Packham
2017-01-05  3:36   ` Chris Packham
2017-01-05 13:53   ` Mark Rutland
2017-01-05 13:53     ` Mark Rutland
2017-01-05 13:53     ` Mark Rutland
2017-01-05 23:05     ` Chris Packham
2017-01-05 23:05       ` Chris Packham
2017-01-05 23:05       ` Chris Packham
2017-01-05 23:05       ` Chris Packham
2017-01-05  3:36 ` [PATCHv2 2/5] arm: mvebu: support for SMP on 98DX3336 SoC Chris Packham
2017-01-05  3:36   ` Chris Packham
2017-01-05  3:36   ` Chris Packham
2017-01-05  4:04   ` Florian Fainelli
2017-01-05  4:04     ` Florian Fainelli
2017-01-05  4:04     ` Florian Fainelli
2017-01-05  4:46     ` Chris Packham
2017-01-05  4:46       ` Chris Packham
2017-01-05  4:46       ` Chris Packham
2017-01-05 20:49       ` Chris Packham
2017-01-05 20:49         ` Chris Packham
2017-01-05 20:49         ` Chris Packham
2017-01-05  3:36 ` [PATCHv2 3/5] pinctrl: mvebu: pinctrl driver for 98DX3236 SoC Chris Packham
2017-01-05  3:36   ` Chris Packham
2017-01-05  3:36 ` [PATCHv2 4/5] arm: mvebu: Add device tree for 98DX3236 SoCs Chris Packham
2017-01-05  3:36   ` Chris Packham
2017-01-05  3:36   ` Chris Packham
2017-01-05  4:06   ` Florian Fainelli
2017-01-05  4:06     ` Florian Fainelli
2017-01-05  4:06     ` Florian Fainelli
2017-01-05  4:34     ` Chris Packham
2017-01-05  4:34       ` Chris Packham
2017-01-05  4:34       ` Chris Packham
2017-01-05 13:58   ` Mark Rutland [this message]
2017-01-05 13:58     ` Mark Rutland
2017-01-05 13:58     ` Mark Rutland
2017-01-05 20:10     ` Chris Packham
2017-01-05 20:10       ` Chris Packham
2017-01-05 20:10       ` Chris Packham
2017-01-05  3:36 ` [PATCHv2 5/5] arm: mvebu: Add device tree for db-dxbc2 and db-xc3-24g4xg boards Chris Packham
2017-01-05  3:36   ` Chris Packham
2017-01-05  3:36   ` Chris Packham
2017-01-05  4:07 ` [PATCHv2 0/5] Support for Marvell switches with integrated CPUs Florian Fainelli
2017-01-05  4:07   ` Florian Fainelli
2017-01-05  4:07   ` Florian Fainelli
2017-01-05  4:24   ` Chris Packham
2017-01-05  4:24     ` Chris Packham
2017-01-05  4:24     ` Chris Packham
2017-01-05  4:24     ` Chris Packham
2017-01-05 13:09     ` Andrew Lunn
2017-01-05 13:09       ` Andrew Lunn
2017-01-05 13:09       ` Andrew Lunn
2017-01-05 14:07       ` Marcin Wojtas
2017-01-05 14:07         ` Marcin Wojtas
2017-01-05 14:07         ` Marcin Wojtas
2017-01-05 19:46       ` Chris Packham
2017-01-05 19:46         ` Chris Packham
2017-01-05 19:46         ` Chris Packham
2017-01-05 19:46         ` Chris Packham
2017-01-05 19:52         ` Florian Fainelli
2017-01-05 19:52           ` Florian Fainelli
2017-01-05 19:52           ` Florian Fainelli
2017-01-05 14:09 ` Marcin Wojtas
2017-01-05 14:09   ` Marcin Wojtas
2017-01-05 14:09   ` Marcin Wojtas
2017-01-05 20:02   ` Chris Packham
2017-01-05 20:02     ` Chris Packham
2017-01-05 20:02     ` Chris Packham
2017-01-05 20:02     ` Chris Packham
2017-01-06  4:14 ` Chris Packham
2017-01-06  4:14   ` Chris Packham
2017-01-06  4:14   ` Chris Packham
2017-01-06  4:14   ` Chris Packham
2017-01-06  4:14   ` [PATCHv3 1/5] clk: mvebu: support for 98DX3236 SoC Chris Packham
2017-01-06  4:14     ` Chris Packham
2017-01-06  4:14     ` Chris Packham
2017-01-09 18:39     ` Rob Herring
2017-01-09 18:39       ` Rob Herring
2017-01-06  4:14   ` [PATCHv3 2/5] arm: mvebu: support for SMP on 98DX3336 SoC Chris Packham
2017-01-06  4:14     ` Chris Packham
2017-01-06  4:14     ` Chris Packham
2017-01-06  6:36     ` Stephen Boyd
2017-01-06  6:36       ` Stephen Boyd
2017-01-06  6:36       ` Stephen Boyd
2017-01-06  8:41       ` Chris Packham
2017-01-06  8:41         ` Chris Packham
2017-01-06  8:41         ` Chris Packham
2017-01-09 18:40     ` Rob Herring
2017-01-09 18:40       ` Rob Herring
2017-01-09 18:40       ` Rob Herring
2017-01-06  4:15   ` [PATCHv3 3/5] pinctrl: mvebu: pinctrl driver for 98DX3236 SoC Chris Packham
2017-01-06  4:15     ` Chris Packham
2017-01-06  4:15     ` Chris Packham
     [not found]     ` <20170106041517.9589-4-chris.packham-6g8wRflRTwXFdCa3tKVlE6U/zSkkHjvu@public.gmane.org>
2017-01-09 18:41       ` Rob Herring
2017-01-09 18:41         ` Rob Herring
2017-01-09 18:41         ` Rob Herring
2017-01-11 14:44     ` Linus Walleij
2017-01-11 14:44       ` Linus Walleij
2017-01-11 20:55       ` Sebastian Hesselbarth
2017-01-11 20:55         ` Sebastian Hesselbarth
2017-01-11 20:55         ` Sebastian Hesselbarth
2017-01-12  9:13         ` Chris Packham
2017-01-12  9:13           ` Chris Packham
2017-01-12  9:13           ` Chris Packham
2017-01-06  4:15   ` [PATCHv3 4/5] arm: mvebu: Add device tree for 98DX3236 SoCs Chris Packham
2017-01-06  4:15     ` Chris Packham
2017-01-06  4:15     ` Chris Packham
2017-01-09 18:44     ` Rob Herring
2017-01-09 18:44       ` Rob Herring
2017-01-26 15:09     ` Gregory CLEMENT
2017-01-26 15:09       ` Gregory CLEMENT
2017-01-26 15:09       ` Gregory CLEMENT
2017-01-26 20:07       ` Chris Packham
2017-01-26 20:07         ` Chris Packham
2017-01-26 20:07         ` Chris Packham
2017-01-26 20:24       ` Chris Packham
2017-01-26 20:24         ` Chris Packham
2017-01-26 22:52         ` Chris Packham
2017-01-26 22:52           ` Chris Packham
2017-01-26 22:52           ` Chris Packham
2017-01-06  4:15   ` [PATCHv3 5/5] arm: mvebu: Add device tree for db-dxbc2 and db-xc3-24g4xg boards Chris Packham
2017-01-06  4:15     ` Chris Packham
2017-01-06  4:15     ` Chris Packham
2017-01-26 15:12     ` Gregory CLEMENT
2017-01-26 15:12       ` Gregory CLEMENT
2017-01-26 15:12       ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170105135837.GC25333@leverpostej \
    --to=mark.rutland@arm.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.