* meta-browser duplicate patch
@ 2017-01-12 14:44 Trevor Woerner
2017-01-12 14:59 ` Alexander Kanavin
0 siblings, 1 reply; 3+ messages in thread
From: Trevor Woerner @ 2017-01-12 14:44 UTC (permalink / raw)
To: openembedded-devel
Does the do_patch logic now ignore the same patch being applied twice? I was
quite sure this was a problem in the past (and if it isn't, maybe it should
be?)
In commit fb4e542079958b6afde324a1e9bfdd695842aeeb
the patch recipes-browser/chromium/chromium/chromium/Do-not-depend-on-Linux-4.5.patch
and in commit c6fc9da7be64af7cd08c2bbb026e4c3ffc760687
the patch recipes-browser/chromium/chromium/chromium/unset-madv-free.patch
are exactly the same. Yet they're both happily applied without so much as a
warning, not even in temp/log.do_patch.
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: meta-browser duplicate patch
2017-01-12 14:44 meta-browser duplicate patch Trevor Woerner
@ 2017-01-12 14:59 ` Alexander Kanavin
2017-01-12 15:20 ` Trevor Woerner
0 siblings, 1 reply; 3+ messages in thread
From: Alexander Kanavin @ 2017-01-12 14:59 UTC (permalink / raw)
To: openembedded-devel
On 01/12/2017 04:44 PM, Trevor Woerner wrote:
> Does the do_patch logic now ignore the same patch being applied twice? I was
> quite sure this was a problem in the past (and if it isn't, maybe it should
> be?)
>
> In commit fb4e542079958b6afde324a1e9bfdd695842aeeb
> the patch recipes-browser/chromium/chromium/chromium/Do-not-depend-on-Linux-4.5.patch
>
> and in commit c6fc9da7be64af7cd08c2bbb026e4c3ffc760687
> the patch recipes-browser/chromium/chromium/chromium/unset-madv-free.patch
>
> are exactly the same. Yet they're both happily applied without so much as a
> warning, not even in temp/log.do_patch.
Can you inspect the resulting file? Are the changes being applied twice
in two *different* locations in the file?
We have a bug to fix this issue:
https://bugzilla.yoctoproject.org/show_bug.cgi?id=10450
Alex
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: meta-browser duplicate patch
2017-01-12 14:59 ` Alexander Kanavin
@ 2017-01-12 15:20 ` Trevor Woerner
0 siblings, 0 replies; 3+ messages in thread
From: Trevor Woerner @ 2017-01-12 15:20 UTC (permalink / raw)
To: openembedded-devel
On Thu 2017-01-12 @ 04:59:20 PM, Alexander Kanavin wrote:
> On 01/12/2017 04:44 PM, Trevor Woerner wrote:
> > Does the do_patch logic now ignore the same patch being applied twice? I was
> > quite sure this was a problem in the past (and if it isn't, maybe it should
> > be?)
> >
> > In commit fb4e542079958b6afde324a1e9bfdd695842aeeb
> > the patch recipes-browser/chromium/chromium/chromium/Do-not-depend-on-Linux-4.5.patch
> >
> > and in commit c6fc9da7be64af7cd08c2bbb026e4c3ffc760687
> > the patch recipes-browser/chromium/chromium/chromium/unset-madv-free.patch
> >
> > are exactly the same. Yet they're both happily applied without so much as a
> > warning, not even in temp/log.do_patch.
>
> Can you inspect the resulting file? Are the changes being applied twice in
> two *different* locations in the file?
Ah yes, there it is, applied twice:
44 #if OS(LINUX) && defined(MADV_FREE)
45 // Added in Linux 4.5, but it breaks the sandbox.
46 #undef MADV_FREE
47 #endif
48
49 #if OS(LINUX) && defined(MADV_FREE)
50 // Added in Linux 4.5, but we don't want to depend on 4.5 at runtime
51 #undef MADV_FREE
52 #endif
> We have a bug to fix this issue:
> https://bugzilla.yoctoproject.org/show_bug.cgi?id=10450
Great, thanks :-)
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-12 15:20 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-12 14:44 meta-browser duplicate patch Trevor Woerner
2017-01-12 14:59 ` Alexander Kanavin
2017-01-12 15:20 ` Trevor Woerner
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.