All of lore.kernel.org
 help / color / mirror / Atom feed
From: Andrew Lunn <andrew@lunn.ch>
To: Bjorn Helgaas <helgaas@kernel.org>
Cc: "Uwe Kleine-König" <uwe@kleine-koenig.org>,
	"Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
	linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
	"Russell King" <rmk+kernel@arm.linux.org.uk>
Subject: Re: CONFIG_PCIEASPM breaks PCIe on Marvell Armada 385 machine
Date: Thu, 12 Jan 2017 16:24:20 +0100	[thread overview]
Message-ID: <20170112152420.GK13033@lunn.ch> (raw)
In-Reply-To: <20170112150310.GA5746@bhelgaas-glaptop.roam.corp.google.com>

>   pci_bus 0000:00: root bus resource [mem 0xe0000000-0xe7ffffff]
>   pci 0000:02:00.0: reg 0x10: [mem 0xe8000000-0xe81fffff 64bit]
>   pci 0000:02:00.0: reg 0x30: [mem 0xe8200000-0xe820ffff pref]
>   pci 0000:02:00.0: of_irq_parse_pci() failed with rc=134
>   pci 0000:02:00.0: BAR 0: assigned [mem 0xe0000000-0xe01fffff 64bit]
>   pci 0000:02:00.0: BAR 0: error updating (0xe0000004 != 0xffffffff)
>   pci 0000:02:00.0: BAR 0: error updating (high 0x000000 != 0xffffffff)
> 
> 3) No idea what the of_irq_parse_pci() issue is.

134 is 0x86.

Could it be:

#define PCIBIOS_DEVICE_NOT_FOUND        0x86

pci-mvebu.c will return this in a few places, mvebu_pcie_wr_conf(),
mvebu_pcie_rd_conf().

Could this be

rc = pci_read_config_byte(pdev, PCI_INTERRUPT_PIN, &pin);

It looks like pci_read_config_byte() is expected to return a real
errno value, and maybe it is returning PCIBIOS_DEVICE_NOT_FOUND?

      Andrew

WARNING: multiple messages have this Message-ID (diff)
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: CONFIG_PCIEASPM breaks PCIe on Marvell Armada 385 machine
Date: Thu, 12 Jan 2017 16:24:20 +0100	[thread overview]
Message-ID: <20170112152420.GK13033@lunn.ch> (raw)
In-Reply-To: <20170112150310.GA5746@bhelgaas-glaptop.roam.corp.google.com>

>   pci_bus 0000:00: root bus resource [mem 0xe0000000-0xe7ffffff]
>   pci 0000:02:00.0: reg 0x10: [mem 0xe8000000-0xe81fffff 64bit]
>   pci 0000:02:00.0: reg 0x30: [mem 0xe8200000-0xe820ffff pref]
>   pci 0000:02:00.0: of_irq_parse_pci() failed with rc=134
>   pci 0000:02:00.0: BAR 0: assigned [mem 0xe0000000-0xe01fffff 64bit]
>   pci 0000:02:00.0: BAR 0: error updating (0xe0000004 != 0xffffffff)
>   pci 0000:02:00.0: BAR 0: error updating (high 0x000000 != 0xffffffff)
> 
> 3) No idea what the of_irq_parse_pci() issue is.

134 is 0x86.

Could it be:

#define PCIBIOS_DEVICE_NOT_FOUND        0x86

pci-mvebu.c will return this in a few places, mvebu_pcie_wr_conf(),
mvebu_pcie_rd_conf().

Could this be

rc = pci_read_config_byte(pdev, PCI_INTERRUPT_PIN, &pin);

It looks like pci_read_config_byte() is expected to return a real
errno value, and maybe it is returning PCIBIOS_DEVICE_NOT_FOUND?

      Andrew

  reply	other threads:[~2017-01-12 15:24 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-11 19:49 CONFIG_PCIEASPM breaks PCIe on Marvell Armada 385 machine Uwe Kleine-König
2017-01-11 19:49 ` Uwe Kleine-König
2017-01-11 22:02 ` Bjorn Helgaas
2017-01-11 22:02   ` Bjorn Helgaas
2017-01-12 13:18   ` Uwe Kleine-König
2017-01-12 13:18     ` Uwe Kleine-König
2017-01-12 15:03     ` Bjorn Helgaas
2017-01-12 15:03       ` Bjorn Helgaas
2017-01-12 15:24       ` Andrew Lunn [this message]
2017-01-12 15:24         ` Andrew Lunn
2017-01-17 15:14 ` Bjorn Helgaas
2017-01-17 15:14   ` Bjorn Helgaas
2017-01-17 15:25   ` Russell King - ARM Linux
2017-01-17 15:25     ` Russell King - ARM Linux
2017-01-17 17:46     ` Bjorn Helgaas
2017-01-17 17:46       ` Bjorn Helgaas
2017-01-17 17:51       ` Russell King - ARM Linux
2017-01-17 17:51         ` Russell King - ARM Linux
2017-01-17 17:57         ` Russell King - ARM Linux
2017-01-17 17:57           ` Russell King - ARM Linux
2017-01-17 18:14           ` Bjorn Helgaas
2017-01-17 18:14             ` Bjorn Helgaas
2017-01-17 19:34             ` Russell King - ARM Linux
2017-01-17 19:34               ` Russell King - ARM Linux
2017-01-17 21:02               ` Russell King - ARM Linux
2017-01-17 21:02                 ` Russell King - ARM Linux
2017-01-17 22:22                 ` Bjorn Helgaas
2017-01-17 22:22                   ` Bjorn Helgaas
2017-01-17 23:37                   ` David Daney
2017-01-17 23:37                     ` David Daney
2017-01-18 14:22                     ` Bjorn Helgaas
2017-01-18 14:22                       ` Bjorn Helgaas
2017-01-18 17:36                       ` David Daney
2017-01-18 17:36                         ` David Daney
2017-01-18 17:55                         ` Russell King - ARM Linux
2017-01-18 17:55                           ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170112152420.GK13033@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=helgaas@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=rmk+kernel@arm.linux.org.uk \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=uwe@kleine-koenig.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.