All of lore.kernel.org
 help / color / mirror / Atom feed
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: David Daney <ddaney@caviumnetworks.com>
Cc: "Bjorn Helgaas" <helgaas@kernel.org>,
	"Thomas Petazzoni" <thomas.petazzoni@free-electrons.com>,
	"Andrew Lunn" <andrew@lunn.ch>,
	"Uwe Kleine-König" <uwe@kleine-koenig.org>,
	"David Daney" <david.daney@cavium.com>,
	linux-pci@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: CONFIG_PCIEASPM breaks PCIe on Marvell Armada 385 machine
Date: Wed, 18 Jan 2017 17:55:20 +0000	[thread overview]
Message-ID: <20170118175520.GN27312@n2100.armlinux.org.uk> (raw)
In-Reply-To: <1137f732-f31e-8162-af8f-6a7f577a9648@caviumnetworks.com>

On Wed, Jan 18, 2017 at 09:36:55AM -0800, David Daney wrote:
> On 01/18/2017 06:22 AM, Bjorn Helgaas wrote:
> The tricky thing here is assigning the blame for failure in link training.
> In the case in question we spent many months analysing the analog properties
> of the bus and examining/decoding  analog scope captures of the failures
> before credibly assigning blame to the other guy.  Usually what happens is
> the device vendor accurately claims that their device works flawlessly in
> conjunction with certain Intel root ports, so the problem must be fixed in
> the root port of the failing system.  If you have a black list, you may be
> disabling ASPM in systems where it can work without failures.

So what we need is not a table of just devices, but a combination of
devices... iow, "when root A and endpoint B are combined, retrains
need to be avoided."

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

WARNING: multiple messages have this Message-ID (diff)
From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: CONFIG_PCIEASPM breaks PCIe on Marvell Armada 385 machine
Date: Wed, 18 Jan 2017 17:55:20 +0000	[thread overview]
Message-ID: <20170118175520.GN27312@n2100.armlinux.org.uk> (raw)
In-Reply-To: <1137f732-f31e-8162-af8f-6a7f577a9648@caviumnetworks.com>

On Wed, Jan 18, 2017 at 09:36:55AM -0800, David Daney wrote:
> On 01/18/2017 06:22 AM, Bjorn Helgaas wrote:
> The tricky thing here is assigning the blame for failure in link training.
> In the case in question we spent many months analysing the analog properties
> of the bus and examining/decoding  analog scope captures of the failures
> before credibly assigning blame to the other guy.  Usually what happens is
> the device vendor accurately claims that their device works flawlessly in
> conjunction with certain Intel root ports, so the problem must be fixed in
> the root port of the failing system.  If you have a black list, you may be
> disabling ASPM in systems where it can work without failures.

So what we need is not a table of just devices, but a combination of
devices... iow, "when root A and endpoint B are combined, retrains
need to be avoided."

-- 
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.

  reply	other threads:[~2017-01-18 17:55 UTC|newest]

Thread overview: 36+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-11 19:49 CONFIG_PCIEASPM breaks PCIe on Marvell Armada 385 machine Uwe Kleine-König
2017-01-11 19:49 ` Uwe Kleine-König
2017-01-11 22:02 ` Bjorn Helgaas
2017-01-11 22:02   ` Bjorn Helgaas
2017-01-12 13:18   ` Uwe Kleine-König
2017-01-12 13:18     ` Uwe Kleine-König
2017-01-12 15:03     ` Bjorn Helgaas
2017-01-12 15:03       ` Bjorn Helgaas
2017-01-12 15:24       ` Andrew Lunn
2017-01-12 15:24         ` Andrew Lunn
2017-01-17 15:14 ` Bjorn Helgaas
2017-01-17 15:14   ` Bjorn Helgaas
2017-01-17 15:25   ` Russell King - ARM Linux
2017-01-17 15:25     ` Russell King - ARM Linux
2017-01-17 17:46     ` Bjorn Helgaas
2017-01-17 17:46       ` Bjorn Helgaas
2017-01-17 17:51       ` Russell King - ARM Linux
2017-01-17 17:51         ` Russell King - ARM Linux
2017-01-17 17:57         ` Russell King - ARM Linux
2017-01-17 17:57           ` Russell King - ARM Linux
2017-01-17 18:14           ` Bjorn Helgaas
2017-01-17 18:14             ` Bjorn Helgaas
2017-01-17 19:34             ` Russell King - ARM Linux
2017-01-17 19:34               ` Russell King - ARM Linux
2017-01-17 21:02               ` Russell King - ARM Linux
2017-01-17 21:02                 ` Russell King - ARM Linux
2017-01-17 22:22                 ` Bjorn Helgaas
2017-01-17 22:22                   ` Bjorn Helgaas
2017-01-17 23:37                   ` David Daney
2017-01-17 23:37                     ` David Daney
2017-01-18 14:22                     ` Bjorn Helgaas
2017-01-18 14:22                       ` Bjorn Helgaas
2017-01-18 17:36                       ` David Daney
2017-01-18 17:36                         ` David Daney
2017-01-18 17:55                         ` Russell King - ARM Linux [this message]
2017-01-18 17:55                           ` Russell King - ARM Linux

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170118175520.GN27312@n2100.armlinux.org.uk \
    --to=linux@armlinux.org.uk \
    --cc=andrew@lunn.ch \
    --cc=david.daney@cavium.com \
    --cc=ddaney@caviumnetworks.com \
    --cc=helgaas@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=thomas.petazzoni@free-electrons.com \
    --cc=uwe@kleine-koenig.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.