From: Lee Jones <lee.jones@linaro.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
Olof Johansson <olof@lixom.net>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Stephen Barber <smbarber@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>
Subject: [rtc-linux] Re: [PATCH 1/4] mfd: cros_ec: Add helper for event notifier.
Date: Fri, 13 Jan 2017 13:22:38 +0000 [thread overview]
Message-ID: <20170113132238.GB6864@dell> (raw)
In-Reply-To: <20170111165221.17337-1-enric.balletbo@collabora.com>
On Wed, 11 Jan 2017, Enric Balletbo i Serra wrote:
> From: Gwendal Grignou <gwendal@chromium.org>
>=20
> Add cros_ec_get_event() entry point to retrieve event within functions
> called by the notifier.
>=20
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> drivers/platform/chrome/cros_ec_proto.c | 20 ++++++++++++++++++++
> include/linux/mfd/cros_ec.h | 10 ++++++++++
Acked-by: Lee Jones <lee.jones@linaro.org>
> 2 files changed, 30 insertions(+)
>=20
> diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/c=
hrome/cros_ec_proto.c
> index ed5dee7..7428c2b 100644
> --- a/drivers/platform/chrome/cros_ec_proto.c
> +++ b/drivers/platform/chrome/cros_ec_proto.c
> @@ -494,3 +494,23 @@ int cros_ec_get_next_event(struct cros_ec_device *ec=
_dev)
> return get_keyboard_state_event(ec_dev);
> }
> EXPORT_SYMBOL(cros_ec_get_next_event);
> +
> +u32 cros_ec_get_host_event(struct cros_ec_device *ec_dev)
> +{
> + u32 host_event;
> +
> + BUG_ON(!ec_dev->mkbp_event_supported);
> +
> + if (ec_dev->event_data.event_type !=3D EC_MKBP_EVENT_HOST_EVENT)
> + return 0;
> +
> + if (ec_dev->event_size !=3D sizeof(host_event)) {
> + dev_warn(ec_dev->dev, "Invalid host event size\n");
> + return 0;
> + }
> +
> + host_event =3D get_unaligned_le32(&ec_dev->event_data.data.host_event);
> +
> + return host_event;
> +}
> +EXPORT_SYMBOL(cros_ec_get_host_event);
> diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h
> index b3d04de..be2c4eb 100644
> --- a/include/linux/mfd/cros_ec.h
> +++ b/include/linux/mfd/cros_ec.h
> @@ -299,6 +299,16 @@ int cros_ec_query_all(struct cros_ec_device *ec_dev)=
;
> */
> int cros_ec_get_next_event(struct cros_ec_device *ec_dev);
> =20
> +/**
> + * cros_ec_get_host_event - Return a mask of event set by the EC.
> + *
> + * When MKBP is supported, when the EC raises an interrupt,
> + * We collect the events raised and call the functions in the ec notifie=
r.
> + *
> + * This function is a helper to know which events are raised.
> + */
> +u32 cros_ec_get_host_event(struct cros_ec_device *ec_dev);
> +
> /* sysfs stuff */
> extern struct attribute_group cros_ec_attr_group;
> extern struct attribute_group cros_ec_lightbar_attr_group;
--=20
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org =E2=94=82 Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--=20
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---=20
You received this message because you are subscribed to the Google Groups "=
rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
Olof Johansson <olof@lixom.net>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Stephen Barber <smbarber@chromium.org>,
Gwendal Grignou <gwendal@chromium.org>
Subject: Re: [PATCH 1/4] mfd: cros_ec: Add helper for event notifier.
Date: Fri, 13 Jan 2017 13:22:38 +0000 [thread overview]
Message-ID: <20170113132238.GB6864@dell> (raw)
In-Reply-To: <20170111165221.17337-1-enric.balletbo@collabora.com>
On Wed, 11 Jan 2017, Enric Balletbo i Serra wrote:
> From: Gwendal Grignou <gwendal@chromium.org>
>
> Add cros_ec_get_event() entry point to retrieve event within functions
> called by the notifier.
>
> Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> drivers/platform/chrome/cros_ec_proto.c | 20 ++++++++++++++++++++
> include/linux/mfd/cros_ec.h | 10 ++++++++++
Acked-by: Lee Jones <lee.jones@linaro.org>
> 2 files changed, 30 insertions(+)
>
> diff --git a/drivers/platform/chrome/cros_ec_proto.c b/drivers/platform/chrome/cros_ec_proto.c
> index ed5dee7..7428c2b 100644
> --- a/drivers/platform/chrome/cros_ec_proto.c
> +++ b/drivers/platform/chrome/cros_ec_proto.c
> @@ -494,3 +494,23 @@ int cros_ec_get_next_event(struct cros_ec_device *ec_dev)
> return get_keyboard_state_event(ec_dev);
> }
> EXPORT_SYMBOL(cros_ec_get_next_event);
> +
> +u32 cros_ec_get_host_event(struct cros_ec_device *ec_dev)
> +{
> + u32 host_event;
> +
> + BUG_ON(!ec_dev->mkbp_event_supported);
> +
> + if (ec_dev->event_data.event_type != EC_MKBP_EVENT_HOST_EVENT)
> + return 0;
> +
> + if (ec_dev->event_size != sizeof(host_event)) {
> + dev_warn(ec_dev->dev, "Invalid host event size\n");
> + return 0;
> + }
> +
> + host_event = get_unaligned_le32(&ec_dev->event_data.data.host_event);
> +
> + return host_event;
> +}
> +EXPORT_SYMBOL(cros_ec_get_host_event);
> diff --git a/include/linux/mfd/cros_ec.h b/include/linux/mfd/cros_ec.h
> index b3d04de..be2c4eb 100644
> --- a/include/linux/mfd/cros_ec.h
> +++ b/include/linux/mfd/cros_ec.h
> @@ -299,6 +299,16 @@ int cros_ec_query_all(struct cros_ec_device *ec_dev);
> */
> int cros_ec_get_next_event(struct cros_ec_device *ec_dev);
>
> +/**
> + * cros_ec_get_host_event - Return a mask of event set by the EC.
> + *
> + * When MKBP is supported, when the EC raises an interrupt,
> + * We collect the events raised and call the functions in the ec notifier.
> + *
> + * This function is a helper to know which events are raised.
> + */
> +u32 cros_ec_get_host_event(struct cros_ec_device *ec_dev);
> +
> /* sysfs stuff */
> extern struct attribute_group cros_ec_attr_group;
> extern struct attribute_group cros_ec_lightbar_attr_group;
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-01-13 13:18 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 16:52 [rtc-linux] [PATCH 1/4] mfd: cros_ec: Add helper for event notifier Enric Balletbo i Serra
2017-01-11 16:52 ` Enric Balletbo i Serra
2017-01-11 16:52 ` [rtc-linux] [PATCH 2/4] mfd: cros_ec: Introduce RTC commands and events definitions Enric Balletbo i Serra
2017-01-11 16:52 ` Enric Balletbo i Serra
2017-01-13 13:23 ` [rtc-linux] " Lee Jones
2017-01-13 13:23 ` Lee Jones
2017-01-11 16:52 ` [rtc-linux] [PATCH 3/4] rtc: cros-ec: add cros-ec-rtc driver Enric Balletbo i Serra
2017-01-11 16:52 ` Enric Balletbo i Serra
2017-01-18 2:00 ` [rtc-linux] " Alexandre Belloni
2017-01-18 2:00 ` Alexandre Belloni
2017-01-11 16:52 ` [rtc-linux] [PATCH 4/4] mfd: cros_ec: add RTC as mfd subdevice Enric Balletbo i Serra
2017-01-11 16:52 ` Enric Balletbo i Serra
2017-01-18 2:01 ` [rtc-linux] " Alexandre Belloni
2017-01-18 2:01 ` Alexandre Belloni
2017-01-18 9:13 ` [rtc-linux] " Lee Jones
2017-01-18 9:13 ` Lee Jones
2017-01-13 13:22 ` Lee Jones [this message]
2017-01-13 13:22 ` [PATCH 1/4] mfd: cros_ec: Add helper for event notifier Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170113132238.GB6864@dell \
--to=lee.jones@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=enric.balletbo@collabora.com \
--cc=gwendal@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rtc-linux@googlegroups.com \
--cc=smbarber@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.