From: Lee Jones <lee.jones@linaro.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
Olof Johansson <olof@lixom.net>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Stephen Barber <smbarber@chromium.org>
Subject: [rtc-linux] Re: [PATCH 2/4] mfd: cros_ec: Introduce RTC commands and events definitions.
Date: Fri, 13 Jan 2017 13:23:15 +0000 [thread overview]
Message-ID: <20170113132315.GC6864@dell> (raw)
In-Reply-To: <20170111165221.17337-2-enric.balletbo@collabora.com>
On Wed, 11 Jan 2017, Enric Balletbo i Serra wrote:
> From: Stephen Barber <smbarber@chromium.org>
>=20
> The EC can function as a simple RT, this patch adds the RTC related
> definitions needed by the rtc-cros-ec driver.
>=20
> Signed-off-by: Stephen Barber <smbarber@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> include/linux/mfd/cros_ec_commands.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/include/linux/mfd/cros_ec_commands.h b/include/linux/mfd/cro=
s_ec_commands.h
> index 80d401d..73f7a62 100644
> --- a/include/linux/mfd/cros_ec_commands.h
> +++ b/include/linux/mfd/cros_ec_commands.h
> @@ -286,6 +286,9 @@ enum host_event_code {
> /* Hang detect logic detected a hang and warm rebooted the AP */
> EC_HOST_EVENT_HANG_REBOOT =3D 21,
> =20
> + /* EC RTC event occurred */
> + EC_HOST_EVENT_RTC =3D 26,
> +
> /*
> * The high bit of the event mask is not used as a host event code. If
> * it reads back as set, then the entire event mask should be
> @@ -790,6 +793,8 @@ enum ec_feature_code {
> EC_FEATURE_USB_MUX =3D 23,
> /* Motion Sensor code has an internal software FIFO */
> EC_FEATURE_MOTION_SENSE_FIFO =3D 24,
> + /* EC has RTC feature that can be controlled by host commands */
> + EC_FEATURE_RTC =3D 27,
> };
> =20
> #define EC_FEATURE_MASK_0(event_code) (1UL << (event_code % 32))
> @@ -1682,6 +1687,9 @@ struct ec_response_rtc {
> #define EC_CMD_RTC_SET_VALUE 0x46
> #define EC_CMD_RTC_SET_ALARM 0x47
> =20
> +/* Pass as param to SET_ALARM to clear the current alarm */
> +#define EC_RTC_ALARM_CLEAR 0
> +
> /***********************************************************************=
******/
> /* Port80 log access */
> =20
--=20
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org =E2=94=82 Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
--=20
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---=20
You received this message because you are subscribed to the Google Groups "=
rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an e=
mail to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Enric Balletbo i Serra <enric.balletbo@collabora.com>
Cc: linux-kernel@vger.kernel.org, rtc-linux@googlegroups.com,
Olof Johansson <olof@lixom.net>,
Alessandro Zummo <a.zummo@towertech.it>,
Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Stephen Barber <smbarber@chromium.org>
Subject: Re: [PATCH 2/4] mfd: cros_ec: Introduce RTC commands and events definitions.
Date: Fri, 13 Jan 2017 13:23:15 +0000 [thread overview]
Message-ID: <20170113132315.GC6864@dell> (raw)
In-Reply-To: <20170111165221.17337-2-enric.balletbo@collabora.com>
On Wed, 11 Jan 2017, Enric Balletbo i Serra wrote:
> From: Stephen Barber <smbarber@chromium.org>
>
> The EC can function as a simple RT, this patch adds the RTC related
> definitions needed by the rtc-cros-ec driver.
>
> Signed-off-by: Stephen Barber <smbarber@chromium.org>
> Signed-off-by: Enric Balletbo i Serra <enric.balletbo@collabora.com>
> ---
> include/linux/mfd/cros_ec_commands.h | 8 ++++++++
> 1 file changed, 8 insertions(+)
Acked-by: Lee Jones <lee.jones@linaro.org>
> diff --git a/include/linux/mfd/cros_ec_commands.h b/include/linux/mfd/cros_ec_commands.h
> index 80d401d..73f7a62 100644
> --- a/include/linux/mfd/cros_ec_commands.h
> +++ b/include/linux/mfd/cros_ec_commands.h
> @@ -286,6 +286,9 @@ enum host_event_code {
> /* Hang detect logic detected a hang and warm rebooted the AP */
> EC_HOST_EVENT_HANG_REBOOT = 21,
>
> + /* EC RTC event occurred */
> + EC_HOST_EVENT_RTC = 26,
> +
> /*
> * The high bit of the event mask is not used as a host event code. If
> * it reads back as set, then the entire event mask should be
> @@ -790,6 +793,8 @@ enum ec_feature_code {
> EC_FEATURE_USB_MUX = 23,
> /* Motion Sensor code has an internal software FIFO */
> EC_FEATURE_MOTION_SENSE_FIFO = 24,
> + /* EC has RTC feature that can be controlled by host commands */
> + EC_FEATURE_RTC = 27,
> };
>
> #define EC_FEATURE_MASK_0(event_code) (1UL << (event_code % 32))
> @@ -1682,6 +1687,9 @@ struct ec_response_rtc {
> #define EC_CMD_RTC_SET_VALUE 0x46
> #define EC_CMD_RTC_SET_ALARM 0x47
>
> +/* Pass as param to SET_ALARM to clear the current alarm */
> +#define EC_RTC_ALARM_CLEAR 0
> +
> /*****************************************************************************/
> /* Port80 log access */
>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2017-01-13 13:19 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-11 16:52 [rtc-linux] [PATCH 1/4] mfd: cros_ec: Add helper for event notifier Enric Balletbo i Serra
2017-01-11 16:52 ` Enric Balletbo i Serra
2017-01-11 16:52 ` [rtc-linux] [PATCH 2/4] mfd: cros_ec: Introduce RTC commands and events definitions Enric Balletbo i Serra
2017-01-11 16:52 ` Enric Balletbo i Serra
2017-01-13 13:23 ` Lee Jones [this message]
2017-01-13 13:23 ` Lee Jones
2017-01-11 16:52 ` [rtc-linux] [PATCH 3/4] rtc: cros-ec: add cros-ec-rtc driver Enric Balletbo i Serra
2017-01-11 16:52 ` Enric Balletbo i Serra
2017-01-18 2:00 ` [rtc-linux] " Alexandre Belloni
2017-01-18 2:00 ` Alexandre Belloni
2017-01-11 16:52 ` [rtc-linux] [PATCH 4/4] mfd: cros_ec: add RTC as mfd subdevice Enric Balletbo i Serra
2017-01-11 16:52 ` Enric Balletbo i Serra
2017-01-18 2:01 ` [rtc-linux] " Alexandre Belloni
2017-01-18 2:01 ` Alexandre Belloni
2017-01-18 9:13 ` [rtc-linux] " Lee Jones
2017-01-18 9:13 ` Lee Jones
2017-01-13 13:22 ` [rtc-linux] Re: [PATCH 1/4] mfd: cros_ec: Add helper for event notifier Lee Jones
2017-01-13 13:22 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170113132315.GC6864@dell \
--to=lee.jones@linaro.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=enric.balletbo@collabora.com \
--cc=linux-kernel@vger.kernel.org \
--cc=olof@lixom.net \
--cc=rtc-linux@googlegroups.com \
--cc=smbarber@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.