From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Amelie Delaunay <amelie.delaunay@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org
Subject: [rtc-linux] Re: [PATCH 3/3] rtc: stm32: use 32-bit cast for BIT() macro
Date: Fri, 13 Jan 2017 15:52:29 +0000 [thread overview]
Message-ID: <20170113155229.GS14217@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20170113153311.2611510-3-arnd@arndb.de>
On Fri, Jan 13, 2017 at 04:32:53PM +0100, Arnd Bergmann wrote:
> -#define PWR_CR_DBP BIT(8)
> +#define PWR_CR_DBP (u32)BIT(8)
Shouldn't that have parens around it as it's no longer a simple expression.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
--
You received this message because you are subscribed to "rtc-linux".
Membership options at http://groups.google.com/group/rtc-linux .
Please read http://groups.google.com/group/rtc-linux/web/checklist
before submitting a driver.
---
You received this message because you are subscribed to the Google Groups "rtc-linux" group.
To unsubscribe from this group and stop receiving emails from it, send an email to rtc-linux+unsubscribe@googlegroups.com.
For more options, visit https://groups.google.com/d/optout.
WARNING: multiple messages have this Message-ID (diff)
From: linux@armlinux.org.uk (Russell King - ARM Linux)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 3/3] rtc: stm32: use 32-bit cast for BIT() macro
Date: Fri, 13 Jan 2017 15:52:29 +0000 [thread overview]
Message-ID: <20170113155229.GS14217@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20170113153311.2611510-3-arnd@arndb.de>
On Fri, Jan 13, 2017 at 04:32:53PM +0100, Arnd Bergmann wrote:
> -#define PWR_CR_DBP BIT(8)
> +#define PWR_CR_DBP (u32)BIT(8)
Shouldn't that have parens around it as it's no longer a simple expression.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
WARNING: multiple messages have this Message-ID (diff)
From: Russell King - ARM Linux <linux@armlinux.org.uk>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Alexandre Belloni <alexandre.belloni@free-electrons.com>,
Alessandro Zummo <a.zummo@towertech.it>,
Amelie Delaunay <amelie.delaunay@st.com>,
Alexandre Torgue <alexandre.torgue@st.com>,
Mathieu Poirier <mathieu.poirier@linaro.org>,
linux-kernel@vger.kernel.org, Mark Brown <broonie@kernel.org>,
Maxime Coquelin <mcoquelin.stm32@gmail.com>,
rtc-linux@googlegroups.com, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 3/3] rtc: stm32: use 32-bit cast for BIT() macro
Date: Fri, 13 Jan 2017 15:52:29 +0000 [thread overview]
Message-ID: <20170113155229.GS14217@n2100.armlinux.org.uk> (raw)
In-Reply-To: <20170113153311.2611510-3-arnd@arndb.de>
On Fri, Jan 13, 2017 at 04:32:53PM +0100, Arnd Bergmann wrote:
> -#define PWR_CR_DBP BIT(8)
> +#define PWR_CR_DBP (u32)BIT(8)
Shouldn't that have parens around it as it's no longer a simple expression.
--
RMK's Patch system: http://www.armlinux.org.uk/developer/patches/
FTTC broadband for 0.8mile line: currently at 9.6Mbps down 400kbps up
according to speedtest.net.
next prev parent reply other threads:[~2017-01-13 15:52 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-13 15:32 [rtc-linux] [PATCH 1/3] rtc: stm32: remove __exit annotation on remove callback Arnd Bergmann
2017-01-13 15:32 ` Arnd Bergmann
2017-01-13 15:32 ` Arnd Bergmann
2017-01-13 15:32 ` [rtc-linux] [PATCH 2/3] rtc: stm32: fix building without CONFIG_OF Arnd Bergmann
2017-01-13 15:32 ` Arnd Bergmann
2017-01-13 15:32 ` Arnd Bergmann
2017-01-13 16:55 ` [rtc-linux] " Alexandre Belloni
2017-01-13 16:55 ` Alexandre Belloni
2017-01-13 16:55 ` Alexandre Belloni
2017-01-13 15:32 ` [rtc-linux] [PATCH 3/3] rtc: stm32: use 32-bit cast for BIT() macro Arnd Bergmann
2017-01-13 15:32 ` Arnd Bergmann
2017-01-13 15:32 ` Arnd Bergmann
2017-01-13 15:52 ` Russell King - ARM Linux [this message]
2017-01-13 15:52 ` Russell King - ARM Linux
2017-01-13 15:52 ` Russell King - ARM Linux
2017-01-13 15:55 ` [rtc-linux] " Alexandre Belloni
2017-01-13 15:55 ` Alexandre Belloni
2017-01-13 15:55 ` Alexandre Belloni
2017-01-13 15:56 ` [rtc-linux] " Amelie DELAUNAY
2017-01-13 15:56 ` Amelie DELAUNAY
2017-01-13 15:56 ` Amelie DELAUNAY
2017-01-13 16:48 ` [rtc-linux] " Arnd Bergmann
2017-01-13 16:48 ` Arnd Bergmann
2017-01-13 16:48 ` Arnd Bergmann
2017-01-13 17:40 ` [rtc-linux] " adelaunay.stm32
2017-01-13 16:54 ` [rtc-linux] Re: [PATCH 1/3] rtc: stm32: remove __exit annotation on remove callback Alexandre Belloni
2017-01-13 16:54 ` Alexandre Belloni
2017-01-13 16:54 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170113155229.GS14217@n2100.armlinux.org.uk \
--to=linux@armlinux.org.uk \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@free-electrons.com \
--cc=alexandre.torgue@st.com \
--cc=amelie.delaunay@st.com \
--cc=arnd@arndb.de \
--cc=broonie@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mathieu.poirier@linaro.org \
--cc=mcoquelin.stm32@gmail.com \
--cc=rtc-linux@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.