From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>, Vlastimil Babka <vbabka@suse.cz>,
Hillf Danton <hillf.zj@alibaba-inc.com>,
brouer@redhat.com, Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH 1/4] mm, page_alloc: Split buffered_rmqueue
Date: Tue, 17 Jan 2017 19:07:32 +0100 [thread overview]
Message-ID: <20170117190732.0fc733ec@redhat.com> (raw)
In-Reply-To: <20170117092954.15413-2-mgorman@techsingularity.net>
On Tue, 17 Jan 2017 09:29:51 +0000 Mel Gorman <mgorman@techsingularity.net> wrote:
> +/* Lock and remove page from the per-cpu list */
> +static struct page *rmqueue_pcplist(struct zone *preferred_zone,
> + struct zone *zone, unsigned int order,
> + gfp_t gfp_flags, int migratetype)
> +{
> + struct per_cpu_pages *pcp;
> + struct list_head *list;
> + bool cold = ((gfp_flags & __GFP_COLD) != 0);
> + struct page *page;
> + unsigned long flags;
> +
> + local_irq_save(flags);
> + pcp = &this_cpu_ptr(zone->pageset)->pcp;
> + list = &pcp->lists[migratetype];
> + page = __rmqueue_pcplist(zone, migratetype, cold, pcp, list);
> + if (page) {
> + __count_zid_vm_events(PGALLOC, page_zonenum(page), 1 << order);
> + zone_statistics(preferred_zone, zone, gfp_flags);
Word-of-warning: The zone_statistics() call changed number of
parameters in commit 41b6167e8f74 ("mm: get rid of __GFP_OTHER_NODE").
(Not sure what tree you are based on)
> + }
> + local_irq_restore(flags);
> + return page;
> +}
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Jesper Dangaard Brouer <brouer@redhat.com>
To: Mel Gorman <mgorman@techsingularity.net>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>, Vlastimil Babka <vbabka@suse.cz>,
Hillf Danton <hillf.zj@alibaba-inc.com>,
brouer@redhat.com, Michal Hocko <mhocko@suse.com>
Subject: Re: [PATCH 1/4] mm, page_alloc: Split buffered_rmqueue
Date: Tue, 17 Jan 2017 19:07:32 +0100 [thread overview]
Message-ID: <20170117190732.0fc733ec@redhat.com> (raw)
In-Reply-To: <20170117092954.15413-2-mgorman@techsingularity.net>
On Tue, 17 Jan 2017 09:29:51 +0000 Mel Gorman <mgorman@techsingularity.net> wrote:
> +/* Lock and remove page from the per-cpu list */
> +static struct page *rmqueue_pcplist(struct zone *preferred_zone,
> + struct zone *zone, unsigned int order,
> + gfp_t gfp_flags, int migratetype)
> +{
> + struct per_cpu_pages *pcp;
> + struct list_head *list;
> + bool cold = ((gfp_flags & __GFP_COLD) != 0);
> + struct page *page;
> + unsigned long flags;
> +
> + local_irq_save(flags);
> + pcp = &this_cpu_ptr(zone->pageset)->pcp;
> + list = &pcp->lists[migratetype];
> + page = __rmqueue_pcplist(zone, migratetype, cold, pcp, list);
> + if (page) {
> + __count_zid_vm_events(PGALLOC, page_zonenum(page), 1 << order);
> + zone_statistics(preferred_zone, zone, gfp_flags);
Word-of-warning: The zone_statistics() call changed number of
parameters in commit 41b6167e8f74 ("mm: get rid of __GFP_OTHER_NODE").
(Not sure what tree you are based on)
> + }
> + local_irq_restore(flags);
> + return page;
> +}
--
Best regards,
Jesper Dangaard Brouer
MSc.CS, Principal Kernel Engineer at Red Hat
LinkedIn: http://www.linkedin.com/in/brouer
next prev parent reply other threads:[~2017-01-17 18:07 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 9:29 [PATCH 0/4] Use per-cpu allocator for !irq requests and prepare for a bulk allocator v4 Mel Gorman
2017-01-17 9:29 ` Mel Gorman
2017-01-17 9:29 ` [PATCH 1/4] mm, page_alloc: Split buffered_rmqueue Mel Gorman
2017-01-17 9:29 ` Mel Gorman
2017-01-17 18:07 ` Jesper Dangaard Brouer [this message]
2017-01-17 18:07 ` Jesper Dangaard Brouer
2017-01-17 18:17 ` Vlastimil Babka
2017-01-17 20:20 ` Mel Gorman
2017-01-17 20:20 ` Mel Gorman
2017-01-17 21:07 ` Mel Gorman
2017-01-17 21:07 ` Mel Gorman
2017-01-17 21:24 ` Vlastimil Babka
2017-01-17 21:24 ` Vlastimil Babka
2017-01-17 9:29 ` [PATCH 2/4] mm, page_alloc: Split alloc_pages_nodemask Mel Gorman
2017-01-17 9:29 ` Mel Gorman
2017-01-17 9:29 ` [PATCH 3/4] mm, page_alloc: Drain per-cpu pages from workqueue context Mel Gorman
2017-01-17 9:29 ` Mel Gorman
2017-01-20 14:26 ` Vlastimil Babka
2017-01-20 14:26 ` Vlastimil Babka
2017-01-20 15:26 ` Mel Gorman
2017-01-20 15:26 ` Mel Gorman
2017-01-23 16:29 ` Petr Mladek
2017-01-23 16:29 ` Petr Mladek
2017-01-23 16:50 ` Mel Gorman
2017-01-23 16:50 ` Mel Gorman
2017-01-23 17:03 ` Tejun Heo
2017-01-23 17:03 ` Tejun Heo
2017-01-23 20:04 ` Mel Gorman
2017-01-23 20:04 ` Mel Gorman
2017-01-23 20:55 ` Tejun Heo
2017-01-23 20:55 ` Tejun Heo
2017-01-23 23:04 ` Mel Gorman
2017-01-23 23:04 ` Mel Gorman
2017-01-24 16:07 ` Tejun Heo
2017-01-24 16:07 ` Tejun Heo
2017-01-24 23:54 ` Mel Gorman
2017-01-24 23:54 ` Mel Gorman
2017-01-25 2:02 ` Tejun Heo
2017-01-25 2:02 ` Tejun Heo
2017-01-25 8:30 ` Mel Gorman
2017-01-25 8:30 ` Mel Gorman
2017-01-24 11:08 ` Vlastimil Babka
2017-01-24 11:08 ` Vlastimil Babka
2017-01-17 9:29 ` [PATCH 4/4] mm, page_alloc: Only use per-cpu allocator for irq-safe requests Mel Gorman
2017-01-17 9:29 ` Mel Gorman
2017-01-20 15:02 ` Vlastimil Babka
2017-01-20 15:02 ` Vlastimil Babka
2017-01-23 11:17 ` Mel Gorman
2017-01-23 11:17 ` Mel Gorman
-- strict thread matches above, loose matches on Subject: below --
2017-01-23 15:39 [PATCH 0/4] Use per-cpu allocator for !irq requests and prepare for a bulk allocator v5 Mel Gorman
2017-01-23 15:39 ` [PATCH 1/4] mm, page_alloc: Split buffered_rmqueue Mel Gorman
2017-01-23 15:39 ` Mel Gorman
2017-01-24 10:23 ` Vlastimil Babka
2017-01-24 10:23 ` Vlastimil Babka
2017-01-09 16:35 [RFC PATCH 0/4] Fast noirq bulk page allocator v2r7 Mel Gorman
2017-01-09 16:35 ` [PATCH 1/4] mm, page_alloc: Split buffered_rmqueue Mel Gorman
2017-01-09 16:35 ` Mel Gorman
2017-01-11 12:31 ` Jesper Dangaard Brouer
2017-01-11 12:31 ` Jesper Dangaard Brouer
2017-01-12 3:09 ` Hillf Danton
2017-01-12 3:09 ` Hillf Danton
2017-01-04 11:10 [RFC PATCH 0/4] Fast noirq bulk page allocator Mel Gorman
2017-01-04 11:10 ` [PATCH 1/4] mm, page_alloc: Split buffered_rmqueue Mel Gorman
2017-01-04 11:10 ` Mel Gorman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170117190732.0fc733ec@redhat.com \
--to=brouer@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=hillf.zj@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mgorman@techsingularity.net \
--cc=mhocko@suse.com \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.