From: Mel Gorman <mgorman@techsingularity.net>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
Hillf Danton <hillf.zj@alibaba-inc.com>,
Jesper Dangaard Brouer <brouer@redhat.com>
Subject: Re: [PATCH 4/4] mm, page_alloc: Only use per-cpu allocator for irq-safe requests
Date: Mon, 23 Jan 2017 11:17:59 +0000 [thread overview]
Message-ID: <20170123111759.fjpox4d22rsknb4a@techsingularity.net> (raw)
In-Reply-To: <675145cb-e026-7ceb-ce96-446d3dd61fe0@suse.cz>
On Fri, Jan 20, 2017 at 04:02:56PM +0100, Vlastimil Babka wrote:
> On 01/17/2017 10:29 AM, Mel Gorman wrote:
>
> [...]
>
> > @@ -1244,10 +1243,8 @@ static void __free_pages_ok(struct page *page, unsigned int order)
> > return;
> >
> > migratetype = get_pfnblock_migratetype(page, pfn);
> > - local_irq_save(flags);
> > - __count_vm_events(PGFREE, 1 << order);
> > + count_vm_events(PGFREE, 1 << order);
>
> Maybe this could be avoided by moving the counting into free_one_page()?
> Diff suggestion at the end of e-mail.
>
Yes, that would work.
> > @@ -2472,16 +2470,20 @@ void free_hot_cold_page(struct page *page, bool cold)
> > {
> > struct zone *zone = page_zone(page);
> > struct per_cpu_pages *pcp;
> > - unsigned long flags;
> > unsigned long pfn = page_to_pfn(page);
> > int migratetype;
> >
> > if (!free_pcp_prepare(page))
> > return;
> >
> > + if (in_interrupt()) {
> > + __free_pages_ok(page, 0);
> > + return;
> > + }
>
> I think this should go *before* free_pcp_prepare() otherwise
> free_pages_prepare() gets done twice in interrupt.
>
You're right, thanks.
--
Mel Gorman
SUSE Labs
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Mel Gorman <mgorman@techsingularity.net>
To: Vlastimil Babka <vbabka@suse.cz>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Linux Kernel <linux-kernel@vger.kernel.org>,
Linux-MM <linux-mm@kvack.org>,
Hillf Danton <hillf.zj@alibaba-inc.com>,
Jesper Dangaard Brouer <brouer@redhat.com>
Subject: Re: [PATCH 4/4] mm, page_alloc: Only use per-cpu allocator for irq-safe requests
Date: Mon, 23 Jan 2017 11:17:59 +0000 [thread overview]
Message-ID: <20170123111759.fjpox4d22rsknb4a@techsingularity.net> (raw)
In-Reply-To: <675145cb-e026-7ceb-ce96-446d3dd61fe0@suse.cz>
On Fri, Jan 20, 2017 at 04:02:56PM +0100, Vlastimil Babka wrote:
> On 01/17/2017 10:29 AM, Mel Gorman wrote:
>
> [...]
>
> > @@ -1244,10 +1243,8 @@ static void __free_pages_ok(struct page *page, unsigned int order)
> > return;
> >
> > migratetype = get_pfnblock_migratetype(page, pfn);
> > - local_irq_save(flags);
> > - __count_vm_events(PGFREE, 1 << order);
> > + count_vm_events(PGFREE, 1 << order);
>
> Maybe this could be avoided by moving the counting into free_one_page()?
> Diff suggestion at the end of e-mail.
>
Yes, that would work.
> > @@ -2472,16 +2470,20 @@ void free_hot_cold_page(struct page *page, bool cold)
> > {
> > struct zone *zone = page_zone(page);
> > struct per_cpu_pages *pcp;
> > - unsigned long flags;
> > unsigned long pfn = page_to_pfn(page);
> > int migratetype;
> >
> > if (!free_pcp_prepare(page))
> > return;
> >
> > + if (in_interrupt()) {
> > + __free_pages_ok(page, 0);
> > + return;
> > + }
>
> I think this should go *before* free_pcp_prepare() otherwise
> free_pages_prepare() gets done twice in interrupt.
>
You're right, thanks.
--
Mel Gorman
SUSE Labs
next prev parent reply other threads:[~2017-01-23 11:18 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-17 9:29 [PATCH 0/4] Use per-cpu allocator for !irq requests and prepare for a bulk allocator v4 Mel Gorman
2017-01-17 9:29 ` Mel Gorman
2017-01-17 9:29 ` [PATCH 1/4] mm, page_alloc: Split buffered_rmqueue Mel Gorman
2017-01-17 9:29 ` Mel Gorman
2017-01-17 18:07 ` Jesper Dangaard Brouer
2017-01-17 18:07 ` Jesper Dangaard Brouer
2017-01-17 18:17 ` Vlastimil Babka
2017-01-17 20:20 ` Mel Gorman
2017-01-17 20:20 ` Mel Gorman
2017-01-17 21:07 ` Mel Gorman
2017-01-17 21:07 ` Mel Gorman
2017-01-17 21:24 ` Vlastimil Babka
2017-01-17 21:24 ` Vlastimil Babka
2017-01-17 9:29 ` [PATCH 2/4] mm, page_alloc: Split alloc_pages_nodemask Mel Gorman
2017-01-17 9:29 ` Mel Gorman
2017-01-17 9:29 ` [PATCH 3/4] mm, page_alloc: Drain per-cpu pages from workqueue context Mel Gorman
2017-01-17 9:29 ` Mel Gorman
2017-01-20 14:26 ` Vlastimil Babka
2017-01-20 14:26 ` Vlastimil Babka
2017-01-20 15:26 ` Mel Gorman
2017-01-20 15:26 ` Mel Gorman
2017-01-23 16:29 ` Petr Mladek
2017-01-23 16:29 ` Petr Mladek
2017-01-23 16:50 ` Mel Gorman
2017-01-23 16:50 ` Mel Gorman
2017-01-23 17:03 ` Tejun Heo
2017-01-23 17:03 ` Tejun Heo
2017-01-23 20:04 ` Mel Gorman
2017-01-23 20:04 ` Mel Gorman
2017-01-23 20:55 ` Tejun Heo
2017-01-23 20:55 ` Tejun Heo
2017-01-23 23:04 ` Mel Gorman
2017-01-23 23:04 ` Mel Gorman
2017-01-24 16:07 ` Tejun Heo
2017-01-24 16:07 ` Tejun Heo
2017-01-24 23:54 ` Mel Gorman
2017-01-24 23:54 ` Mel Gorman
2017-01-25 2:02 ` Tejun Heo
2017-01-25 2:02 ` Tejun Heo
2017-01-25 8:30 ` Mel Gorman
2017-01-25 8:30 ` Mel Gorman
2017-01-24 11:08 ` Vlastimil Babka
2017-01-24 11:08 ` Vlastimil Babka
2017-01-17 9:29 ` [PATCH 4/4] mm, page_alloc: Only use per-cpu allocator for irq-safe requests Mel Gorman
2017-01-17 9:29 ` Mel Gorman
2017-01-20 15:02 ` Vlastimil Babka
2017-01-20 15:02 ` Vlastimil Babka
2017-01-23 11:17 ` Mel Gorman [this message]
2017-01-23 11:17 ` Mel Gorman
-- strict thread matches above, loose matches on Subject: below --
2017-01-23 15:39 [PATCH 0/4] Use per-cpu allocator for !irq requests and prepare for a bulk allocator v5 Mel Gorman
2017-01-23 15:39 ` [PATCH 4/4] mm, page_alloc: Only use per-cpu allocator for irq-safe requests Mel Gorman
2017-01-23 15:39 ` Mel Gorman
2017-01-24 13:16 ` Vlastimil Babka
2017-01-24 13:16 ` Vlastimil Babka
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170123111759.fjpox4d22rsknb4a@techsingularity.net \
--to=mgorman@techsingularity.net \
--cc=akpm@linux-foundation.org \
--cc=brouer@redhat.com \
--cc=hillf.zj@alibaba-inc.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.