All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] kernel-fitimage: Let U-Boot select ramdisk load/entry address
@ 2017-01-19 16:58 Rick Altherr
  2017-01-19 17:37 ` Denys Dmytriyenko
  0 siblings, 1 reply; 6+ messages in thread
From: Rick Altherr @ 2017-01-19 16:58 UTC (permalink / raw)
  To: openembedded-core

If the ramdisk load and entry parameters are omitted in the FIT image
specification, U-Boot will determine if the ramdisk needs to be
relocated and will automatically allocate a location in RAM if so.

Signed-off-by: Rick Altherr <raltherr@google.com>
---
 meta/classes/kernel-fitimage.bbclass | 2 --
 1 file changed, 2 deletions(-)

diff --git a/meta/classes/kernel-fitimage.bbclass b/meta/classes/kernel-fitimage.bbclass
index 2934b3a31a..ee721d1fff 100644
--- a/meta/classes/kernel-fitimage.bbclass
+++ b/meta/classes/kernel-fitimage.bbclass
@@ -187,8 +187,6 @@ fitimage_emit_section_ramdisk() {
                         arch = "${UBOOT_ARCH}";
                         os = "linux";
                         compression = "none";
-                        load = <${UBOOT_RD_LOADADDRESS}>;
-                        entry = <${UBOOT_RD_ENTRYPOINT}>;
                         hash@1 {
                                 algo = "${ramdisk_csum}";
                         };
-- 
2.11.0.483.g087da7b7c-goog



^ permalink raw reply related	[flat|nested] 6+ messages in thread

* Re: [PATCH] kernel-fitimage: Let U-Boot select ramdisk load/entry address
  2017-01-19 16:58 [PATCH] kernel-fitimage: Let U-Boot select ramdisk load/entry address Rick Altherr
@ 2017-01-19 17:37 ` Denys Dmytriyenko
  2017-01-19 17:40   ` Burton, Ross
  0 siblings, 1 reply; 6+ messages in thread
From: Denys Dmytriyenko @ 2017-01-19 17:37 UTC (permalink / raw)
  To: Rick Altherr; +Cc: openembedded-core

On Thu, Jan 19, 2017 at 08:58:03AM -0800, Rick Altherr wrote:
> If the ramdisk load and entry parameters are omitted in the FIT image
> specification, U-Boot will determine if the ramdisk needs to be
> relocated and will automatically allocate a location in RAM if so.

Sometimes it's useful to load ramdisk in a specific location. Your patch 
unconditionally removes this support, which is not a desired change. I have 
a patch queued up to do it conditionally, which I'll try to submit shortly.

-- 
Denys


> Signed-off-by: Rick Altherr <raltherr@google.com>
> ---
>  meta/classes/kernel-fitimage.bbclass | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/meta/classes/kernel-fitimage.bbclass b/meta/classes/kernel-fitimage.bbclass
> index 2934b3a31a..ee721d1fff 100644
> --- a/meta/classes/kernel-fitimage.bbclass
> +++ b/meta/classes/kernel-fitimage.bbclass
> @@ -187,8 +187,6 @@ fitimage_emit_section_ramdisk() {
>                          arch = "${UBOOT_ARCH}";
>                          os = "linux";
>                          compression = "none";
> -                        load = <${UBOOT_RD_LOADADDRESS}>;
> -                        entry = <${UBOOT_RD_ENTRYPOINT}>;
>                          hash@1 {
>                                  algo = "${ramdisk_csum}";
>                          };
> -- 
> 2.11.0.483.g087da7b7c-goog
> 
> -- 
> _______________________________________________
> Openembedded-core mailing list
> Openembedded-core@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-core


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] kernel-fitimage: Let U-Boot select ramdisk load/entry address
  2017-01-19 17:37 ` Denys Dmytriyenko
@ 2017-01-19 17:40   ` Burton, Ross
  2017-01-19 17:41     ` Rick Altherr
  2017-01-19 17:45     ` Denys Dmytriyenko
  0 siblings, 2 replies; 6+ messages in thread
From: Burton, Ross @ 2017-01-19 17:40 UTC (permalink / raw)
  To: Denys Dmytriyenko; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 433 bytes --]

On 19 January 2017 at 17:37, Denys Dmytriyenko <denis@denix.org> wrote:

> Sometimes it's useful to load ramdisk in a specific location. Your patch
> unconditionally removes this support, which is not a desired change. I have
> a patch queued up to do it conditionally, which I'll try to submit shortly.
>

Would that be the same as Nathan's "kernel-fitimage.bbclass: Allow unset
load/entry addresses for ramdisks"?

Ross

[-- Attachment #2: Type: text/html, Size: 933 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] kernel-fitimage: Let U-Boot select ramdisk load/entry address
  2017-01-19 17:40   ` Burton, Ross
@ 2017-01-19 17:41     ` Rick Altherr
  2017-01-19 17:45     ` Denys Dmytriyenko
  1 sibling, 0 replies; 6+ messages in thread
From: Rick Altherr @ 2017-01-19 17:41 UTC (permalink / raw)
  To: Burton, Ross; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 727 bytes --]

Ross and I were discussing that Nathan's patches in
http://lists.openembedded.org/pipermail/openembedded-core/2017-January/131012.html
are equivalent and were introduced first.

On Thu, Jan 19, 2017 at 9:40 AM, Burton, Ross <ross.burton@intel.com> wrote:

>
> On 19 January 2017 at 17:37, Denys Dmytriyenko <denis@denix.org> wrote:
>
>> Sometimes it's useful to load ramdisk in a specific location. Your patch
>> unconditionally removes this support, which is not a desired change. I
>> have
>> a patch queued up to do it conditionally, which I'll try to submit
>> shortly.
>>
>
> Would that be the same as Nathan's "kernel-fitimage.bbclass: Allow unset
> load/entry addresses for ramdisks"?
>
> Ross
>
>

[-- Attachment #2: Type: text/html, Size: 1754 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] kernel-fitimage: Let U-Boot select ramdisk load/entry address
  2017-01-19 17:40   ` Burton, Ross
  2017-01-19 17:41     ` Rick Altherr
@ 2017-01-19 17:45     ` Denys Dmytriyenko
  2017-01-19 18:16       ` Burton, Ross
  1 sibling, 1 reply; 6+ messages in thread
From: Denys Dmytriyenko @ 2017-01-19 17:45 UTC (permalink / raw)
  To: Burton, Ross; +Cc: OE-core

On Thu, Jan 19, 2017 at 05:40:15PM +0000, Burton, Ross wrote:
> On 19 January 2017 at 17:37, Denys Dmytriyenko <denis@denix.org> wrote:
> 
> > Sometimes it's useful to load ramdisk in a specific location. Your patch
> > unconditionally removes this support, which is not a desired change. I have
> > a patch queued up to do it conditionally, which I'll try to submit shortly.
> >
> 
> Would that be the same as Nathan's "kernel-fitimage.bbclass: Allow unset
> load/entry addresses for ramdisks"?

Yeah, that one too, missed it... Been sitting there since October?

-- 
Denys


^ permalink raw reply	[flat|nested] 6+ messages in thread

* Re: [PATCH] kernel-fitimage: Let U-Boot select ramdisk load/entry address
  2017-01-19 17:45     ` Denys Dmytriyenko
@ 2017-01-19 18:16       ` Burton, Ross
  0 siblings, 0 replies; 6+ messages in thread
From: Burton, Ross @ 2017-01-19 18:16 UTC (permalink / raw)
  To: Denys Dmytriyenko; +Cc: OE-core

[-- Attachment #1: Type: text/plain, Size: 327 bytes --]

On 19 January 2017 at 17:45, Denys Dmytriyenko <denis@denix.org> wrote:

> Yeah, that one too, missed it... Been sitting there since October?
>

Nathan pinged earlier, it's in mut now and will be in master when RP has a
moment.  As you may have noticed, the recipe-specific-sysroots work is
keeping him busy :)

Ross

[-- Attachment #2: Type: text/html, Size: 802 bytes --]

^ permalink raw reply	[flat|nested] 6+ messages in thread

end of thread, other threads:[~2017-01-19 18:16 UTC | newest]

Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-19 16:58 [PATCH] kernel-fitimage: Let U-Boot select ramdisk load/entry address Rick Altherr
2017-01-19 17:37 ` Denys Dmytriyenko
2017-01-19 17:40   ` Burton, Ross
2017-01-19 17:41     ` Rick Altherr
2017-01-19 17:45     ` Denys Dmytriyenko
2017-01-19 18:16       ` Burton, Ross

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.