All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Lokesh Vutla <lokeshvutla@ti.com>
Cc: Paul Walmsley <paul@pwsan.com>, Vignesh R <vigneshr@ti.com>,
	linux-kernel@vger.kernel.org,
	Russell King <linux@armlinux.org.uk>,
	linux-omap@vger.kernel.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP5: Add HWMOD_SWSUP_SIDLE_ACT flag for UART
Date: Fri, 20 Jan 2017 10:11:10 -0800	[thread overview]
Message-ID: <20170120181110.GB7403@atomide.com> (raw)
In-Reply-To: <e84cd7c8-89bc-b2ef-e57d-6c0a37b0b51e@ti.com>

* Lokesh Vutla <lokeshvutla@ti.com> [170119 01:08]:
> 
> 
> On Wednesday 18 January 2017 05:18 PM, Vignesh R wrote:
> > According to the commit ca43ea345de9 ("ARM: OMAP2+: hwmod: Add a new
> > flag to handle SIDLE in SWSUP only in active"), UART IP needs the sidle
> > mode to be controlled in SW only while they are active. Once inactive,
> > the IP needs to be put back in HW control so they are also wakeup
> > capable. The flag HWMOD_SWSUP_SIDLE takes care of this. So add this flag
> > to all instances of UART.
> > 
> > With this change, 8250 UART now gives out proper RX Timeout interrupts
> > and is usable as console.
> > 
> > Signed-off-by: Vignesh R <vigneshr@ti.com>
> 
> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>

Thanks yeah this fixes the issue. As this is not a regression fix, applying
into omapf-rov-4.11/fixes-not-urgent.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] ARM: OMAP5: Add HWMOD_SWSUP_SIDLE_ACT flag for UART
Date: Fri, 20 Jan 2017 10:11:10 -0800	[thread overview]
Message-ID: <20170120181110.GB7403@atomide.com> (raw)
In-Reply-To: <e84cd7c8-89bc-b2ef-e57d-6c0a37b0b51e@ti.com>

* Lokesh Vutla <lokeshvutla@ti.com> [170119 01:08]:
> 
> 
> On Wednesday 18 January 2017 05:18 PM, Vignesh R wrote:
> > According to the commit ca43ea345de9 ("ARM: OMAP2+: hwmod: Add a new
> > flag to handle SIDLE in SWSUP only in active"), UART IP needs the sidle
> > mode to be controlled in SW only while they are active. Once inactive,
> > the IP needs to be put back in HW control so they are also wakeup
> > capable. The flag HWMOD_SWSUP_SIDLE takes care of this. So add this flag
> > to all instances of UART.
> > 
> > With this change, 8250 UART now gives out proper RX Timeout interrupts
> > and is usable as console.
> > 
> > Signed-off-by: Vignesh R <vigneshr@ti.com>
> 
> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>

Thanks yeah this fixes the issue. As this is not a regression fix, applying
into omapf-rov-4.11/fixes-not-urgent.

Regards,

Tony

WARNING: multiple messages have this Message-ID (diff)
From: Tony Lindgren <tony@atomide.com>
To: Lokesh Vutla <lokeshvutla@ti.com>
Cc: Vignesh R <vigneshr@ti.com>, Paul Walmsley <paul@pwsan.com>,
	Russell King <linux@armlinux.org.uk>,
	linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] ARM: OMAP5: Add HWMOD_SWSUP_SIDLE_ACT flag for UART
Date: Fri, 20 Jan 2017 10:11:10 -0800	[thread overview]
Message-ID: <20170120181110.GB7403@atomide.com> (raw)
In-Reply-To: <e84cd7c8-89bc-b2ef-e57d-6c0a37b0b51e@ti.com>

* Lokesh Vutla <lokeshvutla@ti.com> [170119 01:08]:
> 
> 
> On Wednesday 18 January 2017 05:18 PM, Vignesh R wrote:
> > According to the commit ca43ea345de9 ("ARM: OMAP2+: hwmod: Add a new
> > flag to handle SIDLE in SWSUP only in active"), UART IP needs the sidle
> > mode to be controlled in SW only while they are active. Once inactive,
> > the IP needs to be put back in HW control so they are also wakeup
> > capable. The flag HWMOD_SWSUP_SIDLE takes care of this. So add this flag
> > to all instances of UART.
> > 
> > With this change, 8250 UART now gives out proper RX Timeout interrupts
> > and is usable as console.
> > 
> > Signed-off-by: Vignesh R <vigneshr@ti.com>
> 
> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>

Thanks yeah this fixes the issue. As this is not a regression fix, applying
into omapf-rov-4.11/fixes-not-urgent.

Regards,

Tony

  reply	other threads:[~2017-01-20 18:11 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-01-18 11:48 [PATCH] ARM: OMAP5: Add HWMOD_SWSUP_SIDLE_ACT flag for UART Vignesh R
2017-01-18 11:48 ` Vignesh R
2017-01-18 11:48 ` Vignesh R
2017-01-19  9:05 ` Lokesh Vutla
2017-01-19  9:05   ` Lokesh Vutla
2017-01-19  9:05   ` Lokesh Vutla
2017-01-20 18:11   ` Tony Lindgren [this message]
2017-01-20 18:11     ` Tony Lindgren
2017-01-20 18:11     ` Tony Lindgren

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170120181110.GB7403@atomide.com \
    --to=tony@atomide.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=lokeshvutla@ti.com \
    --cc=paul@pwsan.com \
    --cc=vigneshr@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.