* [PATCH] ARM: OMAP5: Add HWMOD_SWSUP_SIDLE_ACT flag for UART
@ 2017-01-18 11:48 ` Vignesh R
0 siblings, 0 replies; 9+ messages in thread
From: Vignesh R @ 2017-01-18 11:48 UTC (permalink / raw)
To: Paul Walmsley, Tony Lindgren, Russell King
Cc: linux-omap, linux-kernel, linux-arm-kernel, Vignesh R
According to the commit ca43ea345de9 ("ARM: OMAP2+: hwmod: Add a new
flag to handle SIDLE in SWSUP only in active"), UART IP needs the sidle
mode to be controlled in SW only while they are active. Once inactive,
the IP needs to be put back in HW control so they are also wakeup
capable. The flag HWMOD_SWSUP_SIDLE takes care of this. So add this flag
to all instances of UART.
With this change, 8250 UART now gives out proper RX Timeout interrupts
and is usable as console.
Signed-off-by: Vignesh R <vigneshr@ti.com>
---
Tested on OMAP5 uEVM.
arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_54xx_data.c b/arch/arm/mach-omap2/omap_hwmod_54xx_data.c
index 8cdfd9b7ab4f..a2d763a4cc57 100644
--- a/arch/arm/mach-omap2/omap_hwmod_54xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_54xx_data.c
@@ -1748,6 +1748,7 @@ static struct omap_hwmod omap54xx_uart1_hwmod = {
.name = "uart1",
.class = &omap54xx_uart_hwmod_class,
.clkdm_name = "l4per_clkdm",
+ .flags = HWMOD_SWSUP_SIDLE_ACT,
.main_clk = "func_48m_fclk",
.prcm = {
.omap4 = {
@@ -1763,6 +1764,7 @@ static struct omap_hwmod omap54xx_uart2_hwmod = {
.name = "uart2",
.class = &omap54xx_uart_hwmod_class,
.clkdm_name = "l4per_clkdm",
+ .flags = HWMOD_SWSUP_SIDLE_ACT,
.main_clk = "func_48m_fclk",
.prcm = {
.omap4 = {
@@ -1778,7 +1780,7 @@ static struct omap_hwmod omap54xx_uart3_hwmod = {
.name = "uart3",
.class = &omap54xx_uart_hwmod_class,
.clkdm_name = "l4per_clkdm",
- .flags = DEBUG_OMAP4UART3_FLAGS,
+ .flags = DEBUG_OMAP4UART3_FLAGS | HWMOD_SWSUP_SIDLE_ACT,
.main_clk = "func_48m_fclk",
.prcm = {
.omap4 = {
@@ -1794,7 +1796,7 @@ static struct omap_hwmod omap54xx_uart4_hwmod = {
.name = "uart4",
.class = &omap54xx_uart_hwmod_class,
.clkdm_name = "l4per_clkdm",
- .flags = DEBUG_OMAP4UART4_FLAGS,
+ .flags = DEBUG_OMAP4UART4_FLAGS | HWMOD_SWSUP_SIDLE_ACT,
.main_clk = "func_48m_fclk",
.prcm = {
.omap4 = {
@@ -1810,6 +1812,7 @@ static struct omap_hwmod omap54xx_uart5_hwmod = {
.name = "uart5",
.class = &omap54xx_uart_hwmod_class,
.clkdm_name = "l4per_clkdm",
+ .flags = HWMOD_SWSUP_SIDLE_ACT,
.main_clk = "func_48m_fclk",
.prcm = {
.omap4 = {
@@ -1825,6 +1828,7 @@ static struct omap_hwmod omap54xx_uart6_hwmod = {
.name = "uart6",
.class = &omap54xx_uart_hwmod_class,
.clkdm_name = "l4per_clkdm",
+ .flags = HWMOD_SWSUP_SIDLE_ACT,
.main_clk = "func_48m_fclk",
.prcm = {
.omap4 = {
--
2.11.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] ARM: OMAP5: Add HWMOD_SWSUP_SIDLE_ACT flag for UART
@ 2017-01-18 11:48 ` Vignesh R
0 siblings, 0 replies; 9+ messages in thread
From: Vignesh R @ 2017-01-18 11:48 UTC (permalink / raw)
To: Paul Walmsley, Tony Lindgren, Russell King
Cc: linux-omap, linux-arm-kernel, linux-kernel, Vignesh R
According to the commit ca43ea345de9 ("ARM: OMAP2+: hwmod: Add a new
flag to handle SIDLE in SWSUP only in active"), UART IP needs the sidle
mode to be controlled in SW only while they are active. Once inactive,
the IP needs to be put back in HW control so they are also wakeup
capable. The flag HWMOD_SWSUP_SIDLE takes care of this. So add this flag
to all instances of UART.
With this change, 8250 UART now gives out proper RX Timeout interrupts
and is usable as console.
Signed-off-by: Vignesh R <vigneshr@ti.com>
---
Tested on OMAP5 uEVM.
arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_54xx_data.c b/arch/arm/mach-omap2/omap_hwmod_54xx_data.c
index 8cdfd9b7ab4f..a2d763a4cc57 100644
--- a/arch/arm/mach-omap2/omap_hwmod_54xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_54xx_data.c
@@ -1748,6 +1748,7 @@ static struct omap_hwmod omap54xx_uart1_hwmod = {
.name = "uart1",
.class = &omap54xx_uart_hwmod_class,
.clkdm_name = "l4per_clkdm",
+ .flags = HWMOD_SWSUP_SIDLE_ACT,
.main_clk = "func_48m_fclk",
.prcm = {
.omap4 = {
@@ -1763,6 +1764,7 @@ static struct omap_hwmod omap54xx_uart2_hwmod = {
.name = "uart2",
.class = &omap54xx_uart_hwmod_class,
.clkdm_name = "l4per_clkdm",
+ .flags = HWMOD_SWSUP_SIDLE_ACT,
.main_clk = "func_48m_fclk",
.prcm = {
.omap4 = {
@@ -1778,7 +1780,7 @@ static struct omap_hwmod omap54xx_uart3_hwmod = {
.name = "uart3",
.class = &omap54xx_uart_hwmod_class,
.clkdm_name = "l4per_clkdm",
- .flags = DEBUG_OMAP4UART3_FLAGS,
+ .flags = DEBUG_OMAP4UART3_FLAGS | HWMOD_SWSUP_SIDLE_ACT,
.main_clk = "func_48m_fclk",
.prcm = {
.omap4 = {
@@ -1794,7 +1796,7 @@ static struct omap_hwmod omap54xx_uart4_hwmod = {
.name = "uart4",
.class = &omap54xx_uart_hwmod_class,
.clkdm_name = "l4per_clkdm",
- .flags = DEBUG_OMAP4UART4_FLAGS,
+ .flags = DEBUG_OMAP4UART4_FLAGS | HWMOD_SWSUP_SIDLE_ACT,
.main_clk = "func_48m_fclk",
.prcm = {
.omap4 = {
@@ -1810,6 +1812,7 @@ static struct omap_hwmod omap54xx_uart5_hwmod = {
.name = "uart5",
.class = &omap54xx_uart_hwmod_class,
.clkdm_name = "l4per_clkdm",
+ .flags = HWMOD_SWSUP_SIDLE_ACT,
.main_clk = "func_48m_fclk",
.prcm = {
.omap4 = {
@@ -1825,6 +1828,7 @@ static struct omap_hwmod omap54xx_uart6_hwmod = {
.name = "uart6",
.class = &omap54xx_uart_hwmod_class,
.clkdm_name = "l4per_clkdm",
+ .flags = HWMOD_SWSUP_SIDLE_ACT,
.main_clk = "func_48m_fclk",
.prcm = {
.omap4 = {
--
2.11.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* [PATCH] ARM: OMAP5: Add HWMOD_SWSUP_SIDLE_ACT flag for UART
@ 2017-01-18 11:48 ` Vignesh R
0 siblings, 0 replies; 9+ messages in thread
From: Vignesh R @ 2017-01-18 11:48 UTC (permalink / raw)
To: linux-arm-kernel
According to the commit ca43ea345de9 ("ARM: OMAP2+: hwmod: Add a new
flag to handle SIDLE in SWSUP only in active"), UART IP needs the sidle
mode to be controlled in SW only while they are active. Once inactive,
the IP needs to be put back in HW control so they are also wakeup
capable. The flag HWMOD_SWSUP_SIDLE takes care of this. So add this flag
to all instances of UART.
With this change, 8250 UART now gives out proper RX Timeout interrupts
and is usable as console.
Signed-off-by: Vignesh R <vigneshr@ti.com>
---
Tested on OMAP5 uEVM.
arch/arm/mach-omap2/omap_hwmod_54xx_data.c | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/arch/arm/mach-omap2/omap_hwmod_54xx_data.c b/arch/arm/mach-omap2/omap_hwmod_54xx_data.c
index 8cdfd9b7ab4f..a2d763a4cc57 100644
--- a/arch/arm/mach-omap2/omap_hwmod_54xx_data.c
+++ b/arch/arm/mach-omap2/omap_hwmod_54xx_data.c
@@ -1748,6 +1748,7 @@ static struct omap_hwmod omap54xx_uart1_hwmod = {
.name = "uart1",
.class = &omap54xx_uart_hwmod_class,
.clkdm_name = "l4per_clkdm",
+ .flags = HWMOD_SWSUP_SIDLE_ACT,
.main_clk = "func_48m_fclk",
.prcm = {
.omap4 = {
@@ -1763,6 +1764,7 @@ static struct omap_hwmod omap54xx_uart2_hwmod = {
.name = "uart2",
.class = &omap54xx_uart_hwmod_class,
.clkdm_name = "l4per_clkdm",
+ .flags = HWMOD_SWSUP_SIDLE_ACT,
.main_clk = "func_48m_fclk",
.prcm = {
.omap4 = {
@@ -1778,7 +1780,7 @@ static struct omap_hwmod omap54xx_uart3_hwmod = {
.name = "uart3",
.class = &omap54xx_uart_hwmod_class,
.clkdm_name = "l4per_clkdm",
- .flags = DEBUG_OMAP4UART3_FLAGS,
+ .flags = DEBUG_OMAP4UART3_FLAGS | HWMOD_SWSUP_SIDLE_ACT,
.main_clk = "func_48m_fclk",
.prcm = {
.omap4 = {
@@ -1794,7 +1796,7 @@ static struct omap_hwmod omap54xx_uart4_hwmod = {
.name = "uart4",
.class = &omap54xx_uart_hwmod_class,
.clkdm_name = "l4per_clkdm",
- .flags = DEBUG_OMAP4UART4_FLAGS,
+ .flags = DEBUG_OMAP4UART4_FLAGS | HWMOD_SWSUP_SIDLE_ACT,
.main_clk = "func_48m_fclk",
.prcm = {
.omap4 = {
@@ -1810,6 +1812,7 @@ static struct omap_hwmod omap54xx_uart5_hwmod = {
.name = "uart5",
.class = &omap54xx_uart_hwmod_class,
.clkdm_name = "l4per_clkdm",
+ .flags = HWMOD_SWSUP_SIDLE_ACT,
.main_clk = "func_48m_fclk",
.prcm = {
.omap4 = {
@@ -1825,6 +1828,7 @@ static struct omap_hwmod omap54xx_uart6_hwmod = {
.name = "uart6",
.class = &omap54xx_uart_hwmod_class,
.clkdm_name = "l4per_clkdm",
+ .flags = HWMOD_SWSUP_SIDLE_ACT,
.main_clk = "func_48m_fclk",
.prcm = {
.omap4 = {
--
2.11.0
^ permalink raw reply related [flat|nested] 9+ messages in thread* Re: [PATCH] ARM: OMAP5: Add HWMOD_SWSUP_SIDLE_ACT flag for UART
2017-01-18 11:48 ` Vignesh R
(?)
@ 2017-01-19 9:05 ` Lokesh Vutla
-1 siblings, 0 replies; 9+ messages in thread
From: Lokesh Vutla @ 2017-01-19 9:05 UTC (permalink / raw)
To: Vignesh R, Paul Walmsley, Tony Lindgren, Russell King
Cc: linux-omap, linux-kernel, linux-arm-kernel
On Wednesday 18 January 2017 05:18 PM, Vignesh R wrote:
> According to the commit ca43ea345de9 ("ARM: OMAP2+: hwmod: Add a new
> flag to handle SIDLE in SWSUP only in active"), UART IP needs the sidle
> mode to be controlled in SW only while they are active. Once inactive,
> the IP needs to be put back in HW control so they are also wakeup
> capable. The flag HWMOD_SWSUP_SIDLE takes care of this. So add this flag
> to all instances of UART.
>
> With this change, 8250 UART now gives out proper RX Timeout interrupts
> and is usable as console.
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
Thanks and regards,
Lokesh
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] ARM: OMAP5: Add HWMOD_SWSUP_SIDLE_ACT flag for UART
@ 2017-01-19 9:05 ` Lokesh Vutla
0 siblings, 0 replies; 9+ messages in thread
From: Lokesh Vutla @ 2017-01-19 9:05 UTC (permalink / raw)
To: Vignesh R, Paul Walmsley, Tony Lindgren, Russell King
Cc: linux-omap, linux-kernel, linux-arm-kernel
On Wednesday 18 January 2017 05:18 PM, Vignesh R wrote:
> According to the commit ca43ea345de9 ("ARM: OMAP2+: hwmod: Add a new
> flag to handle SIDLE in SWSUP only in active"), UART IP needs the sidle
> mode to be controlled in SW only while they are active. Once inactive,
> the IP needs to be put back in HW control so they are also wakeup
> capable. The flag HWMOD_SWSUP_SIDLE takes care of this. So add this flag
> to all instances of UART.
>
> With this change, 8250 UART now gives out proper RX Timeout interrupts
> and is usable as console.
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
Thanks and regards,
Lokesh
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH] ARM: OMAP5: Add HWMOD_SWSUP_SIDLE_ACT flag for UART
@ 2017-01-19 9:05 ` Lokesh Vutla
0 siblings, 0 replies; 9+ messages in thread
From: Lokesh Vutla @ 2017-01-19 9:05 UTC (permalink / raw)
To: linux-arm-kernel
On Wednesday 18 January 2017 05:18 PM, Vignesh R wrote:
> According to the commit ca43ea345de9 ("ARM: OMAP2+: hwmod: Add a new
> flag to handle SIDLE in SWSUP only in active"), UART IP needs the sidle
> mode to be controlled in SW only while they are active. Once inactive,
> the IP needs to be put back in HW control so they are also wakeup
> capable. The flag HWMOD_SWSUP_SIDLE takes care of this. So add this flag
> to all instances of UART.
>
> With this change, 8250 UART now gives out proper RX Timeout interrupts
> and is usable as console.
>
> Signed-off-by: Vignesh R <vigneshr@ti.com>
Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
Thanks and regards,
Lokesh
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] ARM: OMAP5: Add HWMOD_SWSUP_SIDLE_ACT flag for UART
2017-01-19 9:05 ` Lokesh Vutla
(?)
@ 2017-01-20 18:11 ` Tony Lindgren
-1 siblings, 0 replies; 9+ messages in thread
From: Tony Lindgren @ 2017-01-20 18:11 UTC (permalink / raw)
To: Lokesh Vutla
Cc: Paul Walmsley, Vignesh R, linux-kernel, Russell King, linux-omap,
linux-arm-kernel
* Lokesh Vutla <lokeshvutla@ti.com> [170119 01:08]:
>
>
> On Wednesday 18 January 2017 05:18 PM, Vignesh R wrote:
> > According to the commit ca43ea345de9 ("ARM: OMAP2+: hwmod: Add a new
> > flag to handle SIDLE in SWSUP only in active"), UART IP needs the sidle
> > mode to be controlled in SW only while they are active. Once inactive,
> > the IP needs to be put back in HW control so they are also wakeup
> > capable. The flag HWMOD_SWSUP_SIDLE takes care of this. So add this flag
> > to all instances of UART.
> >
> > With this change, 8250 UART now gives out proper RX Timeout interrupts
> > and is usable as console.
> >
> > Signed-off-by: Vignesh R <vigneshr@ti.com>
>
> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
Thanks yeah this fixes the issue. As this is not a regression fix, applying
into omapf-rov-4.11/fixes-not-urgent.
Regards,
Tony
^ permalink raw reply [flat|nested] 9+ messages in thread* Re: [PATCH] ARM: OMAP5: Add HWMOD_SWSUP_SIDLE_ACT flag for UART
@ 2017-01-20 18:11 ` Tony Lindgren
0 siblings, 0 replies; 9+ messages in thread
From: Tony Lindgren @ 2017-01-20 18:11 UTC (permalink / raw)
To: Lokesh Vutla
Cc: Vignesh R, Paul Walmsley, Russell King, linux-omap, linux-kernel,
linux-arm-kernel
* Lokesh Vutla <lokeshvutla@ti.com> [170119 01:08]:
>
>
> On Wednesday 18 January 2017 05:18 PM, Vignesh R wrote:
> > According to the commit ca43ea345de9 ("ARM: OMAP2+: hwmod: Add a new
> > flag to handle SIDLE in SWSUP only in active"), UART IP needs the sidle
> > mode to be controlled in SW only while they are active. Once inactive,
> > the IP needs to be put back in HW control so they are also wakeup
> > capable. The flag HWMOD_SWSUP_SIDLE takes care of this. So add this flag
> > to all instances of UART.
> >
> > With this change, 8250 UART now gives out proper RX Timeout interrupts
> > and is usable as console.
> >
> > Signed-off-by: Vignesh R <vigneshr@ti.com>
>
> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
Thanks yeah this fixes the issue. As this is not a regression fix, applying
into omapf-rov-4.11/fixes-not-urgent.
Regards,
Tony
^ permalink raw reply [flat|nested] 9+ messages in thread* [PATCH] ARM: OMAP5: Add HWMOD_SWSUP_SIDLE_ACT flag for UART
@ 2017-01-20 18:11 ` Tony Lindgren
0 siblings, 0 replies; 9+ messages in thread
From: Tony Lindgren @ 2017-01-20 18:11 UTC (permalink / raw)
To: linux-arm-kernel
* Lokesh Vutla <lokeshvutla@ti.com> [170119 01:08]:
>
>
> On Wednesday 18 January 2017 05:18 PM, Vignesh R wrote:
> > According to the commit ca43ea345de9 ("ARM: OMAP2+: hwmod: Add a new
> > flag to handle SIDLE in SWSUP only in active"), UART IP needs the sidle
> > mode to be controlled in SW only while they are active. Once inactive,
> > the IP needs to be put back in HW control so they are also wakeup
> > capable. The flag HWMOD_SWSUP_SIDLE takes care of this. So add this flag
> > to all instances of UART.
> >
> > With this change, 8250 UART now gives out proper RX Timeout interrupts
> > and is usable as console.
> >
> > Signed-off-by: Vignesh R <vigneshr@ti.com>
>
> Reviewed-by: Lokesh Vutla <lokeshvutla@ti.com>
Thanks yeah this fixes the issue. As this is not a regression fix, applying
into omapf-rov-4.11/fixes-not-urgent.
Regards,
Tony
^ permalink raw reply [flat|nested] 9+ messages in thread
end of thread, other threads:[~2017-01-20 18:12 UTC | newest]
Thread overview: 9+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2017-01-18 11:48 [PATCH] ARM: OMAP5: Add HWMOD_SWSUP_SIDLE_ACT flag for UART Vignesh R
2017-01-18 11:48 ` Vignesh R
2017-01-18 11:48 ` Vignesh R
2017-01-19 9:05 ` Lokesh Vutla
2017-01-19 9:05 ` Lokesh Vutla
2017-01-19 9:05 ` Lokesh Vutla
2017-01-20 18:11 ` Tony Lindgren
2017-01-20 18:11 ` Tony Lindgren
2017-01-20 18:11 ` Tony Lindgren
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.