From: "Pali Rohár" <pali.rohar@gmail.com>
To: Pavel Machek <pavel@ucw.cz>
Cc: Tony Lindgren <tony@atomide.com>,
sre@kernel.org, kernel list <linux-kernel@vger.kernel.org>,
linux-arm-kernel <linux-arm-kernel@lists.infradead.org>,
linux-omap@vger.kernel.org, khilman@kernel.org,
aaro.koskinen@iki.fi, ivo.g.dimitrov.75@gmail.com,
patrikbachan@gmail.com, serge@hallyn.com, abcloriens@gmail.com,
b-liu@ti.com, linux-usb@vger.kernel.org
Subject: Re: v4.9 to v4.10 regression: oops when USB cable is plugged in.
Date: Tue, 24 Jan 2017 11:01:33 +0100 [thread overview]
Message-ID: <20170124100133.GA21079@pali> (raw)
In-Reply-To: <20170124091817.GA29246@amd>
On Tuesday 24 January 2017 10:18:17 Pavel Machek wrote:
> Hi!
> On Mon 2017-01-23 14:44:54, Tony Lindgren wrote:
> > * Pavel Machek <pavel@ucw.cz> [170123 14:26]:
> > > [25392.239837] Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa0ab060
> > > [25392.239868] pgd = c0004000
> > > [25392.239898] [fa0ab060] *pgd=48011452(bad)
> > > [25392.239929] Internal error: : 1028 [#1] ARM
> > > [25392.239929] Modules linked in:
> > > [25392.239959] CPU: 0 PID: 24322 Comm: kworker/0:1 Not tainted 4.10.0-rc5-142127-g41f2839-dirty #222
> > > [25392.239990] Hardware name: Nokia RX-51 board
> > > [25392.240020] Workqueue: events musb_irq_work
> > > [25392.240051] task: cd44d5c0 task.stack: cd308000
> > > [25392.240051] PC is at musb_default_readb+0x0/0xc
> > > [25392.240081] LR is at musb_irq_work+0x1c/0x1b0
> >
> > OK I'm pretty sure the patch I posted few days ago fixes
> > this. Can you please test patch "[PATCH] usb: musb: Fix
> > external abort on non-linefetch for musb_irq_work()"?
>
> Can I get the copy of the patch?
>
> http://www.spinics.net/lists/linux-usb/msg152542.html
>
> ...but it is html mangled with no obvious way to unmangle it.
Another place when caller of pm_runtime_get_sync forgot to check return
value? This is not first time I see this problem related to Nokia N900!
In past I already suggested to use gcc attribute for pm_runtime_get_sync
to issue warning when caller does not check return value.
> > I was able to hit that only once so far, do you hit it
> > every time with your built-in g_ether .config?
>
> I get it "way too often", like once a day. I don't yet know how to hit
> it reliably :-(.
--
Pali Rohár
pali.rohar@gmail.com
WARNING: multiple messages have this Message-ID (diff)
From: pali.rohar@gmail.com (Pali Rohár)
To: linux-arm-kernel@lists.infradead.org
Subject: v4.9 to v4.10 regression: oops when USB cable is plugged in.
Date: Tue, 24 Jan 2017 11:01:33 +0100 [thread overview]
Message-ID: <20170124100133.GA21079@pali> (raw)
In-Reply-To: <20170124091817.GA29246@amd>
On Tuesday 24 January 2017 10:18:17 Pavel Machek wrote:
> Hi!
> On Mon 2017-01-23 14:44:54, Tony Lindgren wrote:
> > * Pavel Machek <pavel@ucw.cz> [170123 14:26]:
> > > [25392.239837] Unhandled fault: external abort on non-linefetch (0x1028) at 0xfa0ab060
> > > [25392.239868] pgd = c0004000
> > > [25392.239898] [fa0ab060] *pgd=48011452(bad)
> > > [25392.239929] Internal error: : 1028 [#1] ARM
> > > [25392.239929] Modules linked in:
> > > [25392.239959] CPU: 0 PID: 24322 Comm: kworker/0:1 Not tainted 4.10.0-rc5-142127-g41f2839-dirty #222
> > > [25392.239990] Hardware name: Nokia RX-51 board
> > > [25392.240020] Workqueue: events musb_irq_work
> > > [25392.240051] task: cd44d5c0 task.stack: cd308000
> > > [25392.240051] PC is at musb_default_readb+0x0/0xc
> > > [25392.240081] LR is at musb_irq_work+0x1c/0x1b0
> >
> > OK I'm pretty sure the patch I posted few days ago fixes
> > this. Can you please test patch "[PATCH] usb: musb: Fix
> > external abort on non-linefetch for musb_irq_work()"?
>
> Can I get the copy of the patch?
>
> http://www.spinics.net/lists/linux-usb/msg152542.html
>
> ...but it is html mangled with no obvious way to unmangle it.
Another place when caller of pm_runtime_get_sync forgot to check return
value? This is not first time I see this problem related to Nokia N900!
In past I already suggested to use gcc attribute for pm_runtime_get_sync
to issue warning when caller does not check return value.
> > I was able to hit that only once so far, do you hit it
> > every time with your built-in g_ether .config?
>
> I get it "way too often", like once a day. I don't yet know how to hit
> it reliably :-(.
--
Pali Roh?r
pali.rohar at gmail.com
next prev parent reply other threads:[~2017-01-24 10:01 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-23 22:25 v4.9 to v4.10 regression: oops when USB cable is plugged in Pavel Machek
2017-01-23 22:25 ` Pavel Machek
2017-01-23 22:25 ` Pavel Machek
2017-01-23 22:44 ` Tony Lindgren
2017-01-23 22:44 ` Tony Lindgren
2017-01-24 9:18 ` Pavel Machek
2017-01-24 9:18 ` Pavel Machek
2017-01-24 10:01 ` Pali Rohár [this message]
2017-01-24 10:01 ` Pali Rohár
2017-01-24 14:51 ` Tony Lindgren
2017-01-24 14:51 ` Tony Lindgren
2017-01-27 21:55 ` Pavel Machek
2017-01-27 21:55 ` Pavel Machek
2017-01-27 21:55 ` Pavel Machek
2017-01-27 23:48 ` Sebastian Reichel
2017-01-27 23:48 ` Sebastian Reichel
2017-02-03 7:59 ` Pavel Machek
2017-02-03 7:59 ` Pavel Machek
2017-02-03 16:30 ` Tony Lindgren
2017-02-03 16:30 ` Tony Lindgren
[not found] ` <20170203163048.GA3721-4v6yS6AI5VpBDgjK7y7TUQ@public.gmane.org>
2017-02-05 21:44 ` Pavel Machek
2017-02-05 21:44 ` Pavel Machek
2017-02-05 21:44 ` Pavel Machek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124100133.GA21079@pali \
--to=pali.rohar@gmail.com \
--cc=aaro.koskinen@iki.fi \
--cc=abcloriens@gmail.com \
--cc=b-liu@ti.com \
--cc=ivo.g.dimitrov.75@gmail.com \
--cc=khilman@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=patrikbachan@gmail.com \
--cc=pavel@ucw.cz \
--cc=serge@hallyn.com \
--cc=sre@kernel.org \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.