From: Stephen Hemminger <stephen@networkplumber.org>
To: "Linus Lüssing" <linus.luessing@c0d3.blue>
Cc: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
netdev@vger.kernel.org, bridge@lists.linux-foundation.org,
linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org,
"David S . Miller" <davem@davemloft.net>,
Felix Fietkau <nbd@nbd.name>
Subject: Re: [Bridge] [PATCH net-next v5] bridge: multicast to unicast
Date: Tue, 24 Jan 2017 10:12:15 -0800 [thread overview]
Message-ID: <20170124101215.4e3017b2@xeon-e3> (raw)
In-Reply-To: <20170121200133.1864-1-linus.luessing@c0d3.blue>
On Sat, 21 Jan 2017 21:01:32 +0100
Linus Lüssing <linus.luessing@c0d3.blue> wrote:
> +static bool br_port_group_equal(struct net_bridge_port_group *p,
> + struct net_bridge_port *port,
> + const unsigned char *src)
> +{
> + if (p->port != port)
> + return false;
> +
> + if (!(port->flags & BR_MULTICAST_TO_UNICAST))
> + return true;
> +
> + return ether_addr_equal(src, p->eth_addr);
> +}
> +
I prefer that argument to functions like this be const.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Linus Lüssing" <linus.luessing@c0d3.blue>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Felix Fietkau <nbd@nbd.name>,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH net-next v5] bridge: multicast to unicast
Date: Tue, 24 Jan 2017 10:12:15 -0800 [thread overview]
Message-ID: <20170124101215.4e3017b2@xeon-e3> (raw)
In-Reply-To: <20170121200133.1864-1-linus.luessing@c0d3.blue>
On Sat, 21 Jan 2017 21:01:32 +0100
Linus L=C3=BCssing <linus.luessing@c0d3.blue> wrote:
> +static bool br_port_group_equal(struct net_bridge_port_group *p,
> + struct net_bridge_port *port,
> + const unsigned char *src)
> +{
> + if (p->port !=3D port)
> + return false;
> +
> + if (!(port->flags & BR_MULTICAST_TO_UNICAST))
> + return true;
> +
> + return ether_addr_equal(src, p->eth_addr);
> +}
> +
I prefer that argument to functions like this be const.
WARNING: multiple messages have this Message-ID (diff)
From: Stephen Hemminger <stephen@networkplumber.org>
To: "Linus Lüssing" <linus.luessing@c0d3.blue>
Cc: netdev@vger.kernel.org, "David S . Miller" <davem@davemloft.net>,
Felix Fietkau <nbd@nbd.name>,
Nikolay Aleksandrov <nikolay@cumulusnetworks.com>,
bridge@lists.linux-foundation.org, linux-kernel@vger.kernel.org,
linux-wireless@vger.kernel.org
Subject: Re: [PATCH net-next v5] bridge: multicast to unicast
Date: Tue, 24 Jan 2017 10:12:15 -0800 [thread overview]
Message-ID: <20170124101215.4e3017b2@xeon-e3> (raw)
In-Reply-To: <20170121200133.1864-1-linus.luessing@c0d3.blue>
On Sat, 21 Jan 2017 21:01:32 +0100
Linus Lüssing <linus.luessing@c0d3.blue> wrote:
> +static bool br_port_group_equal(struct net_bridge_port_group *p,
> + struct net_bridge_port *port,
> + const unsigned char *src)
> +{
> + if (p->port != port)
> + return false;
> +
> + if (!(port->flags & BR_MULTICAST_TO_UNICAST))
> + return true;
> +
> + return ether_addr_equal(src, p->eth_addr);
> +}
> +
I prefer that argument to functions like this be const.
next prev parent reply other threads:[~2017-01-24 18:12 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-21 20:01 [Bridge] [PATCH net-next v5] bridge: multicast to unicast Linus Lüssing
2017-01-21 20:01 ` Linus Lüssing
2017-01-21 20:01 ` Linus Lüssing
2017-01-21 22:29 ` [Bridge] " Nikolay Aleksandrov
2017-01-21 22:29 ` Nikolay Aleksandrov via Bridge
2017-01-21 22:29 ` Nikolay Aleksandrov
2017-01-24 17:41 ` [Bridge] " David Miller
2017-01-24 17:41 ` David Miller
2017-01-24 17:41 ` David Miller
2017-01-24 18:10 ` [Bridge] " Stephen Hemminger
2017-01-24 18:10 ` Stephen Hemminger
2017-01-24 18:10 ` Stephen Hemminger
2017-01-24 18:12 ` Stephen Hemminger [this message]
2017-01-24 18:12 ` Stephen Hemminger
2017-01-24 18:12 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170124101215.4e3017b2@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=bridge@lists.linux-foundation.org \
--cc=davem@davemloft.net \
--cc=linus.luessing@c0d3.blue \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-wireless@vger.kernel.org \
--cc=nbd@nbd.name \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.