From: will.deacon@arm.com (Will Deacon)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v5 2/2] arm64: Work around Falkor erratum 1009
Date: Tue, 31 Jan 2017 14:36:35 +0000 [thread overview]
Message-ID: <20170131143635.GC22283@arm.com> (raw)
In-Reply-To: <20170131124223.GE11191@leverpostej>
On Tue, Jan 31, 2017 at 12:42:23PM +0000, Mark Rutland wrote:
> On Mon, Jan 30, 2017 at 06:08:17PM -0500, Christopher Covington wrote:
> > During a TLB invalidate sequence targeting the inner shareable domain,
> > Falkor may prematurely complete the DSB before all loads and stores using
> > the old translation are observed. Instruction fetches are not subject to
> > the conditions of this erratum. If the original code sequence includes
> > multiple TLB invalidate instructions followed by a single DSB, onle one of
> > the TLB instructions needs to be repeated to work around this erratum.
> > While the erratum only applies to cases in which the TLBI specifies the
> > inner-shareable domain (*IS form of TLBI) and the DSB is ISH form or
> > stronger (OSH, SYS), this changes applies the workaround overabundantly--
> > to local TLBI, DSB NSH sequences as well--for simplicity.
> >
> > Based on work by Shanker Donthineni <shankerd@codeaurora.org>
> >
> > Signed-off-by: Christopher Covington <cov@codeaurora.org>
>
> This looks simple, self-contained, and correct, so FWIW:
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
>
> Catalin/Will, since we may see a documentation conflict against a timer
> erratum, would you be hapyp to pick up [1] first, fixing up this patch
> as necessary?
>
> [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2017-January/484594.html
I replied over there, but I'd rather just take all the silicon-errata.txt
changes because I don't see them as being dependent on the rest of the
series.
For this patch specifically, I can't merge it until you're happy with the
other workaround, since they conflict.
Will
WARNING: multiple messages have this Message-ID (diff)
From: Will Deacon <will.deacon@arm.com>
To: Mark Rutland <mark.rutland@arm.com>
Cc: Christopher Covington <cov@codeaurora.org>,
Jonathan Corbet <corbet@lwn.net>,
Marc Zyngier <marc.zyngier@arm.com>,
Catalin Marinas <catalin.marinas@arm.com>,
linux-doc@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, shankerd@codeaurora.org,
timur@codeaurora.org, Mark Langsdorf <mlangsdo@redhat.com>,
Mark Salter <msalter@redhat.com>, Jon Masters <jcm@redhat.com>,
Neil Leeder <nleeder@codeaurora.org>
Subject: Re: [PATCH v5 2/2] arm64: Work around Falkor erratum 1009
Date: Tue, 31 Jan 2017 14:36:35 +0000 [thread overview]
Message-ID: <20170131143635.GC22283@arm.com> (raw)
In-Reply-To: <20170131124223.GE11191@leverpostej>
On Tue, Jan 31, 2017 at 12:42:23PM +0000, Mark Rutland wrote:
> On Mon, Jan 30, 2017 at 06:08:17PM -0500, Christopher Covington wrote:
> > During a TLB invalidate sequence targeting the inner shareable domain,
> > Falkor may prematurely complete the DSB before all loads and stores using
> > the old translation are observed. Instruction fetches are not subject to
> > the conditions of this erratum. If the original code sequence includes
> > multiple TLB invalidate instructions followed by a single DSB, onle one of
> > the TLB instructions needs to be repeated to work around this erratum.
> > While the erratum only applies to cases in which the TLBI specifies the
> > inner-shareable domain (*IS form of TLBI) and the DSB is ISH form or
> > stronger (OSH, SYS), this changes applies the workaround overabundantly--
> > to local TLBI, DSB NSH sequences as well--for simplicity.
> >
> > Based on work by Shanker Donthineni <shankerd@codeaurora.org>
> >
> > Signed-off-by: Christopher Covington <cov@codeaurora.org>
>
> This looks simple, self-contained, and correct, so FWIW:
>
> Acked-by: Mark Rutland <mark.rutland@arm.com>
>
> Catalin/Will, since we may see a documentation conflict against a timer
> erratum, would you be hapyp to pick up [1] first, fixing up this patch
> as necessary?
>
> [1] http://lists.infradead.org/pipermail/linux-arm-kernel/2017-January/484594.html
I replied over there, but I'd rather just take all the silicon-errata.txt
changes because I don't see them as being dependent on the rest of the
series.
For this patch specifically, I can't merge it until you're happy with the
other workaround, since they conflict.
Will
next prev parent reply other threads:[~2017-01-31 14:36 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-01-30 23:08 [PATCH v5 1/2] arm64: Work around Falkor erratum 1003 Christopher Covington
2017-01-30 23:08 ` Christopher Covington
2017-01-30 23:08 ` [PATCH v5 2/2] arm64: Work around Falkor erratum 1009 Christopher Covington
2017-01-30 23:08 ` Christopher Covington
2017-01-31 12:42 ` Mark Rutland
2017-01-31 12:42 ` Mark Rutland
2017-01-31 14:36 ` Will Deacon [this message]
2017-01-31 14:36 ` Will Deacon
2017-01-31 14:38 ` Will Deacon
2017-01-31 14:38 ` Will Deacon
2017-01-31 16:17 ` Christopher Covington
2017-01-31 16:17 ` Christopher Covington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170131143635.GC22283@arm.com \
--to=will.deacon@arm.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.