All of lore.kernel.org
 help / color / mirror / Atom feed
From: AKASHI Takahiro <takahiro.akashi@linaro.org>
To: Mark Rutland <mark.rutland@arm.com>
Cc: geoff@infradead.org, catalin.marinas@arm.com,
	will.deacon@arm.com, james.morse@arm.com,
	bauerman@linux.vnet.ibm.com, dyoung@redhat.com,
	kexec@lists.infradead.org, linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v31 09/12] arm64: kdump: provide /proc/vmcore file
Date: Thu, 2 Feb 2017 23:39:58 +0900	[thread overview]
Message-ID: <20170202143957.GB3078@fireball> (raw)
In-Reply-To: <20170202120850.GL31394@leverpostej>

On Thu, Feb 02, 2017 at 12:08:50PM +0000, Mark Rutland wrote:
> On Thu, Feb 02, 2017 at 12:03:20PM +0000, Mark Rutland wrote:
> > On Thu, Feb 02, 2017 at 03:24:09PM +0900, AKASHI Takahiro wrote:
> > > On Wed, Feb 01, 2017 at 07:21:22PM +0000, Mark Rutland wrote:
> > > > On Wed, Feb 01, 2017 at 09:46:28PM +0900, AKASHI Takahiro wrote:
> 
> > > > > +/*
> > > > > + * reserve_elfcorehdr() - reserves memory for elf core header
> > > > > + *
> > > > > + * This function reserves elf core header given in "elfcorehdr=" kernel
> > > > > + * command line parameter. This region contains all the information about
> > > > > + * primary kernel's core image and is used by a dump capture kernel to
> > > > > + * access the system memory on primary kernel.
> > > > > + */
> 
> > Can you also fix the comment above reserve_elfcorehdr()? It refers to a
> > non-existent kernel command line option.
> 
> ... or rather, one that's handled by core code, not
> reserve_elfcorehdr().
> 
> So more specifically, it would be nicer to have something like:
> 
> 	/*
> 	 * reserve_elfcorehdr() - reserves memory for elf core header
> 	 *
> 	 * This function reserves the memory occupied by an elf core header
> 	 * described in the device tree. This region contains all the
> 	 * information about primary kernel's core image and is used by a dump
> 	 * capture kernel to access the system memory on primary kernel.
> 	 */

Perfect!

Thanks a lot,
-Takahiro AKASHI


> Thanks,
> Mark.

_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec

WARNING: multiple messages have this Message-ID (diff)
From: takahiro.akashi@linaro.org (AKASHI Takahiro)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v31 09/12] arm64: kdump: provide /proc/vmcore file
Date: Thu, 2 Feb 2017 23:39:58 +0900	[thread overview]
Message-ID: <20170202143957.GB3078@fireball> (raw)
In-Reply-To: <20170202120850.GL31394@leverpostej>

On Thu, Feb 02, 2017 at 12:08:50PM +0000, Mark Rutland wrote:
> On Thu, Feb 02, 2017 at 12:03:20PM +0000, Mark Rutland wrote:
> > On Thu, Feb 02, 2017 at 03:24:09PM +0900, AKASHI Takahiro wrote:
> > > On Wed, Feb 01, 2017 at 07:21:22PM +0000, Mark Rutland wrote:
> > > > On Wed, Feb 01, 2017 at 09:46:28PM +0900, AKASHI Takahiro wrote:
> 
> > > > > +/*
> > > > > + * reserve_elfcorehdr() - reserves memory for elf core header
> > > > > + *
> > > > > + * This function reserves elf core header given in "elfcorehdr=" kernel
> > > > > + * command line parameter. This region contains all the information about
> > > > > + * primary kernel's core image and is used by a dump capture kernel to
> > > > > + * access the system memory on primary kernel.
> > > > > + */
> 
> > Can you also fix the comment above reserve_elfcorehdr()? It refers to a
> > non-existent kernel command line option.
> 
> ... or rather, one that's handled by core code, not
> reserve_elfcorehdr().
> 
> So more specifically, it would be nicer to have something like:
> 
> 	/*
> 	 * reserve_elfcorehdr() - reserves memory for elf core header
> 	 *
> 	 * This function reserves the memory occupied by an elf core header
> 	 * described in the device tree. This region contains all the
> 	 * information about primary kernel's core image and is used by a dump
> 	 * capture kernel to access the system memory on primary kernel.
> 	 */

Perfect!

Thanks a lot,
-Takahiro AKASHI


> Thanks,
> Mark.

  reply	other threads:[~2017-02-02 14:41 UTC|newest]

Thread overview: 92+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-01 12:42 [PATCH v31 00/12] add kdump support AKASHI Takahiro
2017-02-01 12:42 ` AKASHI Takahiro
2017-02-01 12:45 ` [PATCH v31 01/12] memblock: add memblock_cap_memory_range() AKASHI Takahiro
2017-02-01 12:45   ` AKASHI Takahiro
2017-02-01 12:45   ` AKASHI Takahiro
2017-02-01 12:46 ` [PATCH v31 02/12] arm64: limit memory regions based on DT property, usable-memory-range AKASHI Takahiro
2017-02-01 12:46   ` AKASHI Takahiro
2017-02-01 15:07   ` Mark Rutland
2017-02-01 15:07     ` Mark Rutland
2017-02-02  4:21     ` AKASHI Takahiro
2017-02-02  4:21       ` AKASHI Takahiro
2017-02-01 12:46 ` [PATCH v31 03/12] arm64: kdump: reserve memory for crash dump kernel AKASHI Takahiro
2017-02-01 12:46   ` AKASHI Takahiro
2017-02-01 15:26   ` Mark Rutland
2017-02-01 15:26     ` Mark Rutland
2017-02-02  4:52     ` AKASHI Takahiro
2017-02-02  4:52       ` AKASHI Takahiro
2017-02-02 11:26       ` Mark Rutland
2017-02-02 11:26         ` Mark Rutland
2017-02-02 13:44         ` AKASHI Takahiro
2017-02-02 13:44           ` AKASHI Takahiro
2017-02-01 12:46 ` [PATCH v31 04/12] arm64: mm: allow for unmapping part of kernel mapping AKASHI Takahiro
2017-02-01 12:46   ` AKASHI Takahiro
2017-02-01 16:03   ` Mark Rutland
2017-02-01 16:03     ` Mark Rutland
2017-02-02 10:21     ` AKASHI Takahiro
2017-02-02 10:21       ` AKASHI Takahiro
2017-02-02 11:44       ` Mark Rutland
2017-02-02 11:44         ` Mark Rutland
2017-02-02 14:01         ` AKASHI Takahiro
2017-02-02 14:01           ` AKASHI Takahiro
2017-02-02 14:35           ` Mark Rutland
2017-02-02 14:35             ` Mark Rutland
2017-02-02 14:55             ` AKASHI Takahiro
2017-02-02 14:55               ` AKASHI Takahiro
2017-02-03  6:13               ` AKASHI Takahiro
2017-02-03  6:13                 ` AKASHI Takahiro
2017-02-03 14:22                 ` Mark Rutland
2017-02-03 14:22                   ` Mark Rutland
2017-02-01 12:46 ` [PATCH v31 05/12] arm64: kdump: protect crash dump kernel memory AKASHI Takahiro
2017-02-01 12:46   ` AKASHI Takahiro
2017-02-01 18:00   ` Mark Rutland
2017-02-01 18:00     ` Mark Rutland
2017-02-01 18:25     ` Mark Rutland
2017-02-01 18:25       ` Mark Rutland
2017-02-02 10:39       ` AKASHI Takahiro
2017-02-02 10:39         ` AKASHI Takahiro
2017-02-02 11:54         ` Mark Rutland
2017-02-02 11:54           ` Mark Rutland
2017-02-03  1:45           ` AKASHI Takahiro
2017-02-03  1:45             ` AKASHI Takahiro
2017-02-03 11:51             ` Mark Rutland
2017-02-03 11:51               ` Mark Rutland
2017-02-02 10:45       ` James Morse
2017-02-02 10:45         ` James Morse
2017-02-02 11:19         ` AKASHI Takahiro
2017-02-02 11:19           ` AKASHI Takahiro
2017-02-02 11:48         ` Mark Rutland
2017-02-02 11:48           ` Mark Rutland
2017-02-02 10:31     ` AKASHI Takahiro
2017-02-02 10:31       ` AKASHI Takahiro
2017-02-02 11:16       ` Mark Rutland
2017-02-02 11:16         ` Mark Rutland
2017-02-02 14:36         ` AKASHI Takahiro
2017-02-02 14:36           ` AKASHI Takahiro
2017-02-02 15:36           ` Mark Rutland
2017-02-02 15:36             ` Mark Rutland
2017-02-01 12:46 ` [PATCH v31 06/12] arm64: hibernate: preserve kdump image around hibernation AKASHI Takahiro
2017-02-01 12:46   ` AKASHI Takahiro
2017-02-01 12:46 ` [PATCH v31 07/12] arm64: kdump: implement machine_crash_shutdown() AKASHI Takahiro
2017-02-01 12:46   ` AKASHI Takahiro
2017-02-01 12:46 ` [PATCH v31 08/12] arm64: kdump: add VMCOREINFO's for user-space tools AKASHI Takahiro
2017-02-01 12:46   ` AKASHI Takahiro
2017-02-01 12:46 ` [PATCH v31 09/12] arm64: kdump: provide /proc/vmcore file AKASHI Takahiro
2017-02-01 12:46   ` AKASHI Takahiro
2017-02-01 19:21   ` Mark Rutland
2017-02-01 19:21     ` Mark Rutland
2017-02-02  6:24     ` AKASHI Takahiro
2017-02-02  6:24       ` AKASHI Takahiro
2017-02-02 12:03       ` Mark Rutland
2017-02-02 12:03         ` Mark Rutland
2017-02-02 12:08         ` Mark Rutland
2017-02-02 12:08           ` Mark Rutland
2017-02-02 14:39           ` AKASHI Takahiro [this message]
2017-02-02 14:39             ` AKASHI Takahiro
2017-02-01 12:46 ` [PATCH v31 10/12] arm64: kdump: enable kdump in defconfig AKASHI Takahiro
2017-02-01 12:46   ` AKASHI Takahiro
2017-02-01 12:46 ` [PATCH v31 11/12] Documentation: kdump: describe arm64 port AKASHI Takahiro
2017-02-01 12:46   ` AKASHI Takahiro
2017-02-01 12:48 ` [PATCH v31 12/12] Documentation: dt: chosen properties for arm64 kdump AKASHI Takahiro
2017-02-01 12:48   ` AKASHI Takahiro
2017-02-01 12:48   ` AKASHI Takahiro

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170202143957.GB3078@fireball \
    --to=takahiro.akashi@linaro.org \
    --cc=bauerman@linux.vnet.ibm.com \
    --cc=catalin.marinas@arm.com \
    --cc=dyoung@redhat.com \
    --cc=geoff@infradead.org \
    --cc=james.morse@arm.com \
    --cc=kexec@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=mark.rutland@arm.com \
    --cc=will.deacon@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.