From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [net-next] ARM: orion: fix PHYLIB dependency
Date: Thu, 9 Feb 2017 18:20:24 +0100 [thread overview]
Message-ID: <20170209172024.GE29882@lunn.ch> (raw)
In-Reply-To: <1967873.WpTcGj2Cy4@wuerfel>
> Adding a 'select' statement to something as broad as NETDEVICES sounds
> really bad, it has a significant risk of introducing dependency loops
> and may be confusing if you want to build a multiplatform config without
> networking support (note that NETDEVICES in turn depends on NET, which
> can also be disabled).
O.K, so overall it is not simple. So lets drop my idea.
> One possibility would be to have a special Kconfig symbol that controls
> mdiobus_register_board_info() being present and have that symbol
> force PHYLIB to never be "=m". Then we can either have no networking
> support and no phylib, turning mdiobus_register_board_info() into a
> stub, or we have the function built-in and reachable from the board
> code.
FYI: Florian is working on splitting MDIO out of PHYLIB. There will be
two separate symbols, so it will be possible to have MDIO without
PHYLIB. When this happens, i expect mdiobus_register_board_info() will
be in the MDIO part, not PHYLIB.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-arm-kernel@lists.infradead.org,
"David S . Miller" <davem@davemloft.net>,
netdev@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Gregory Clement <gregory.clement@free-electrons.com>,
Russell King <linux@armlinux.org.uk>,
Florian Fainelli <f.fainelli@gmail.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] [net-next] ARM: orion: fix PHYLIB dependency
Date: Thu, 9 Feb 2017 18:20:24 +0100 [thread overview]
Message-ID: <20170209172024.GE29882@lunn.ch> (raw)
In-Reply-To: <1967873.WpTcGj2Cy4@wuerfel>
> Adding a 'select' statement to something as broad as NETDEVICES sounds
> really bad, it has a significant risk of introducing dependency loops
> and may be confusing if you want to build a multiplatform config without
> networking support (note that NETDEVICES in turn depends on NET, which
> can also be disabled).
O.K, so overall it is not simple. So lets drop my idea.
> One possibility would be to have a special Kconfig symbol that controls
> mdiobus_register_board_info() being present and have that symbol
> force PHYLIB to never be "=m". Then we can either have no networking
> support and no phylib, turning mdiobus_register_board_info() into a
> stub, or we have the function built-in and reachable from the board
> code.
FYI: Florian is working on splitting MDIO out of PHYLIB. There will be
two separate symbols, so it will be possible to have MDIO without
PHYLIB. When this happens, i expect mdiobus_register_board_info() will
be in the MDIO part, not PHYLIB.
Andrew
WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Florian Fainelli <f.fainelli@gmail.com>,
Jason Cooper <jason@lakedaemon.net>,
netdev@vger.kernel.org, Russell King <linux@armlinux.org.uk>,
linux-kernel@vger.kernel.org,
Gregory Clement <gregory.clement@free-electrons.com>,
"David S . Miller" <davem@davemloft.net>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH] [net-next] ARM: orion: fix PHYLIB dependency
Date: Thu, 9 Feb 2017 18:20:24 +0100 [thread overview]
Message-ID: <20170209172024.GE29882@lunn.ch> (raw)
In-Reply-To: <1967873.WpTcGj2Cy4@wuerfel>
> Adding a 'select' statement to something as broad as NETDEVICES sounds
> really bad, it has a significant risk of introducing dependency loops
> and may be confusing if you want to build a multiplatform config without
> networking support (note that NETDEVICES in turn depends on NET, which
> can also be disabled).
O.K, so overall it is not simple. So lets drop my idea.
> One possibility would be to have a special Kconfig symbol that controls
> mdiobus_register_board_info() being present and have that symbol
> force PHYLIB to never be "=m". Then we can either have no networking
> support and no phylib, turning mdiobus_register_board_info() into a
> stub, or we have the function built-in and reachable from the board
> code.
FYI: Florian is working on splitting MDIO out of PHYLIB. There will be
two separate symbols, so it will be possible to have MDIO without
PHYLIB. When this happens, i expect mdiobus_register_board_info() will
be in the MDIO part, not PHYLIB.
Andrew
next prev parent reply other threads:[~2017-02-09 17:20 UTC|newest]
Thread overview: 37+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-09 15:08 [PATCH] [net-next] ARM: orion: fix PHYLIB dependency Arnd Bergmann
2017-02-09 15:08 ` Arnd Bergmann
2017-02-09 15:08 ` Arnd Bergmann
2017-02-09 15:57 ` Andrew Lunn
2017-02-09 15:57 ` Andrew Lunn
2017-02-09 15:57 ` Andrew Lunn
2017-02-09 17:14 ` Arnd Bergmann
2017-02-09 17:14 ` Arnd Bergmann
2017-02-09 17:14 ` Arnd Bergmann
2017-02-09 17:20 ` Andrew Lunn [this message]
2017-02-09 17:20 ` Andrew Lunn
2017-02-09 17:20 ` Andrew Lunn
2017-02-09 18:14 ` Florian Fainelli
2017-02-09 18:14 ` Florian Fainelli
2017-02-09 18:14 ` Florian Fainelli
2017-02-09 17:22 ` Andrew Lunn
2017-02-09 17:22 ` Andrew Lunn
2017-02-09 17:22 ` Andrew Lunn
2017-02-09 18:22 ` Florian Fainelli
2017-02-09 18:22 ` Florian Fainelli
2017-02-09 18:22 ` Florian Fainelli
2017-02-10 8:20 ` Arnd Bergmann
2017-02-10 8:20 ` Arnd Bergmann
2017-02-10 8:20 ` Arnd Bergmann
2017-02-10 17:42 ` Florian Fainelli
2017-02-10 17:42 ` Florian Fainelli
2017-02-10 17:42 ` Florian Fainelli
2017-02-10 20:05 ` Arnd Bergmann
2017-02-10 20:05 ` Arnd Bergmann
2017-02-10 20:05 ` Arnd Bergmann
2017-02-10 20:57 ` Florian Fainelli
2017-02-10 20:57 ` Florian Fainelli
2017-02-10 21:32 ` Arnd Bergmann
2017-02-10 21:32 ` Arnd Bergmann
2017-02-10 21:32 ` Arnd Bergmann
2017-02-13 14:31 ` Arnd Bergmann
2017-02-13 14:31 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170209172024.GE29882@lunn.ch \
--to=andrew@lunn.ch \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.