All of lore.kernel.org
 help / color / mirror / Atom feed
From: f.fainelli@gmail.com (Florian Fainelli)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] [net-next] ARM: orion: fix PHYLIB dependency
Date: Fri, 10 Feb 2017 09:42:21 -0800	[thread overview]
Message-ID: <352146cc-845c-2860-44ca-7338eb53e260@gmail.com> (raw)
In-Reply-To: <CAK8P3a2Yss8r0qoubg2C7Jp+0JE3Fx+igWHQOscR+SB6d+W_HA@mail.gmail.com>

On 02/10/2017 12:20 AM, Arnd Bergmann wrote:
> On Thu, Feb 9, 2017 at 7:22 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
>> On 02/09/2017 07:08 AM, Arnd Bergmann wrote:
>> I disabled CONFIG_NETDEVICES to force CONFIG_PHY not to be set here, and
>> I was not able to reproduce this, what am I missing?
> 
> In the ARMv5 allmodconfig build, this fails because CONFIG_PHY=m, and
> we can't call into it. You could use IS_BUILTIN instead of IS_ENABLED in
> the header as a oneline workaround, but I think that would be more confusing
> to real users that try to use CONFIG_PHY=m without realizing why they lose
> access to their switch.

I see, this patch should also help fixing this:

http://patchwork.ozlabs.org/patch/726381/

-- 
Florian

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: "David S . Miller" <davem@davemloft.net>,
	Networking <netdev@vger.kernel.org>,
	Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Gregory Clement <gregory.clement@free-electrons.com>,
	Russell King <linux@armlinux.org.uk>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] [net-next] ARM: orion: fix PHYLIB dependency
Date: Fri, 10 Feb 2017 09:42:21 -0800	[thread overview]
Message-ID: <352146cc-845c-2860-44ca-7338eb53e260@gmail.com> (raw)
In-Reply-To: <CAK8P3a2Yss8r0qoubg2C7Jp+0JE3Fx+igWHQOscR+SB6d+W_HA@mail.gmail.com>

On 02/10/2017 12:20 AM, Arnd Bergmann wrote:
> On Thu, Feb 9, 2017 at 7:22 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
>> On 02/09/2017 07:08 AM, Arnd Bergmann wrote:
>> I disabled CONFIG_NETDEVICES to force CONFIG_PHY not to be set here, and
>> I was not able to reproduce this, what am I missing?
> 
> In the ARMv5 allmodconfig build, this fails because CONFIG_PHY=m, and
> we can't call into it. You could use IS_BUILTIN instead of IS_ENABLED in
> the header as a oneline workaround, but I think that would be more confusing
> to real users that try to use CONFIG_PHY=m without realizing why they lose
> access to their switch.

I see, this patch should also help fixing this:

http://patchwork.ozlabs.org/patch/726381/

-- 
Florian

WARNING: multiple messages have this Message-ID (diff)
From: Florian Fainelli <f.fainelli@gmail.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Andrew Lunn <andrew@lunn.ch>, Jason Cooper <jason@lakedaemon.net>,
	Networking <netdev@vger.kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Gregory Clement <gregory.clement@free-electrons.com>,
	"David S . Miller" <davem@davemloft.net>,
	Linux ARM <linux-arm-kernel@lists.infradead.org>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH] [net-next] ARM: orion: fix PHYLIB dependency
Date: Fri, 10 Feb 2017 09:42:21 -0800	[thread overview]
Message-ID: <352146cc-845c-2860-44ca-7338eb53e260@gmail.com> (raw)
In-Reply-To: <CAK8P3a2Yss8r0qoubg2C7Jp+0JE3Fx+igWHQOscR+SB6d+W_HA@mail.gmail.com>

On 02/10/2017 12:20 AM, Arnd Bergmann wrote:
> On Thu, Feb 9, 2017 at 7:22 PM, Florian Fainelli <f.fainelli@gmail.com> wrote:
>> On 02/09/2017 07:08 AM, Arnd Bergmann wrote:
>> I disabled CONFIG_NETDEVICES to force CONFIG_PHY not to be set here, and
>> I was not able to reproduce this, what am I missing?
> 
> In the ARMv5 allmodconfig build, this fails because CONFIG_PHY=m, and
> we can't call into it. You could use IS_BUILTIN instead of IS_ENABLED in
> the header as a oneline workaround, but I think that would be more confusing
> to real users that try to use CONFIG_PHY=m without realizing why they lose
> access to their switch.

I see, this patch should also help fixing this:

http://patchwork.ozlabs.org/patch/726381/

-- 
Florian

  reply	other threads:[~2017-02-10 17:42 UTC|newest]

Thread overview: 37+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-02-09 15:08 [PATCH] [net-next] ARM: orion: fix PHYLIB dependency Arnd Bergmann
2017-02-09 15:08 ` Arnd Bergmann
2017-02-09 15:08 ` Arnd Bergmann
2017-02-09 15:57 ` Andrew Lunn
2017-02-09 15:57   ` Andrew Lunn
2017-02-09 15:57   ` Andrew Lunn
2017-02-09 17:14   ` Arnd Bergmann
2017-02-09 17:14     ` Arnd Bergmann
2017-02-09 17:14     ` Arnd Bergmann
2017-02-09 17:20     ` Andrew Lunn
2017-02-09 17:20       ` Andrew Lunn
2017-02-09 17:20       ` Andrew Lunn
2017-02-09 18:14       ` Florian Fainelli
2017-02-09 18:14         ` Florian Fainelli
2017-02-09 18:14         ` Florian Fainelli
2017-02-09 17:22 ` Andrew Lunn
2017-02-09 17:22   ` Andrew Lunn
2017-02-09 17:22   ` Andrew Lunn
2017-02-09 18:22 ` Florian Fainelli
2017-02-09 18:22   ` Florian Fainelli
2017-02-09 18:22   ` Florian Fainelli
2017-02-10  8:20   ` Arnd Bergmann
2017-02-10  8:20     ` Arnd Bergmann
2017-02-10  8:20     ` Arnd Bergmann
2017-02-10 17:42     ` Florian Fainelli [this message]
2017-02-10 17:42       ` Florian Fainelli
2017-02-10 17:42       ` Florian Fainelli
2017-02-10 20:05       ` Arnd Bergmann
2017-02-10 20:05         ` Arnd Bergmann
2017-02-10 20:05         ` Arnd Bergmann
2017-02-10 20:57         ` Florian Fainelli
2017-02-10 20:57           ` Florian Fainelli
2017-02-10 21:32           ` Arnd Bergmann
2017-02-10 21:32             ` Arnd Bergmann
2017-02-10 21:32             ` Arnd Bergmann
2017-02-13 14:31             ` Arnd Bergmann
2017-02-13 14:31               ` Arnd Bergmann

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=352146cc-845c-2860-44ca-7338eb53e260@gmail.com \
    --to=f.fainelli@gmail.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.