* [PATCH] bcm2835-audio: Fix checkpatch errors @ 2017-02-11 20:34 ` Man Choy 0 siblings, 0 replies; 10+ messages in thread From: Man Choy @ 2017-02-11 20:34 UTC (permalink / raw) To: linux-arm-kernel Fix following errors: ERROR: do not initialise statics to NULL +static struct snd_card *g_card = NULL; ERROR: do not initialise statics to NULL +static struct bcm2835_chip *g_chip = NULL; Signed-off-by: Man Choy <manchoyy@gmail.com> --- drivers/staging/bcm2835-audio/bcm2835.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm2835-audio/bcm2835.c b/drivers/staging/bcm2835-audio/bcm2835.c index a84d74d..265fe55 100644 --- a/drivers/staging/bcm2835-audio/bcm2835.c +++ b/drivers/staging/bcm2835-audio/bcm2835.c @@ -28,8 +28,8 @@ * to debug if we run into issues */ -static struct snd_card *g_card = NULL; -static struct bcm2835_chip *g_chip = NULL; +static struct snd_card *g_card; +static struct bcm2835_chip *g_chip; static int snd_bcm2835_free(struct bcm2835_chip *chip) { -- 2.7.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] bcm2835-audio: Fix checkpatch errors @ 2017-02-11 20:34 ` Man Choy 0 siblings, 0 replies; 10+ messages in thread From: Man Choy @ 2017-02-11 20:34 UTC (permalink / raw) To: mzoran Cc: Man Choy, Greg Kroah-Hartman, Stephen Warren, Lee Jones, Eric Anholt, devel, linux-rpi-kernel, linux-arm-kernel, linux-kernel Fix following errors: ERROR: do not initialise statics to NULL +static struct snd_card *g_card = NULL; ERROR: do not initialise statics to NULL +static struct bcm2835_chip *g_chip = NULL; Signed-off-by: Man Choy <manchoyy@gmail.com> --- drivers/staging/bcm2835-audio/bcm2835.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/bcm2835-audio/bcm2835.c b/drivers/staging/bcm2835-audio/bcm2835.c index a84d74d..265fe55 100644 --- a/drivers/staging/bcm2835-audio/bcm2835.c +++ b/drivers/staging/bcm2835-audio/bcm2835.c @@ -28,8 +28,8 @@ * to debug if we run into issues */ -static struct snd_card *g_card = NULL; -static struct bcm2835_chip *g_chip = NULL; +static struct snd_card *g_card; +static struct bcm2835_chip *g_chip; static int snd_bcm2835_free(struct bcm2835_chip *chip) { -- 2.7.4 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH] bcm2835-audio: Fix checkpatch errors 2017-02-11 20:34 ` Man Choy @ 2017-02-12 12:16 ` Greg Kroah-Hartman -1 siblings, 0 replies; 10+ messages in thread From: Greg Kroah-Hartman @ 2017-02-12 12:16 UTC (permalink / raw) To: linux-arm-kernel On Sun, Feb 12, 2017 at 04:34:09AM +0800, Man Choy wrote: > Fix following errors: > > ERROR: do not initialise statics to NULL > +static struct snd_card *g_card = NULL; > > ERROR: do not initialise statics to NULL > +static struct bcm2835_chip *g_chip = NULL; > > Signed-off-by: Man Choy <manchoyy@gmail.com> > --- > drivers/staging/bcm2835-audio/bcm2835.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/bcm2835-audio/bcm2835.c b/drivers/staging/bcm2835-audio/bcm2835.c > index a84d74d..265fe55 100644 > --- a/drivers/staging/bcm2835-audio/bcm2835.c > +++ b/drivers/staging/bcm2835-audio/bcm2835.c > @@ -28,8 +28,8 @@ > * to debug if we run into issues > */ > > -static struct snd_card *g_card = NULL; > -static struct bcm2835_chip *g_chip = NULL; > +static struct snd_card *g_card; > +static struct bcm2835_chip *g_chip; > > static int snd_bcm2835_free(struct bcm2835_chip *chip) > { Someone sent this same fix in before you did, a few days ago. Be sure to always use the most up-to-date tree. sorry, greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] bcm2835-audio: Fix checkpatch errors @ 2017-02-12 12:16 ` Greg Kroah-Hartman 0 siblings, 0 replies; 10+ messages in thread From: Greg Kroah-Hartman @ 2017-02-12 12:16 UTC (permalink / raw) To: Man Choy Cc: mzoran, devel, Stephen Warren, Lee Jones, linux-kernel, Eric Anholt, linux-rpi-kernel, linux-arm-kernel On Sun, Feb 12, 2017 at 04:34:09AM +0800, Man Choy wrote: > Fix following errors: > > ERROR: do not initialise statics to NULL > +static struct snd_card *g_card = NULL; > > ERROR: do not initialise statics to NULL > +static struct bcm2835_chip *g_chip = NULL; > > Signed-off-by: Man Choy <manchoyy@gmail.com> > --- > drivers/staging/bcm2835-audio/bcm2835.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/staging/bcm2835-audio/bcm2835.c b/drivers/staging/bcm2835-audio/bcm2835.c > index a84d74d..265fe55 100644 > --- a/drivers/staging/bcm2835-audio/bcm2835.c > +++ b/drivers/staging/bcm2835-audio/bcm2835.c > @@ -28,8 +28,8 @@ > * to debug if we run into issues > */ > > -static struct snd_card *g_card = NULL; > -static struct bcm2835_chip *g_chip = NULL; > +static struct snd_card *g_card; > +static struct bcm2835_chip *g_chip; > > static int snd_bcm2835_free(struct bcm2835_chip *chip) > { Someone sent this same fix in before you did, a few days ago. Be sure to always use the most up-to-date tree. sorry, greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] bcm2835-audio: Fix checkpatch errors 2017-02-12 12:16 ` Greg Kroah-Hartman @ 2017-02-13 0:49 ` Man Choy -1 siblings, 0 replies; 10+ messages in thread From: Man Choy @ 2017-02-13 0:49 UTC (permalink / raw) To: linux-arm-kernel On Sun, Feb 12, 2017 at 8:16 PM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > On Sun, Feb 12, 2017 at 04:34:09AM +0800, Man Choy wrote: >> Fix following errors: >> >> ERROR: do not initialise statics to NULL >> +static struct snd_card *g_card = NULL; >> >> ERROR: do not initialise statics to NULL >> +static struct bcm2835_chip *g_chip = NULL; >> >> Signed-off-by: Man Choy <manchoyy@gmail.com> >> --- >> drivers/staging/bcm2835-audio/bcm2835.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/bcm2835-audio/bcm2835.c b/drivers/staging/bcm2835-audio/bcm2835.c >> index a84d74d..265fe55 100644 >> --- a/drivers/staging/bcm2835-audio/bcm2835.c >> +++ b/drivers/staging/bcm2835-audio/bcm2835.c >> @@ -28,8 +28,8 @@ >> * to debug if we run into issues >> */ >> >> -static struct snd_card *g_card = NULL; >> -static struct bcm2835_chip *g_chip = NULL; >> +static struct snd_card *g_card; >> +static struct bcm2835_chip *g_chip; >> >> static int snd_bcm2835_free(struct bcm2835_chip *chip) >> { > > Someone sent this same fix in before you did, a few days ago. Be sure > to always use the most up-to-date tree. > > sorry, > > greg k-h Please ignore previous email. It contains HTML. Noted and thanks Greg. A quick question, I just updated my linux-next tree last night, checkout tag "next-20170210" and working on the cleanup. How do I double check my current working file already been updated by someone else to avoid the duplicate work? As of now, the latest linux-next tree tag is still "next-20170210" I am on eudyptula challenge and this is my first attempt to send kernel patch, sorry about the silly question ;) MC ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] bcm2835-audio: Fix checkpatch errors @ 2017-02-13 0:49 ` Man Choy 0 siblings, 0 replies; 10+ messages in thread From: Man Choy @ 2017-02-13 0:49 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: mzoran, devel, Stephen Warren, Lee Jones, linux-kernel, Eric Anholt, linux-rpi-kernel, linux-arm-kernel On Sun, Feb 12, 2017 at 8:16 PM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > On Sun, Feb 12, 2017 at 04:34:09AM +0800, Man Choy wrote: >> Fix following errors: >> >> ERROR: do not initialise statics to NULL >> +static struct snd_card *g_card = NULL; >> >> ERROR: do not initialise statics to NULL >> +static struct bcm2835_chip *g_chip = NULL; >> >> Signed-off-by: Man Choy <manchoyy@gmail.com> >> --- >> drivers/staging/bcm2835-audio/bcm2835.c | 4 ++-- >> 1 file changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/staging/bcm2835-audio/bcm2835.c b/drivers/staging/bcm2835-audio/bcm2835.c >> index a84d74d..265fe55 100644 >> --- a/drivers/staging/bcm2835-audio/bcm2835.c >> +++ b/drivers/staging/bcm2835-audio/bcm2835.c >> @@ -28,8 +28,8 @@ >> * to debug if we run into issues >> */ >> >> -static struct snd_card *g_card = NULL; >> -static struct bcm2835_chip *g_chip = NULL; >> +static struct snd_card *g_card; >> +static struct bcm2835_chip *g_chip; >> >> static int snd_bcm2835_free(struct bcm2835_chip *chip) >> { > > Someone sent this same fix in before you did, a few days ago. Be sure > to always use the most up-to-date tree. > > sorry, > > greg k-h Please ignore previous email. It contains HTML. Noted and thanks Greg. A quick question, I just updated my linux-next tree last night, checkout tag "next-20170210" and working on the cleanup. How do I double check my current working file already been updated by someone else to avoid the duplicate work? As of now, the latest linux-next tree tag is still "next-20170210" I am on eudyptula challenge and this is my first attempt to send kernel patch, sorry about the silly question ;) MC ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] bcm2835-audio: Fix checkpatch errors 2017-02-13 0:49 ` Man Choy @ 2017-02-13 12:03 ` Greg Kroah-Hartman -1 siblings, 0 replies; 10+ messages in thread From: Greg Kroah-Hartman @ 2017-02-13 12:03 UTC (permalink / raw) To: linux-arm-kernel On Mon, Feb 13, 2017 at 08:49:06AM +0800, Man Choy wrote: > A quick question, I just updated my linux-next tree last night, > checkout tag "next-20170210" and working on the cleanup. How do I > double check my current working file already been updated by someone > else to avoid the duplicate work? As of now, the latest linux-next > tree tag is still "next-20170210" linux-next is usually a day or so behind my tree, due to the time differences when it is created and why I usually do work. You can work off of my staging-next branch in my staging.git tree on git.kernel.org, that is the most up-to-date branch that ends up in linux-next. I also use staging-testing, to test things, but I would not recommend that for you as it can be rebased and would be a pain to work against. It's ok that conflicts happen, that's how kernel development works, sometimes people send in the same change minutes from each other, so I have to take the one that was sent first. It's ok, just move on and work on something else if you really want to. > I am on eudyptula challenge and this is my first attempt to send > kernel patch, sorry about the silly question ;) It's not silly, it comes up all the time. good luck! greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] bcm2835-audio: Fix checkpatch errors @ 2017-02-13 12:03 ` Greg Kroah-Hartman 0 siblings, 0 replies; 10+ messages in thread From: Greg Kroah-Hartman @ 2017-02-13 12:03 UTC (permalink / raw) To: Man Choy Cc: devel, Stephen Warren, Lee Jones, linux-kernel, Eric Anholt, mzoran, linux-rpi-kernel, linux-arm-kernel On Mon, Feb 13, 2017 at 08:49:06AM +0800, Man Choy wrote: > A quick question, I just updated my linux-next tree last night, > checkout tag "next-20170210" and working on the cleanup. How do I > double check my current working file already been updated by someone > else to avoid the duplicate work? As of now, the latest linux-next > tree tag is still "next-20170210" linux-next is usually a day or so behind my tree, due to the time differences when it is created and why I usually do work. You can work off of my staging-next branch in my staging.git tree on git.kernel.org, that is the most up-to-date branch that ends up in linux-next. I also use staging-testing, to test things, but I would not recommend that for you as it can be rebased and would be a pain to work against. It's ok that conflicts happen, that's how kernel development works, sometimes people send in the same change minutes from each other, so I have to take the one that was sent first. It's ok, just move on and work on something else if you really want to. > I am on eudyptula challenge and this is my first attempt to send > kernel patch, sorry about the silly question ;) It's not silly, it comes up all the time. good luck! greg k-h ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH] bcm2835-audio: Fix checkpatch errors 2017-02-13 12:03 ` Greg Kroah-Hartman @ 2017-02-14 1:16 ` Man Choy -1 siblings, 0 replies; 10+ messages in thread From: Man Choy @ 2017-02-14 1:16 UTC (permalink / raw) To: linux-arm-kernel On Mon, Feb 13, 2017 at 8:03 PM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > On Mon, Feb 13, 2017 at 08:49:06AM +0800, Man Choy wrote: >> A quick question, I just updated my linux-next tree last night, >> checkout tag "next-20170210" and working on the cleanup. How do I >> double check my current working file already been updated by someone >> else to avoid the duplicate work? As of now, the latest linux-next >> tree tag is still "next-20170210" > > linux-next is usually a day or so behind my tree, due to the time > differences when it is created and why I usually do work. > > You can work off of my staging-next branch in my staging.git tree on > git.kernel.org, that is the most up-to-date branch that ends up in > linux-next. I also use staging-testing, to test things, but I would not > recommend that for you as it can be rebased and would be a pain to work > against. > > It's ok that conflicts happen, that's how kernel development works, > sometimes people send in the same change minutes from each other, so I > have to take the one that was sent first. It's ok, just move on and > work on something else if you really want to. > >> I am on eudyptula challenge and this is my first attempt to send >> kernel patch, sorry about the silly question ;) > > It's not silly, it comes up all the time. > > good luck! > > greg k-h Thanks for the kind advice. I will look up your staging-next branch and do something about it. Talk to you soon. - MC ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH] bcm2835-audio: Fix checkpatch errors @ 2017-02-14 1:16 ` Man Choy 0 siblings, 0 replies; 10+ messages in thread From: Man Choy @ 2017-02-14 1:16 UTC (permalink / raw) To: Greg Kroah-Hartman Cc: devel, Stephen Warren, Lee Jones, linux-kernel, Eric Anholt, mzoran, linux-rpi-kernel, linux-arm-kernel On Mon, Feb 13, 2017 at 8:03 PM, Greg Kroah-Hartman <gregkh@linuxfoundation.org> wrote: > On Mon, Feb 13, 2017 at 08:49:06AM +0800, Man Choy wrote: >> A quick question, I just updated my linux-next tree last night, >> checkout tag "next-20170210" and working on the cleanup. How do I >> double check my current working file already been updated by someone >> else to avoid the duplicate work? As of now, the latest linux-next >> tree tag is still "next-20170210" > > linux-next is usually a day or so behind my tree, due to the time > differences when it is created and why I usually do work. > > You can work off of my staging-next branch in my staging.git tree on > git.kernel.org, that is the most up-to-date branch that ends up in > linux-next. I also use staging-testing, to test things, but I would not > recommend that for you as it can be rebased and would be a pain to work > against. > > It's ok that conflicts happen, that's how kernel development works, > sometimes people send in the same change minutes from each other, so I > have to take the one that was sent first. It's ok, just move on and > work on something else if you really want to. > >> I am on eudyptula challenge and this is my first attempt to send >> kernel patch, sorry about the silly question ;) > > It's not silly, it comes up all the time. > > good luck! > > greg k-h Thanks for the kind advice. I will look up your staging-next branch and do something about it. Talk to you soon. - MC ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2017-02-14 1:17 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2017-02-11 20:34 [PATCH] bcm2835-audio: Fix checkpatch errors Man Choy 2017-02-11 20:34 ` Man Choy 2017-02-12 12:16 ` Greg Kroah-Hartman 2017-02-12 12:16 ` Greg Kroah-Hartman 2017-02-13 0:49 ` Man Choy 2017-02-13 0:49 ` Man Choy 2017-02-13 12:03 ` Greg Kroah-Hartman 2017-02-13 12:03 ` Greg Kroah-Hartman 2017-02-14 1:16 ` Man Choy 2017-02-14 1:16 ` Man Choy
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.