From: Sean Paul <seanpaul@chromium.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: linux-rockchip@lists.infradead.org,
Daniel Vetter <daniel.vetter@ffwll.ch>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
Yakir Yang <ykk@rock-chips.com>, Chris Zhong <zyw@rock-chips.com>,
Guenter Roeck <groeck@chromium.org>,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/rockchip: add extcon dependency for DP
Date: Thu, 23 Feb 2017 11:48:42 -0500 [thread overview]
Message-ID: <20170223164841.GC24066@art_vandelay> (raw)
In-Reply-To: <20170214213215.2888509-1-arnd@arndb.de>
On Tue, Feb 14, 2017 at 10:31:51PM +0100, Arnd Bergmann wrote:
> The newly added DP driver links against the extcon core, which fails when
> extcon is a module and this driver is not:
>
> drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes':
> cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x24): undefined reference to `extcon_get_state'
> cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x44): undefined reference to `extcon_get_property'
>
> Let's make Kconfig enforce correct behavior with a dependency.
>
> Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to drm-misc-next-fixes
Thanks,
Sean
> ---
> drivers/gpu/drm/rockchip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
> index ad31b3eb408f..0e4eb845cbb0 100644
> --- a/drivers/gpu/drm/rockchip/Kconfig
> +++ b/drivers/gpu/drm/rockchip/Kconfig
> @@ -24,6 +24,7 @@ config ROCKCHIP_ANALOGIX_DP
> config ROCKCHIP_CDN_DP
> tristate "Rockchip cdn DP"
> depends on DRM_ROCKCHIP
> + depends on EXTCON
> select SND_SOC_HDMI_CODEC if SND_SOC
> help
> This selects support for Rockchip SoC specific extensions
> --
> 2.9.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Sean Paul, Software Engineer, Google / Chromium OS
_______________________________________________
dri-devel mailing list
dri-devel@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/dri-devel
WARNING: multiple messages have this Message-ID (diff)
From: seanpaul@chromium.org (Sean Paul)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH] drm/rockchip: add extcon dependency for DP
Date: Thu, 23 Feb 2017 11:48:42 -0500 [thread overview]
Message-ID: <20170223164841.GC24066@art_vandelay> (raw)
In-Reply-To: <20170214213215.2888509-1-arnd@arndb.de>
On Tue, Feb 14, 2017 at 10:31:51PM +0100, Arnd Bergmann wrote:
> The newly added DP driver links against the extcon core, which fails when
> extcon is a module and this driver is not:
>
> drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes':
> cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x24): undefined reference to `extcon_get_state'
> cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x44): undefined reference to `extcon_get_property'
>
> Let's make Kconfig enforce correct behavior with a dependency.
>
> Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to drm-misc-next-fixes
Thanks,
Sean
> ---
> drivers/gpu/drm/rockchip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
> index ad31b3eb408f..0e4eb845cbb0 100644
> --- a/drivers/gpu/drm/rockchip/Kconfig
> +++ b/drivers/gpu/drm/rockchip/Kconfig
> @@ -24,6 +24,7 @@ config ROCKCHIP_ANALOGIX_DP
> config ROCKCHIP_CDN_DP
> tristate "Rockchip cdn DP"
> depends on DRM_ROCKCHIP
> + depends on EXTCON
> select SND_SOC_HDMI_CODEC if SND_SOC
> help
> This selects support for Rockchip SoC specific extensions
> --
> 2.9.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Sean Paul, Software Engineer, Google / Chromium OS
WARNING: multiple messages have this Message-ID (diff)
From: Sean Paul <seanpaul@chromium.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Mark Yao <mark.yao@rock-chips.com>,
David Airlie <airlied@linux.ie>,
Tobias Jakobi <tjakobi@math.uni-bielefeld.de>,
Daniel Vetter <daniel.vetter@ffwll.ch>,
linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
Chris Zhong <zyw@rock-chips.com>, Yakir Yang <ykk@rock-chips.com>,
Guenter Roeck <groeck@chromium.org>,
linux-rockchip@lists.infradead.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] drm/rockchip: add extcon dependency for DP
Date: Thu, 23 Feb 2017 11:48:42 -0500 [thread overview]
Message-ID: <20170223164841.GC24066@art_vandelay> (raw)
In-Reply-To: <20170214213215.2888509-1-arnd@arndb.de>
On Tue, Feb 14, 2017 at 10:31:51PM +0100, Arnd Bergmann wrote:
> The newly added DP driver links against the extcon core, which fails when
> extcon is a module and this driver is not:
>
> drivers/gpu/drm/rockchip/cdn-dp-core.o: In function `cdn_dp_get_port_lanes':
> cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x24): undefined reference to `extcon_get_state'
> cdn-dp-core.c:(.text.cdn_dp_get_port_lanes+0x44): undefined reference to `extcon_get_property'
>
> Let's make Kconfig enforce correct behavior with a dependency.
>
> Fixes: 1a0f7ed3abe2 ("drm/rockchip: cdn-dp: add cdn DP support for rk3399")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
Applied to drm-misc-next-fixes
Thanks,
Sean
> ---
> drivers/gpu/drm/rockchip/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/gpu/drm/rockchip/Kconfig b/drivers/gpu/drm/rockchip/Kconfig
> index ad31b3eb408f..0e4eb845cbb0 100644
> --- a/drivers/gpu/drm/rockchip/Kconfig
> +++ b/drivers/gpu/drm/rockchip/Kconfig
> @@ -24,6 +24,7 @@ config ROCKCHIP_ANALOGIX_DP
> config ROCKCHIP_CDN_DP
> tristate "Rockchip cdn DP"
> depends on DRM_ROCKCHIP
> + depends on EXTCON
> select SND_SOC_HDMI_CODEC if SND_SOC
> help
> This selects support for Rockchip SoC specific extensions
> --
> 2.9.0
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Sean Paul, Software Engineer, Google / Chromium OS
next prev parent reply other threads:[~2017-02-23 16:48 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-14 21:31 [PATCH] drm/rockchip: add extcon dependency for DP Arnd Bergmann
2017-02-14 21:31 ` Arnd Bergmann
2017-02-14 21:31 ` Arnd Bergmann
2017-02-14 22:06 ` Guenter Roeck
2017-02-14 22:06 ` Guenter Roeck
2017-02-15 1:06 ` Mark yao
2017-02-15 1:06 ` Mark yao
2017-02-15 1:06 ` Mark yao
2017-02-23 16:48 ` Sean Paul [this message]
2017-02-23 16:48 ` Sean Paul
2017-02-23 16:48 ` Sean Paul
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170223164841.GC24066@art_vandelay \
--to=seanpaul@chromium.org \
--cc=arnd@arndb.de \
--cc=daniel.vetter@ffwll.ch \
--cc=dri-devel@lists.freedesktop.org \
--cc=groeck@chromium.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rockchip@lists.infradead.org \
--cc=tjakobi@math.uni-bielefeld.de \
--cc=ykk@rock-chips.com \
--cc=zyw@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.