From: Andi Kleen <andi@firstfloor.org>
To: Pasha Tatashin <pasha.tatashin@oracle.com>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-mm@kvack.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH v2 1/3] sparc64: NG4 memset 32 bits overflow
Date: Wed, 01 Mar 2017 15:19:10 +0000 [thread overview]
Message-ID: <20170301151910.GH26852@two.firstfloor.org> (raw)
In-Reply-To: <70b638b0-8171-ffce-c0c5-bdcbae3c7c46@oracle.com>
> - Even if the default maximum size is reduced the size of these
> tables should still be tunable, as it really depends on the way
> machine is used, and in it is possible that for some use patterns
> large hash tables are necessary.
I consider it very unlikely that a 8G dentry hash table ever makes
sense. I cannot even imagine a workload where you would have that
many active files. It's just a bad configuration that should be avoided.
And when the tables are small enough you don't need these hacks.
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Pasha Tatashin <pasha.tatashin@oracle.com>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-mm@kvack.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH v2 1/3] sparc64: NG4 memset 32 bits overflow
Date: Wed, 1 Mar 2017 07:19:10 -0800 [thread overview]
Message-ID: <20170301151910.GH26852@two.firstfloor.org> (raw)
In-Reply-To: <70b638b0-8171-ffce-c0c5-bdcbae3c7c46@oracle.com>
> - Even if the default maximum size is reduced the size of these
> tables should still be tunable, as it really depends on the way
> machine is used, and in it is possible that for some use patterns
> large hash tables are necessary.
I consider it very unlikely that a 8G dentry hash table ever makes
sense. I cannot even imagine a workload where you would have that
many active files. It's just a bad configuration that should be avoided.
And when the tables are small enough you don't need these hacks.
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-01 15:19 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 0:14 [PATCH v2 0/3] Zeroing hash tables in allocator Pavel Tatashin
2017-03-01 0:14 ` Pavel Tatashin
2017-03-01 0:14 ` [PATCH v2 1/3] sparc64: NG4 memset 32 bits overflow Pavel Tatashin
2017-03-01 0:14 ` Pavel Tatashin
2017-03-01 0:24 ` Andi Kleen
2017-03-01 0:24 ` Andi Kleen
2017-03-01 14:51 ` Pasha Tatashin
2017-03-01 14:51 ` Pasha Tatashin
2017-03-01 15:19 ` Andi Kleen [this message]
2017-03-01 15:19 ` Andi Kleen
2017-03-01 16:34 ` Pasha Tatashin
2017-03-01 16:34 ` Pasha Tatashin
2017-03-01 17:31 ` Andi Kleen
2017-03-01 17:31 ` Andi Kleen
2017-03-01 21:20 ` Pasha Tatashin
2017-03-01 21:20 ` Pasha Tatashin
2017-03-01 23:10 ` Andi Kleen
2017-03-01 23:10 ` Andi Kleen
2017-03-02 19:15 ` Pasha Tatashin
2017-03-02 19:15 ` Pasha Tatashin
2017-03-02 0:12 ` Matthew Wilcox
2017-03-02 0:12 ` Matthew Wilcox
2017-03-01 0:14 ` [PATCH v2 2/3] mm: Zeroing hash tables in allocator Pavel Tatashin
2017-03-01 0:14 ` Pavel Tatashin
2017-03-01 0:14 ` [PATCH v2 3/3] mm: Updated callers to use HASH_ZERO flag Pavel Tatashin
2017-03-01 0:14 ` Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301151910.GH26852@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@oracle.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.