From: Andi Kleen <andi@firstfloor.org>
To: Pasha Tatashin <pasha.tatashin@oracle.com>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-mm@kvack.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH v2 1/3] sparc64: NG4 memset 32 bits overflow
Date: Wed, 01 Mar 2017 17:31:36 +0000 [thread overview]
Message-ID: <20170301173136.GI26852@two.firstfloor.org> (raw)
In-Reply-To: <6a26815d-0ec2-7922-7202-b1e17d58aa00@oracle.com>
On Wed, Mar 01, 2017 at 11:34:10AM -0500, Pasha Tatashin wrote:
> Hi Andi,
>
> Thank you for your comment, I am thinking to limit the default
> maximum hash tables sizes to 512M.
>
> If it is bigger than 512M, we would still need my patch to improve
Even 512MB seems too large. I wouldn't go larger than a few tens
of MB, maybe 32MB.
Also you would need to cover all the big hashes.
The most critical ones are likely the network hash tables, these
maybe be a bit larger (but certainly also not 0.5TB)
-Andi
WARNING: multiple messages have this Message-ID (diff)
From: Andi Kleen <andi@firstfloor.org>
To: Pasha Tatashin <pasha.tatashin@oracle.com>
Cc: Andi Kleen <andi@firstfloor.org>,
linux-mm@kvack.org, sparclinux@vger.kernel.org
Subject: Re: [PATCH v2 1/3] sparc64: NG4 memset 32 bits overflow
Date: Wed, 1 Mar 2017 09:31:36 -0800 [thread overview]
Message-ID: <20170301173136.GI26852@two.firstfloor.org> (raw)
In-Reply-To: <6a26815d-0ec2-7922-7202-b1e17d58aa00@oracle.com>
On Wed, Mar 01, 2017 at 11:34:10AM -0500, Pasha Tatashin wrote:
> Hi Andi,
>
> Thank you for your comment, I am thinking to limit the default
> maximum hash tables sizes to 512M.
>
> If it is bigger than 512M, we would still need my patch to improve
Even 512MB seems too large. I wouldn't go larger than a few tens
of MB, maybe 32MB.
Also you would need to cover all the big hashes.
The most critical ones are likely the network hash tables, these
maybe be a bit larger (but certainly also not 0.5TB)
-Andi
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2017-03-01 17:31 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-01 0:14 [PATCH v2 0/3] Zeroing hash tables in allocator Pavel Tatashin
2017-03-01 0:14 ` Pavel Tatashin
2017-03-01 0:14 ` [PATCH v2 1/3] sparc64: NG4 memset 32 bits overflow Pavel Tatashin
2017-03-01 0:14 ` Pavel Tatashin
2017-03-01 0:24 ` Andi Kleen
2017-03-01 0:24 ` Andi Kleen
2017-03-01 14:51 ` Pasha Tatashin
2017-03-01 14:51 ` Pasha Tatashin
2017-03-01 15:19 ` Andi Kleen
2017-03-01 15:19 ` Andi Kleen
2017-03-01 16:34 ` Pasha Tatashin
2017-03-01 16:34 ` Pasha Tatashin
2017-03-01 17:31 ` Andi Kleen [this message]
2017-03-01 17:31 ` Andi Kleen
2017-03-01 21:20 ` Pasha Tatashin
2017-03-01 21:20 ` Pasha Tatashin
2017-03-01 23:10 ` Andi Kleen
2017-03-01 23:10 ` Andi Kleen
2017-03-02 19:15 ` Pasha Tatashin
2017-03-02 19:15 ` Pasha Tatashin
2017-03-02 0:12 ` Matthew Wilcox
2017-03-02 0:12 ` Matthew Wilcox
2017-03-01 0:14 ` [PATCH v2 2/3] mm: Zeroing hash tables in allocator Pavel Tatashin
2017-03-01 0:14 ` Pavel Tatashin
2017-03-01 0:14 ` [PATCH v2 3/3] mm: Updated callers to use HASH_ZERO flag Pavel Tatashin
2017-03-01 0:14 ` Pavel Tatashin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301173136.GI26852@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=linux-mm@kvack.org \
--cc=pasha.tatashin@oracle.com \
--cc=sparclinux@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.