From: Minchan Kim <minchan@kernel.org>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
kernel-team@lge.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [RFC 04/11] mm: remove SWAP_MLOCK check for SWAP_SUCCESS in ttu
Date: Fri, 3 Mar 2017 12:04:16 +0900 [thread overview]
Message-ID: <20170303030416.GF3503@bbox> (raw)
In-Reply-To: <65fd1dd1-7ca4-6610-285c-09436879d8ed@linux.vnet.ibm.com>
On Thu, Mar 02, 2017 at 08:21:46PM +0530, Anshuman Khandual wrote:
> On 03/02/2017 12:09 PM, Minchan Kim wrote:
> > If the page is mapped and rescue in ttuo, page_mapcount(page) == 0 cannot
>
> Nit: "ttuo" is very cryptic. Please expand it.
No problem.
>
> > be true so page_mapcount check in ttu is enough to return SWAP_SUCCESS.
> > IOW, SWAP_MLOCK check is redundant so remove it.
>
> Right, page_mapcount(page) should be enough to tell whether swapping
> out happened successfully or the page is still mapped in some page
> table.
>
Thanks for the review, Anshuman!
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Minchan Kim <minchan@kernel.org>
To: Anshuman Khandual <khandual@linux.vnet.ibm.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
kernel-team@lge.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
Johannes Weiner <hannes@cmpxchg.org>,
Michal Hocko <mhocko@suse.com>
Subject: Re: [RFC 04/11] mm: remove SWAP_MLOCK check for SWAP_SUCCESS in ttu
Date: Fri, 3 Mar 2017 12:04:16 +0900 [thread overview]
Message-ID: <20170303030416.GF3503@bbox> (raw)
In-Reply-To: <65fd1dd1-7ca4-6610-285c-09436879d8ed@linux.vnet.ibm.com>
On Thu, Mar 02, 2017 at 08:21:46PM +0530, Anshuman Khandual wrote:
> On 03/02/2017 12:09 PM, Minchan Kim wrote:
> > If the page is mapped and rescue in ttuo, page_mapcount(page) == 0 cannot
>
> Nit: "ttuo" is very cryptic. Please expand it.
No problem.
>
> > be true so page_mapcount check in ttu is enough to return SWAP_SUCCESS.
> > IOW, SWAP_MLOCK check is redundant so remove it.
>
> Right, page_mapcount(page) should be enough to tell whether swapping
> out happened successfully or the page is still mapped in some page
> table.
>
Thanks for the review, Anshuman!
next prev parent reply other threads:[~2017-03-03 3:04 UTC|newest]
Thread overview: 98+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-02 6:39 [RFC 00/11] make try_to_unmap simple Minchan Kim
2017-03-02 6:39 ` Minchan Kim
2017-03-02 6:39 ` [RFC 01/11] mm: use SWAP_SUCCESS instead of 0 Minchan Kim
2017-03-02 6:39 ` Minchan Kim
2017-03-02 14:27 ` Anshuman Khandual
2017-03-02 14:27 ` Anshuman Khandual
2017-03-03 3:01 ` Minchan Kim
2017-03-03 3:01 ` Minchan Kim
2017-03-06 9:07 ` Anshuman Khandual
2017-03-06 9:07 ` Anshuman Khandual
2017-03-07 14:19 ` Kirill A. Shutemov
2017-03-07 14:19 ` Kirill A. Shutemov
2017-03-08 6:25 ` Minchan Kim
2017-03-08 6:25 ` Minchan Kim
2017-03-02 6:39 ` [RFC 02/11] mm: remove unncessary ret in page_referenced Minchan Kim
2017-03-02 6:39 ` Minchan Kim
2017-03-02 14:33 ` Anshuman Khandual
2017-03-02 14:33 ` Anshuman Khandual
2017-03-03 3:03 ` Minchan Kim
2017-03-03 3:03 ` Minchan Kim
2017-03-07 14:20 ` Kirill A. Shutemov
2017-03-07 14:20 ` Kirill A. Shutemov
2017-03-02 6:39 ` [RFC 03/11] mm: remove SWAP_DIRTY in ttu Minchan Kim
2017-03-02 6:39 ` Minchan Kim
2017-03-02 7:34 ` Hillf Danton
2017-03-02 7:34 ` Hillf Danton
2017-03-03 2:57 ` Minchan Kim
2017-03-03 2:57 ` Minchan Kim
2017-03-02 14:42 ` Anshuman Khandual
2017-03-02 14:42 ` Anshuman Khandual
2017-03-07 14:20 ` Kirill A. Shutemov
2017-03-07 14:20 ` Kirill A. Shutemov
2017-03-02 6:39 ` [RFC 04/11] mm: remove SWAP_MLOCK check for SWAP_SUCCESS " Minchan Kim
2017-03-02 6:39 ` Minchan Kim
2017-03-02 14:51 ` Anshuman Khandual
2017-03-02 14:51 ` Anshuman Khandual
2017-03-03 3:04 ` Minchan Kim [this message]
2017-03-03 3:04 ` Minchan Kim
2017-03-07 14:26 ` Kirill A. Shutemov
2017-03-07 14:26 ` Kirill A. Shutemov
2017-03-08 6:40 ` Minchan Kim
2017-03-08 6:40 ` Minchan Kim
2017-03-02 6:39 ` [RFC 05/11] mm: make the try_to_munlock void function Minchan Kim
2017-03-02 6:39 ` Minchan Kim
2017-03-03 11:43 ` Anshuman Khandual
2017-03-03 11:43 ` Anshuman Khandual
2017-03-06 2:09 ` Minchan Kim
2017-03-06 2:09 ` Minchan Kim
2017-03-06 9:40 ` Anshuman Khandual
2017-03-06 9:40 ` Anshuman Khandual
2017-03-07 6:50 ` Minchan Kim
2017-03-07 6:50 ` Minchan Kim
2017-03-07 8:55 ` Anshuman Khandual
2017-03-07 8:55 ` Anshuman Khandual
2017-03-07 15:17 ` Kirill A. Shutemov
2017-03-07 15:17 ` Kirill A. Shutemov
2017-03-08 6:41 ` Minchan Kim
2017-03-08 6:41 ` Minchan Kim
2017-03-02 6:39 ` [RFC 06/11] mm: remove SWAP_MLOCK in ttu Minchan Kim
2017-03-02 6:39 ` Minchan Kim
2017-03-03 12:36 ` Anshuman Khandual
2017-03-03 12:36 ` Anshuman Khandual
2017-03-06 2:15 ` Minchan Kim
2017-03-06 2:15 ` Minchan Kim
2017-03-07 15:24 ` Kirill A. Shutemov
2017-03-07 15:24 ` Kirill A. Shutemov
2017-03-08 6:42 ` Minchan Kim
2017-03-08 6:42 ` Minchan Kim
2017-03-02 6:39 ` [RFC 07/11] mm: remove SWAP_AGAIN " Minchan Kim
2017-03-02 6:39 ` Minchan Kim
2017-03-03 12:54 ` Anshuman Khandual
2017-03-03 12:54 ` Anshuman Khandual
2017-03-06 2:16 ` Minchan Kim
2017-03-06 2:16 ` Minchan Kim
2017-03-02 6:39 ` [RFC 08/11] mm: make ttu's return boolean Minchan Kim
2017-03-02 6:39 ` Minchan Kim
2017-03-08 7:13 ` John Hubbard
2017-03-08 7:13 ` John Hubbard
2017-03-09 6:37 ` Minchan Kim
2017-03-09 6:37 ` Minchan Kim
2017-03-09 6:46 ` John Hubbard
2017-03-09 6:46 ` John Hubbard
2017-03-02 6:39 ` [RFC 09/11] mm: make rmap_walk void function Minchan Kim
2017-03-02 6:39 ` Minchan Kim
2017-03-02 6:39 ` [RFC 10/11] mm: make rmap_one boolean function Minchan Kim
2017-03-02 6:39 ` Minchan Kim
2017-03-02 6:39 ` [RFC 11/11] mm: remove SWAP_[SUCCESS|AGAIN|FAIL] Minchan Kim
2017-03-02 6:39 ` Minchan Kim
2017-03-03 13:04 ` Anshuman Khandual
2017-03-03 13:04 ` Anshuman Khandual
2017-03-06 2:18 ` Minchan Kim
2017-03-06 2:18 ` Minchan Kim
2017-03-02 14:22 ` [RFC 00/11] make try_to_unmap simple Anshuman Khandual
2017-03-02 14:22 ` Anshuman Khandual
2017-03-03 2:11 ` Minchan Kim
2017-03-03 2:11 ` Minchan Kim
2017-03-03 5:39 ` Anshuman Khandual
2017-03-03 5:39 ` Anshuman Khandual
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170303030416.GF3503@bbox \
--to=minchan@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=kernel-team@lge.com \
--cc=khandual@linux.vnet.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.