* [PATCH 1/2] usb: xhci-mtk: check hcc_params after adding primary hcd
@ 2017-03-07 3:32 ` Chunfeng Yun
0 siblings, 0 replies; 20+ messages in thread
From: Chunfeng Yun @ 2017-03-07 3:32 UTC (permalink / raw)
To: Mathias Nyman
Cc: Matthias Brugger, Felipe Balbi, Chunfeng Yun, linux-kernel,
linux-arm-kernel, linux-usb, linux-mediatek, Greg Kroah-Hartman,
Thierry Reding
hcc_params is set in xhci_gen_setup() called from usb_add_hcd(),
so checks the Maximum Primary Stream Array Size in the hcc_params
register after adding primary hcd.
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
drivers/usb/host/xhci-mtk.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
index 9066ec9..6ac73a6 100644
--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c
@@ -678,13 +678,13 @@ static int xhci_mtk_probe(struct platform_device *pdev)
goto power_off_phys;
}
- if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
- xhci->shared_hcd->can_do_streams = 1;
-
ret = usb_add_hcd(hcd, irq, IRQF_SHARED);
if (ret)
goto put_usb3_hcd;
+ if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
+ xhci->shared_hcd->can_do_streams = 1;
+
ret = usb_add_hcd(xhci->shared_hcd, irq, IRQF_SHARED);
if (ret)
goto dealloc_usb2_hcd;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 1/2] usb: xhci-mtk: check hcc_params after adding primary hcd
@ 2017-03-07 3:32 ` Chunfeng Yun
0 siblings, 0 replies; 20+ messages in thread
From: Chunfeng Yun @ 2017-03-07 3:32 UTC (permalink / raw)
To: linux-arm-kernel
hcc_params is set in xhci_gen_setup() called from usb_add_hcd(),
so checks the Maximum Primary Stream Array Size in the hcc_params
register after adding primary hcd.
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
drivers/usb/host/xhci-mtk.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
index 9066ec9..6ac73a6 100644
--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c
@@ -678,13 +678,13 @@ static int xhci_mtk_probe(struct platform_device *pdev)
goto power_off_phys;
}
- if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
- xhci->shared_hcd->can_do_streams = 1;
-
ret = usb_add_hcd(hcd, irq, IRQF_SHARED);
if (ret)
goto put_usb3_hcd;
+ if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
+ xhci->shared_hcd->can_do_streams = 1;
+
ret = usb_add_hcd(xhci->shared_hcd, irq, IRQF_SHARED);
if (ret)
goto dealloc_usb2_hcd;
--
1.7.9.5
^ permalink raw reply related [flat|nested] 20+ messages in thread
* [PATCH 2/2] usb: xhci: remove dummy extra_priv_size for size of xhci_hcd struct
2017-03-07 3:32 ` Chunfeng Yun
(?)
@ 2017-03-07 3:32 ` Chunfeng Yun
-1 siblings, 0 replies; 20+ messages in thread
From: Chunfeng Yun @ 2017-03-07 3:32 UTC (permalink / raw)
To: Mathias Nyman
Cc: Matthias Brugger, Felipe Balbi, Chunfeng Yun, linux-kernel,
linux-arm-kernel, linux-usb, linux-mediatek, Greg Kroah-Hartman,
Thierry Reding
because hcd_priv_size is already size of xhci_hcd struct,
extra_priv_size is not needed anymore for MTK and tegra drivers.
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
drivers/usb/host/xhci-mtk.c | 1 -
drivers/usb/host/xhci-tegra.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
index 6ac73a6..67d5dc7 100644
--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c
@@ -382,7 +382,6 @@ static int usb_wakeup_of_property_parse(struct xhci_hcd_mtk *mtk,
static int xhci_mtk_setup(struct usb_hcd *hcd);
static const struct xhci_driver_overrides xhci_mtk_overrides __initconst = {
- .extra_priv_size = sizeof(struct xhci_hcd),
.reset = xhci_mtk_setup,
};
diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c
index a59fafb..74436f8 100644
--- a/drivers/usb/host/xhci-tegra.c
+++ b/drivers/usb/host/xhci-tegra.c
@@ -1308,7 +1308,6 @@ static int tegra_xhci_setup(struct usb_hcd *hcd)
}
static const struct xhci_driver_overrides tegra_xhci_overrides __initconst = {
- .extra_priv_size = sizeof(struct xhci_hcd),
.reset = tegra_xhci_setup,
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH 2/2] usb: xhci: remove dummy extra_priv_size for size of xhci_hcd struct
@ 2017-03-07 3:32 ` Chunfeng Yun
0 siblings, 0 replies; 20+ messages in thread
From: Chunfeng Yun @ 2017-03-07 3:32 UTC (permalink / raw)
To: Mathias Nyman
Cc: Matthias Brugger, Felipe Balbi, Chunfeng Yun, linux-kernel,
linux-arm-kernel, linux-usb, linux-mediatek, Greg Kroah-Hartman,
Thierry Reding
because hcd_priv_size is already size of xhci_hcd struct,
extra_priv_size is not needed anymore for MTK and tegra drivers.
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
drivers/usb/host/xhci-mtk.c | 1 -
drivers/usb/host/xhci-tegra.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
index 6ac73a6..67d5dc7 100644
--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c
@@ -382,7 +382,6 @@ static int usb_wakeup_of_property_parse(struct xhci_hcd_mtk *mtk,
static int xhci_mtk_setup(struct usb_hcd *hcd);
static const struct xhci_driver_overrides xhci_mtk_overrides __initconst = {
- .extra_priv_size = sizeof(struct xhci_hcd),
.reset = xhci_mtk_setup,
};
diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c
index a59fafb..74436f8 100644
--- a/drivers/usb/host/xhci-tegra.c
+++ b/drivers/usb/host/xhci-tegra.c
@@ -1308,7 +1308,6 @@ static int tegra_xhci_setup(struct usb_hcd *hcd)
}
static const struct xhci_driver_overrides tegra_xhci_overrides __initconst = {
- .extra_priv_size = sizeof(struct xhci_hcd),
.reset = tegra_xhci_setup,
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 20+ messages in thread* [PATCH 2/2] usb: xhci: remove dummy extra_priv_size for size of xhci_hcd struct
@ 2017-03-07 3:32 ` Chunfeng Yun
0 siblings, 0 replies; 20+ messages in thread
From: Chunfeng Yun @ 2017-03-07 3:32 UTC (permalink / raw)
To: linux-arm-kernel
because hcd_priv_size is already size of xhci_hcd struct,
extra_priv_size is not needed anymore for MTK and tegra drivers.
Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
---
drivers/usb/host/xhci-mtk.c | 1 -
drivers/usb/host/xhci-tegra.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
index 6ac73a6..67d5dc7 100644
--- a/drivers/usb/host/xhci-mtk.c
+++ b/drivers/usb/host/xhci-mtk.c
@@ -382,7 +382,6 @@ static int usb_wakeup_of_property_parse(struct xhci_hcd_mtk *mtk,
static int xhci_mtk_setup(struct usb_hcd *hcd);
static const struct xhci_driver_overrides xhci_mtk_overrides __initconst = {
- .extra_priv_size = sizeof(struct xhci_hcd),
.reset = xhci_mtk_setup,
};
diff --git a/drivers/usb/host/xhci-tegra.c b/drivers/usb/host/xhci-tegra.c
index a59fafb..74436f8 100644
--- a/drivers/usb/host/xhci-tegra.c
+++ b/drivers/usb/host/xhci-tegra.c
@@ -1308,7 +1308,6 @@ static int tegra_xhci_setup(struct usb_hcd *hcd)
}
static const struct xhci_driver_overrides tegra_xhci_overrides __initconst = {
- .extra_priv_size = sizeof(struct xhci_hcd),
.reset = tegra_xhci_setup,
};
--
1.7.9.5
^ permalink raw reply related [flat|nested] 20+ messages in thread* Re: [PATCH 2/2] usb: xhci: remove dummy extra_priv_size for size of xhci_hcd struct
2017-03-07 3:32 ` Chunfeng Yun
(?)
@ 2017-03-07 11:02 ` Thierry Reding
-1 siblings, 0 replies; 20+ messages in thread
From: Thierry Reding @ 2017-03-07 11:02 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Mathias Nyman, Felipe Balbi, Greg Kroah-Hartman, linux-usb,
linux-kernel, linux-mediatek, Matthias Brugger, linux-arm-kernel
[-- Attachment #1.1: Type: text/plain, Size: 495 bytes --]
On Tue, Mar 07, 2017 at 11:32:23AM +0800, Chunfeng Yun wrote:
> because hcd_priv_size is already size of xhci_hcd struct,
> extra_priv_size is not needed anymore for MTK and tegra drivers.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> drivers/usb/host/xhci-mtk.c | 1 -
> drivers/usb/host/xhci-tegra.c | 1 -
> 2 files changed, 2 deletions(-)
For Tegra:
Tested-by: Thierry Reding <treding@nvidia.com>
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #1.2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
[-- Attachment #2: Type: text/plain, Size: 176 bytes --]
_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 2/2] usb: xhci: remove dummy extra_priv_size for size of xhci_hcd struct
@ 2017-03-07 11:02 ` Thierry Reding
0 siblings, 0 replies; 20+ messages in thread
From: Thierry Reding @ 2017-03-07 11:02 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Mathias Nyman, Matthias Brugger, Felipe Balbi, linux-kernel,
linux-arm-kernel, linux-usb, linux-mediatek, Greg Kroah-Hartman
[-- Attachment #1: Type: text/plain, Size: 495 bytes --]
On Tue, Mar 07, 2017 at 11:32:23AM +0800, Chunfeng Yun wrote:
> because hcd_priv_size is already size of xhci_hcd struct,
> extra_priv_size is not needed anymore for MTK and tegra drivers.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> drivers/usb/host/xhci-mtk.c | 1 -
> drivers/usb/host/xhci-tegra.c | 1 -
> 2 files changed, 2 deletions(-)
For Tegra:
Tested-by: Thierry Reding <treding@nvidia.com>
Acked-by: Thierry Reding <treding@nvidia.com>
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 2/2] usb: xhci: remove dummy extra_priv_size for size of xhci_hcd struct
@ 2017-03-07 11:02 ` Thierry Reding
0 siblings, 0 replies; 20+ messages in thread
From: Thierry Reding @ 2017-03-07 11:02 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, Mar 07, 2017 at 11:32:23AM +0800, Chunfeng Yun wrote:
> because hcd_priv_size is already size of xhci_hcd struct,
> extra_priv_size is not needed anymore for MTK and tegra drivers.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> drivers/usb/host/xhci-mtk.c | 1 -
> drivers/usb/host/xhci-tegra.c | 1 -
> 2 files changed, 2 deletions(-)
For Tegra:
Tested-by: Thierry Reding <treding@nvidia.com>
Acked-by: Thierry Reding <treding@nvidia.com>
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 833 bytes
Desc: not available
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20170307/e812618a/attachment.sig>
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 2/2] usb: xhci: remove dummy extra_priv_size for size of xhci_hcd struct
2017-03-07 11:02 ` Thierry Reding
(?)
@ 2017-03-07 15:12 ` Mathias Nyman
-1 siblings, 0 replies; 20+ messages in thread
From: Mathias Nyman @ 2017-03-07 15:12 UTC (permalink / raw)
To: Thierry Reding, Chunfeng Yun
Cc: Mathias Nyman, Felipe Balbi, Greg Kroah-Hartman, linux-usb,
linux-kernel, linux-mediatek, Matthias Brugger, linux-arm-kernel
On 07.03.2017 13:02, Thierry Reding wrote:
> On Tue, Mar 07, 2017 at 11:32:23AM +0800, Chunfeng Yun wrote:
>> because hcd_priv_size is already size of xhci_hcd struct,
>> extra_priv_size is not needed anymore for MTK and tegra drivers.
>>
>> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
>> ---
>> drivers/usb/host/xhci-mtk.c | 1 -
>> drivers/usb/host/xhci-tegra.c | 1 -
>> 2 files changed, 2 deletions(-)
>
Nice catch, thanks.
queued.
> For Tegra:
>
> Tested-by: Thierry Reding <treding@nvidia.com>
> Acked-by: Thierry Reding <treding@nvidia.com>
>
adding tags
-Mathias
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 2/2] usb: xhci: remove dummy extra_priv_size for size of xhci_hcd struct
@ 2017-03-07 15:12 ` Mathias Nyman
0 siblings, 0 replies; 20+ messages in thread
From: Mathias Nyman @ 2017-03-07 15:12 UTC (permalink / raw)
To: Thierry Reding, Chunfeng Yun
Cc: Mathias Nyman, Matthias Brugger, Felipe Balbi, linux-kernel,
linux-arm-kernel, linux-usb, linux-mediatek, Greg Kroah-Hartman
On 07.03.2017 13:02, Thierry Reding wrote:
> On Tue, Mar 07, 2017 at 11:32:23AM +0800, Chunfeng Yun wrote:
>> because hcd_priv_size is already size of xhci_hcd struct,
>> extra_priv_size is not needed anymore for MTK and tegra drivers.
>>
>> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
>> ---
>> drivers/usb/host/xhci-mtk.c | 1 -
>> drivers/usb/host/xhci-tegra.c | 1 -
>> 2 files changed, 2 deletions(-)
>
Nice catch, thanks.
queued.
> For Tegra:
>
> Tested-by: Thierry Reding <treding@nvidia.com>
> Acked-by: Thierry Reding <treding@nvidia.com>
>
adding tags
-Mathias
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 2/2] usb: xhci: remove dummy extra_priv_size for size of xhci_hcd struct
@ 2017-03-07 15:12 ` Mathias Nyman
0 siblings, 0 replies; 20+ messages in thread
From: Mathias Nyman @ 2017-03-07 15:12 UTC (permalink / raw)
To: linux-arm-kernel
On 07.03.2017 13:02, Thierry Reding wrote:
> On Tue, Mar 07, 2017 at 11:32:23AM +0800, Chunfeng Yun wrote:
>> because hcd_priv_size is already size of xhci_hcd struct,
>> extra_priv_size is not needed anymore for MTK and tegra drivers.
>>
>> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
>> ---
>> drivers/usb/host/xhci-mtk.c | 1 -
>> drivers/usb/host/xhci-tegra.c | 1 -
>> 2 files changed, 2 deletions(-)
>
Nice catch, thanks.
queued.
> For Tegra:
>
> Tested-by: Thierry Reding <treding@nvidia.com>
> Acked-by: Thierry Reding <treding@nvidia.com>
>
adding tags
-Mathias
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/2] usb: xhci-mtk: check hcc_params after adding primary hcd
2017-03-07 3:32 ` Chunfeng Yun
(?)
@ 2017-03-07 15:10 ` Mathias Nyman
-1 siblings, 0 replies; 20+ messages in thread
From: Mathias Nyman @ 2017-03-07 15:10 UTC (permalink / raw)
To: Chunfeng Yun, Mathias Nyman
Cc: Felipe Balbi, Greg Kroah-Hartman, linux-usb, linux-kernel,
linux-mediatek, Matthias Brugger, Thierry Reding,
linux-arm-kernel
On 07.03.2017 05:32, Chunfeng Yun wrote:
> hcc_params is set in xhci_gen_setup() called from usb_add_hcd(),
> so checks the Maximum Primary Stream Array Size in the hcc_params
> register after adding primary hcd.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> drivers/usb/host/xhci-mtk.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
> index 9066ec9..6ac73a6 100644
> --- a/drivers/usb/host/xhci-mtk.c
> +++ b/drivers/usb/host/xhci-mtk.c
> @@ -678,13 +678,13 @@ static int xhci_mtk_probe(struct platform_device *pdev)
> goto power_off_phys;
> }
>
> - if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
> - xhci->shared_hcd->can_do_streams = 1;
> -
> ret = usb_add_hcd(hcd, irq, IRQF_SHARED);
> if (ret)
> goto put_usb3_hcd;
>
> + if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
> + xhci->shared_hcd->can_do_streams = 1;
> +
> ret = usb_add_hcd(xhci->shared_hcd, irq, IRQF_SHARED);
> if (ret)
> goto dealloc_usb2_hcd;
>
Thanks.
Looks like streams check has never worked for Mediatek xHC hosts,
Do you know if this has caused any issues?
looks like it should go usb-linus and maybe stable kernels as well.
-Mathias
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/2] usb: xhci-mtk: check hcc_params after adding primary hcd
@ 2017-03-07 15:10 ` Mathias Nyman
0 siblings, 0 replies; 20+ messages in thread
From: Mathias Nyman @ 2017-03-07 15:10 UTC (permalink / raw)
To: Chunfeng Yun, Mathias Nyman
Cc: Matthias Brugger, Felipe Balbi, linux-kernel, linux-arm-kernel,
linux-usb, linux-mediatek, Greg Kroah-Hartman, Thierry Reding
On 07.03.2017 05:32, Chunfeng Yun wrote:
> hcc_params is set in xhci_gen_setup() called from usb_add_hcd(),
> so checks the Maximum Primary Stream Array Size in the hcc_params
> register after adding primary hcd.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> drivers/usb/host/xhci-mtk.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
> index 9066ec9..6ac73a6 100644
> --- a/drivers/usb/host/xhci-mtk.c
> +++ b/drivers/usb/host/xhci-mtk.c
> @@ -678,13 +678,13 @@ static int xhci_mtk_probe(struct platform_device *pdev)
> goto power_off_phys;
> }
>
> - if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
> - xhci->shared_hcd->can_do_streams = 1;
> -
> ret = usb_add_hcd(hcd, irq, IRQF_SHARED);
> if (ret)
> goto put_usb3_hcd;
>
> + if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
> + xhci->shared_hcd->can_do_streams = 1;
> +
> ret = usb_add_hcd(xhci->shared_hcd, irq, IRQF_SHARED);
> if (ret)
> goto dealloc_usb2_hcd;
>
Thanks.
Looks like streams check has never worked for Mediatek xHC hosts,
Do you know if this has caused any issues?
looks like it should go usb-linus and maybe stable kernels as well.
-Mathias
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 1/2] usb: xhci-mtk: check hcc_params after adding primary hcd
@ 2017-03-07 15:10 ` Mathias Nyman
0 siblings, 0 replies; 20+ messages in thread
From: Mathias Nyman @ 2017-03-07 15:10 UTC (permalink / raw)
To: linux-arm-kernel
On 07.03.2017 05:32, Chunfeng Yun wrote:
> hcc_params is set in xhci_gen_setup() called from usb_add_hcd(),
> so checks the Maximum Primary Stream Array Size in the hcc_params
> register after adding primary hcd.
>
> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> ---
> drivers/usb/host/xhci-mtk.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
> index 9066ec9..6ac73a6 100644
> --- a/drivers/usb/host/xhci-mtk.c
> +++ b/drivers/usb/host/xhci-mtk.c
> @@ -678,13 +678,13 @@ static int xhci_mtk_probe(struct platform_device *pdev)
> goto power_off_phys;
> }
>
> - if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
> - xhci->shared_hcd->can_do_streams = 1;
> -
> ret = usb_add_hcd(hcd, irq, IRQF_SHARED);
> if (ret)
> goto put_usb3_hcd;
>
> + if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
> + xhci->shared_hcd->can_do_streams = 1;
> +
> ret = usb_add_hcd(xhci->shared_hcd, irq, IRQF_SHARED);
> if (ret)
> goto dealloc_usb2_hcd;
>
Thanks.
Looks like streams check has never worked for Mediatek xHC hosts,
Do you know if this has caused any issues?
looks like it should go usb-linus and maybe stable kernels as well.
-Mathias
^ permalink raw reply [flat|nested] 20+ messages in thread
[parent not found: <58BECD83.9000205-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>]
* Re: [PATCH 1/2] usb: xhci-mtk: check hcc_params after adding primary hcd
2017-03-07 15:10 ` Mathias Nyman
(?)
@ 2017-03-08 0:51 ` Chunfeng Yun
-1 siblings, 0 replies; 20+ messages in thread
From: Chunfeng Yun @ 2017-03-08 0:51 UTC (permalink / raw)
To: Mathias Nyman
Cc: Mathias Nyman, Felipe Balbi, Greg Kroah-Hartman,
linux-usb-u79uwXL29TY76Z2rM5mHXA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA,
linux-mediatek-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r, Matthias Brugger,
Thierry Reding, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r
On Tue, 2017-03-07 at 17:10 +0200, Mathias Nyman wrote:
> On 07.03.2017 05:32, Chunfeng Yun wrote:
> > hcc_params is set in xhci_gen_setup() called from usb_add_hcd(),
> > so checks the Maximum Primary Stream Array Size in the hcc_params
> > register after adding primary hcd.
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun-NuS5LvNUpcJWk0Htik3J/w@public.gmane.org>
> > ---
> > drivers/usb/host/xhci-mtk.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
> > index 9066ec9..6ac73a6 100644
> > --- a/drivers/usb/host/xhci-mtk.c
> > +++ b/drivers/usb/host/xhci-mtk.c
> > @@ -678,13 +678,13 @@ static int xhci_mtk_probe(struct platform_device *pdev)
> > goto power_off_phys;
> > }
> >
> > - if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
> > - xhci->shared_hcd->can_do_streams = 1;
> > -
> > ret = usb_add_hcd(hcd, irq, IRQF_SHARED);
> > if (ret)
> > goto put_usb3_hcd;
> >
> > + if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
> > + xhci->shared_hcd->can_do_streams = 1;
> > +
> > ret = usb_add_hcd(xhci->shared_hcd, irq, IRQF_SHARED);
> > if (ret)
> > goto dealloc_usb2_hcd;
> >
>
> Thanks.
> Looks like streams check has never worked for Mediatek xHC hosts,
>
> Do you know if this has caused any issues?
> looks like it should go usb-linus and maybe stable kernels as well.
No issues on mt8173, because it doesn't support bulk stream. But it
causes a issue on the newest SoC which is not upstreamed, so I think it
needn't go stable kernels.
Thank you.
>
> -Mathias
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/2] usb: xhci-mtk: check hcc_params after adding primary hcd
@ 2017-03-08 0:51 ` Chunfeng Yun
0 siblings, 0 replies; 20+ messages in thread
From: Chunfeng Yun @ 2017-03-08 0:51 UTC (permalink / raw)
To: Mathias Nyman
Cc: Mathias Nyman, Matthias Brugger, Felipe Balbi, linux-kernel,
linux-arm-kernel, linux-usb, linux-mediatek, Greg Kroah-Hartman,
Thierry Reding
On Tue, 2017-03-07 at 17:10 +0200, Mathias Nyman wrote:
> On 07.03.2017 05:32, Chunfeng Yun wrote:
> > hcc_params is set in xhci_gen_setup() called from usb_add_hcd(),
> > so checks the Maximum Primary Stream Array Size in the hcc_params
> > register after adding primary hcd.
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > drivers/usb/host/xhci-mtk.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
> > index 9066ec9..6ac73a6 100644
> > --- a/drivers/usb/host/xhci-mtk.c
> > +++ b/drivers/usb/host/xhci-mtk.c
> > @@ -678,13 +678,13 @@ static int xhci_mtk_probe(struct platform_device *pdev)
> > goto power_off_phys;
> > }
> >
> > - if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
> > - xhci->shared_hcd->can_do_streams = 1;
> > -
> > ret = usb_add_hcd(hcd, irq, IRQF_SHARED);
> > if (ret)
> > goto put_usb3_hcd;
> >
> > + if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
> > + xhci->shared_hcd->can_do_streams = 1;
> > +
> > ret = usb_add_hcd(xhci->shared_hcd, irq, IRQF_SHARED);
> > if (ret)
> > goto dealloc_usb2_hcd;
> >
>
> Thanks.
> Looks like streams check has never worked for Mediatek xHC hosts,
>
> Do you know if this has caused any issues?
> looks like it should go usb-linus and maybe stable kernels as well.
No issues on mt8173, because it doesn't support bulk stream. But it
causes a issue on the newest SoC which is not upstreamed, so I think it
needn't go stable kernels.
Thank you.
>
> -Mathias
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 1/2] usb: xhci-mtk: check hcc_params after adding primary hcd
@ 2017-03-08 0:51 ` Chunfeng Yun
0 siblings, 0 replies; 20+ messages in thread
From: Chunfeng Yun @ 2017-03-08 0:51 UTC (permalink / raw)
To: linux-arm-kernel
On Tue, 2017-03-07 at 17:10 +0200, Mathias Nyman wrote:
> On 07.03.2017 05:32, Chunfeng Yun wrote:
> > hcc_params is set in xhci_gen_setup() called from usb_add_hcd(),
> > so checks the Maximum Primary Stream Array Size in the hcc_params
> > register after adding primary hcd.
> >
> > Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
> > ---
> > drivers/usb/host/xhci-mtk.c | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/usb/host/xhci-mtk.c b/drivers/usb/host/xhci-mtk.c
> > index 9066ec9..6ac73a6 100644
> > --- a/drivers/usb/host/xhci-mtk.c
> > +++ b/drivers/usb/host/xhci-mtk.c
> > @@ -678,13 +678,13 @@ static int xhci_mtk_probe(struct platform_device *pdev)
> > goto power_off_phys;
> > }
> >
> > - if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
> > - xhci->shared_hcd->can_do_streams = 1;
> > -
> > ret = usb_add_hcd(hcd, irq, IRQF_SHARED);
> > if (ret)
> > goto put_usb3_hcd;
> >
> > + if (HCC_MAX_PSA(xhci->hcc_params) >= 4)
> > + xhci->shared_hcd->can_do_streams = 1;
> > +
> > ret = usb_add_hcd(xhci->shared_hcd, irq, IRQF_SHARED);
> > if (ret)
> > goto dealloc_usb2_hcd;
> >
>
> Thanks.
> Looks like streams check has never worked for Mediatek xHC hosts,
>
> Do you know if this has caused any issues?
> looks like it should go usb-linus and maybe stable kernels as well.
No issues on mt8173, because it doesn't support bulk stream. But it
causes a issue on the newest SoC which is not upstreamed, so I think it
needn't go stable kernels.
Thank you.
>
> -Mathias
^ permalink raw reply [flat|nested] 20+ messages in thread
* Re: [PATCH 1/2] usb: xhci-mtk: check hcc_params after adding primary hcd
2017-03-08 0:51 ` Chunfeng Yun
@ 2017-03-08 11:08 ` Mathias Nyman
-1 siblings, 0 replies; 20+ messages in thread
From: Mathias Nyman @ 2017-03-08 11:08 UTC (permalink / raw)
To: Chunfeng Yun
Cc: Mathias Nyman, Matthias Brugger, Felipe Balbi, linux-kernel,
linux-arm-kernel, linux-usb, linux-mediatek, Greg Kroah-Hartman,
Thierry Reding
On 08.03.2017 02:51, Chunfeng Yun wrote:
> On Tue, 2017-03-07 at 17:10 +0200, Mathias Nyman wrote:
>> On 07.03.2017 05:32, Chunfeng Yun wrote:
>>> hcc_params is set in xhci_gen_setup() called from usb_add_hcd(),
>>> so checks the Maximum Primary Stream Array Size in the hcc_params
>>> register after adding primary hcd.
>>>
>>> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
>>
>> Thanks.
>> Looks like streams check has never worked for Mediatek xHC hosts,
>>
>> Do you know if this has caused any issues?
>> looks like it should go usb-linus and maybe stable kernels as well.
> No issues on mt8173, because it doesn't support bulk stream. But it
> causes a issue on the newest SoC which is not upstreamed, so I think it
> needn't go stable kernels.
>
Ok, thanks, skipping stable
-Mathias
^ permalink raw reply [flat|nested] 20+ messages in thread
* [PATCH 1/2] usb: xhci-mtk: check hcc_params after adding primary hcd
@ 2017-03-08 11:08 ` Mathias Nyman
0 siblings, 0 replies; 20+ messages in thread
From: Mathias Nyman @ 2017-03-08 11:08 UTC (permalink / raw)
To: linux-arm-kernel
On 08.03.2017 02:51, Chunfeng Yun wrote:
> On Tue, 2017-03-07 at 17:10 +0200, Mathias Nyman wrote:
>> On 07.03.2017 05:32, Chunfeng Yun wrote:
>>> hcc_params is set in xhci_gen_setup() called from usb_add_hcd(),
>>> so checks the Maximum Primary Stream Array Size in the hcc_params
>>> register after adding primary hcd.
>>>
>>> Signed-off-by: Chunfeng Yun <chunfeng.yun@mediatek.com>
>>
>> Thanks.
>> Looks like streams check has never worked for Mediatek xHC hosts,
>>
>> Do you know if this has caused any issues?
>> looks like it should go usb-linus and maybe stable kernels as well.
> No issues on mt8173, because it doesn't support bulk stream. But it
> causes a issue on the newest SoC which is not upstreamed, so I think it
> needn't go stable kernels.
>
Ok, thanks, skipping stable
-Mathias
^ permalink raw reply [flat|nested] 20+ messages in thread