All of lore.kernel.org
 help / color / mirror / Atom feed
From: andrew@lunn.ch (Andrew Lunn)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] usb: host: Allow to build ehci orion with mvebu SoCs
Date: Wed, 8 Mar 2017 18:01:36 +0100	[thread overview]
Message-ID: <20170308170136.GC32355@lunn.ch> (raw)
In-Reply-To: <20170308162423.25553-3-gregory.clement@free-electrons.com>

On Wed, Mar 08, 2017 at 05:24:22PM +0100, Gregory CLEMENT wrote:
> The mvebu ARM64 SoCs no more select PLAT_ORION but some of them as the
> Armada 37xx use the EHCI orion controller. This patch allow to build
> the driver when ARCH_MVEBU is selected.

The mvebu ARM64 SoCs no longer selects PLAT_ORION.  However Armada
37xx use the Orion EHCI controller. This patch allows the Orion EHCI
driver to be built when ARCH_MVEBU is selected.

> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
>  drivers/usb/host/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 407d947b34ea..870c42d89298 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -188,7 +188,7 @@ config USB_EHCI_HCD_OMAP
>  
>  config USB_EHCI_HCD_ORION
>  	tristate  "Support for Marvell EBU on-chip EHCI USB controller"
> -	depends on USB_EHCI_HCD && PLAT_ORION
> +	depends on USB_EHCI_HCD && PLAT_ORION || ARCH_MVEBU

I don't know the Kconfig language too well. Should this be:

> +	depends on USB_EHCI_HCD && (PLAT_ORION || ARCH_MVEBU)

  Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	devicetree@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	Rob Herring <robh+dt@kernel.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	linux-arm-kernel@lists.infradead.org,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 2/3] usb: host: Allow to build ehci orion with mvebu SoCs
Date: Wed, 8 Mar 2017 18:01:36 +0100	[thread overview]
Message-ID: <20170308170136.GC32355@lunn.ch> (raw)
In-Reply-To: <20170308162423.25553-3-gregory.clement@free-electrons.com>

On Wed, Mar 08, 2017 at 05:24:22PM +0100, Gregory CLEMENT wrote:
> The mvebu ARM64 SoCs no more select PLAT_ORION but some of them as the
> Armada 37xx use the EHCI orion controller. This patch allow to build
> the driver when ARCH_MVEBU is selected.

The mvebu ARM64 SoCs no longer selects PLAT_ORION.  However Armada
37xx use the Orion EHCI controller. This patch allows the Orion EHCI
driver to be built when ARCH_MVEBU is selected.

> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
>  drivers/usb/host/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 407d947b34ea..870c42d89298 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -188,7 +188,7 @@ config USB_EHCI_HCD_OMAP
>  
>  config USB_EHCI_HCD_ORION
>  	tristate  "Support for Marvell EBU on-chip EHCI USB controller"
> -	depends on USB_EHCI_HCD && PLAT_ORION
> +	depends on USB_EHCI_HCD && PLAT_ORION || ARCH_MVEBU

I don't know the Kconfig language too well. Should this be:

> +	depends on USB_EHCI_HCD && (PLAT_ORION || ARCH_MVEBU)

  Andrew

WARNING: multiple messages have this Message-ID (diff)
From: Andrew Lunn <andrew@lunn.ch>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Alan Stern <stern@rowland.harvard.edu>,
	linux-usb@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
	Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
	Rob Herring <robh+dt@kernel.org>,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
	linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] usb: host: Allow to build ehci orion with mvebu SoCs
Date: Wed, 8 Mar 2017 18:01:36 +0100	[thread overview]
Message-ID: <20170308170136.GC32355@lunn.ch> (raw)
In-Reply-To: <20170308162423.25553-3-gregory.clement@free-electrons.com>

On Wed, Mar 08, 2017 at 05:24:22PM +0100, Gregory CLEMENT wrote:
> The mvebu ARM64 SoCs no more select PLAT_ORION but some of them as the
> Armada 37xx use the EHCI orion controller. This patch allow to build
> the driver when ARCH_MVEBU is selected.

The mvebu ARM64 SoCs no longer selects PLAT_ORION.  However Armada
37xx use the Orion EHCI controller. This patch allows the Orion EHCI
driver to be built when ARCH_MVEBU is selected.

> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> ---
>  drivers/usb/host/Kconfig | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
> index 407d947b34ea..870c42d89298 100644
> --- a/drivers/usb/host/Kconfig
> +++ b/drivers/usb/host/Kconfig
> @@ -188,7 +188,7 @@ config USB_EHCI_HCD_OMAP
>  
>  config USB_EHCI_HCD_ORION
>  	tristate  "Support for Marvell EBU on-chip EHCI USB controller"
> -	depends on USB_EHCI_HCD && PLAT_ORION
> +	depends on USB_EHCI_HCD && PLAT_ORION || ARCH_MVEBU

I don't know the Kconfig language too well. Should this be:

> +	depends on USB_EHCI_HCD && (PLAT_ORION || ARCH_MVEBU)

  Andrew

  reply	other threads:[~2017-03-08 17:01 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-08 16:24 [PATCH 0/3] Add EHCI support for Armada 37xx Gregory CLEMENT
2017-03-08 16:24 ` Gregory CLEMENT
2017-03-08 16:24 ` Gregory CLEMENT
2017-03-08 16:24 ` [PATCH 1/3] usb: orion-echi: Add support for the Armada 3700 Gregory CLEMENT
2017-03-08 16:24   ` Gregory CLEMENT
2017-03-08 16:56   ` Andrew Lunn
2017-03-08 16:56     ` Andrew Lunn
2017-03-08 16:56     ` Andrew Lunn
2017-03-08 17:21     ` Gregory CLEMENT
2017-03-08 17:21       ` Gregory CLEMENT
2017-03-08 17:21       ` Gregory CLEMENT
2017-03-08 20:07   ` Thomas Petazzoni
2017-03-08 20:07     ` Thomas Petazzoni
2017-03-08 20:07     ` Thomas Petazzoni
2017-03-08 16:24 ` [PATCH 2/3] usb: host: Allow to build ehci orion with mvebu SoCs Gregory CLEMENT
2017-03-08 16:24   ` Gregory CLEMENT
2017-03-08 16:24   ` Gregory CLEMENT
2017-03-08 17:01   ` Andrew Lunn [this message]
2017-03-08 17:01     ` Andrew Lunn
2017-03-08 17:01     ` Andrew Lunn
2017-03-08 17:24     ` Gregory CLEMENT
2017-03-08 17:24       ` Gregory CLEMENT
2017-03-08 17:24       ` Gregory CLEMENT
2017-03-08 16:24 ` [PATCH 3/3] ARM64: dts: marvell: armada-37xx: Add USB2 node Gregory CLEMENT
2017-03-08 16:24   ` Gregory CLEMENT
2017-03-08 16:24   ` Gregory CLEMENT

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170308170136.GC32355@lunn.ch \
    --to=andrew@lunn.ch \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.