From: gregory.clement@free-electrons.com (Gregory CLEMENT)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] usb: host: Allow to build ehci orion with mvebu SoCs
Date: Wed, 08 Mar 2017 18:24:15 +0100 [thread overview]
Message-ID: <87o9xblm0w.fsf@free-electrons.com> (raw)
In-Reply-To: <20170308170136.GC32355@lunn.ch> (Andrew Lunn's message of "Wed, 8 Mar 2017 18:01:36 +0100")
Hi Andrew,
On mer., mars 08 2017, Andrew Lunn <andrew@lunn.ch> wrote:
> On Wed, Mar 08, 2017 at 05:24:22PM +0100, Gregory CLEMENT wrote:
>> The mvebu ARM64 SoCs no more select PLAT_ORION but some of them as the
>> Armada 37xx use the EHCI orion controller. This patch allow to build
>> the driver when ARCH_MVEBU is selected.
>
> The mvebu ARM64 SoCs no longer selects PLAT_ORION. However Armada
> 37xx use the Orion EHCI controller. This patch allows the Orion EHCI
> driver to be built when ARCH_MVEBU is selected.
Thanks for this enhancement!
>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
>> ---
>> drivers/usb/host/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
>> index 407d947b34ea..870c42d89298 100644
>> --- a/drivers/usb/host/Kconfig
>> +++ b/drivers/usb/host/Kconfig
>> @@ -188,7 +188,7 @@ config USB_EHCI_HCD_OMAP
>>
>> config USB_EHCI_HCD_ORION
>> tristate "Support for Marvell EBU on-chip EHCI USB controller"
>> - depends on USB_EHCI_HCD && PLAT_ORION
>> + depends on USB_EHCI_HCD && PLAT_ORION || ARCH_MVEBU
>
> I don't know the Kconfig language too well. Should this be:
>
>> + depends on USB_EHCI_HCD && (PLAT_ORION || ARCH_MVEBU)
Your version seems better.
Thanks,
Gregory
>
> Andrew
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org>
Cc: Thomas Petazzoni
<thomas.petazzoni-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>,
devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Jason Cooper <jason-NLaQJdtUoK4Be96aLqz0jA@public.gmane.org>,
Greg Kroah-Hartman
<gregkh-hQyY1W1yCW8ekmWlsbkhG0B+6BGkLq7r@public.gmane.org>,
linux-usb-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Alan Stern
<stern-nwvwT67g6+6dFdvTe/nMLpVzexx5G7lz@public.gmane.org>,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
Sebastian Hesselbarth
<sebastian.hesselbarth-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Subject: Re: [PATCH 2/3] usb: host: Allow to build ehci orion with mvebu SoCs
Date: Wed, 08 Mar 2017 18:24:15 +0100 [thread overview]
Message-ID: <87o9xblm0w.fsf@free-electrons.com> (raw)
In-Reply-To: <20170308170136.GC32355-g2DYL2Zd6BY@public.gmane.org> (Andrew Lunn's message of "Wed, 8 Mar 2017 18:01:36 +0100")
Hi Andrew,
On mer., mars 08 2017, Andrew Lunn <andrew-g2DYL2Zd6BY@public.gmane.org> wrote:
> On Wed, Mar 08, 2017 at 05:24:22PM +0100, Gregory CLEMENT wrote:
>> The mvebu ARM64 SoCs no more select PLAT_ORION but some of them as the
>> Armada 37xx use the EHCI orion controller. This patch allow to build
>> the driver when ARCH_MVEBU is selected.
>
> The mvebu ARM64 SoCs no longer selects PLAT_ORION. However Armada
> 37xx use the Orion EHCI controller. This patch allows the Orion EHCI
> driver to be built when ARCH_MVEBU is selected.
Thanks for this enhancement!
>
>> Signed-off-by: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
>> ---
>> drivers/usb/host/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
>> index 407d947b34ea..870c42d89298 100644
>> --- a/drivers/usb/host/Kconfig
>> +++ b/drivers/usb/host/Kconfig
>> @@ -188,7 +188,7 @@ config USB_EHCI_HCD_OMAP
>>
>> config USB_EHCI_HCD_ORION
>> tristate "Support for Marvell EBU on-chip EHCI USB controller"
>> - depends on USB_EHCI_HCD && PLAT_ORION
>> + depends on USB_EHCI_HCD && PLAT_ORION || ARCH_MVEBU
>
> I don't know the Kconfig language too well. Should this be:
>
>> + depends on USB_EHCI_HCD && (PLAT_ORION || ARCH_MVEBU)
Your version seems better.
Thanks,
Gregory
>
> Andrew
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Gregory CLEMENT <gregory.clement@free-electrons.com>
To: Andrew Lunn <andrew@lunn.ch>
Cc: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
devicetree@vger.kernel.org, Jason Cooper <jason@lakedaemon.net>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
Rob Herring <robh+dt@kernel.org>,
Alan Stern <stern@rowland.harvard.edu>,
linux-arm-kernel@lists.infradead.org,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>
Subject: Re: [PATCH 2/3] usb: host: Allow to build ehci orion with mvebu SoCs
Date: Wed, 08 Mar 2017 18:24:15 +0100 [thread overview]
Message-ID: <87o9xblm0w.fsf@free-electrons.com> (raw)
In-Reply-To: <20170308170136.GC32355@lunn.ch> (Andrew Lunn's message of "Wed, 8 Mar 2017 18:01:36 +0100")
Hi Andrew,
On mer., mars 08 2017, Andrew Lunn <andrew@lunn.ch> wrote:
> On Wed, Mar 08, 2017 at 05:24:22PM +0100, Gregory CLEMENT wrote:
>> The mvebu ARM64 SoCs no more select PLAT_ORION but some of them as the
>> Armada 37xx use the EHCI orion controller. This patch allow to build
>> the driver when ARCH_MVEBU is selected.
>
> The mvebu ARM64 SoCs no longer selects PLAT_ORION. However Armada
> 37xx use the Orion EHCI controller. This patch allows the Orion EHCI
> driver to be built when ARCH_MVEBU is selected.
Thanks for this enhancement!
>
>> Signed-off-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
>> ---
>> drivers/usb/host/Kconfig | 2 +-
>> 1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/usb/host/Kconfig b/drivers/usb/host/Kconfig
>> index 407d947b34ea..870c42d89298 100644
>> --- a/drivers/usb/host/Kconfig
>> +++ b/drivers/usb/host/Kconfig
>> @@ -188,7 +188,7 @@ config USB_EHCI_HCD_OMAP
>>
>> config USB_EHCI_HCD_ORION
>> tristate "Support for Marvell EBU on-chip EHCI USB controller"
>> - depends on USB_EHCI_HCD && PLAT_ORION
>> + depends on USB_EHCI_HCD && PLAT_ORION || ARCH_MVEBU
>
> I don't know the Kconfig language too well. Should this be:
>
>> + depends on USB_EHCI_HCD && (PLAT_ORION || ARCH_MVEBU)
Your version seems better.
Thanks,
Gregory
>
> Andrew
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel
--
Gregory Clement, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2017-03-08 17:24 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-08 16:24 [PATCH 0/3] Add EHCI support for Armada 37xx Gregory CLEMENT
2017-03-08 16:24 ` Gregory CLEMENT
2017-03-08 16:24 ` Gregory CLEMENT
2017-03-08 16:24 ` [PATCH 1/3] usb: orion-echi: Add support for the Armada 3700 Gregory CLEMENT
2017-03-08 16:24 ` Gregory CLEMENT
2017-03-08 16:56 ` Andrew Lunn
2017-03-08 16:56 ` Andrew Lunn
2017-03-08 16:56 ` Andrew Lunn
2017-03-08 17:21 ` Gregory CLEMENT
2017-03-08 17:21 ` Gregory CLEMENT
2017-03-08 17:21 ` Gregory CLEMENT
2017-03-08 20:07 ` Thomas Petazzoni
2017-03-08 20:07 ` Thomas Petazzoni
2017-03-08 20:07 ` Thomas Petazzoni
2017-03-08 16:24 ` [PATCH 2/3] usb: host: Allow to build ehci orion with mvebu SoCs Gregory CLEMENT
2017-03-08 16:24 ` Gregory CLEMENT
2017-03-08 16:24 ` Gregory CLEMENT
2017-03-08 17:01 ` Andrew Lunn
2017-03-08 17:01 ` Andrew Lunn
2017-03-08 17:01 ` Andrew Lunn
2017-03-08 17:24 ` Gregory CLEMENT [this message]
2017-03-08 17:24 ` Gregory CLEMENT
2017-03-08 17:24 ` Gregory CLEMENT
2017-03-08 16:24 ` [PATCH 3/3] ARM64: dts: marvell: armada-37xx: Add USB2 node Gregory CLEMENT
2017-03-08 16:24 ` Gregory CLEMENT
2017-03-08 16:24 ` Gregory CLEMENT
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9xblm0w.fsf@free-electrons.com \
--to=gregory.clement@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.