From: Peter Zijlstra <peterz@infradead.org>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Will Deacon <will.deacon@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Ingo Molnar <mingo@redhat.com>,
kasan-dev <kasan-dev@googlegroups.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH] x86, kasan: add KASAN checks to atomic operations
Date: Tue, 14 Mar 2017 16:32:30 +0100 [thread overview]
Message-ID: <20170314153230.GR5680@worktop> (raw)
In-Reply-To: <CACT4Y+bjMLgXHv0Wwuo1fnEWitxfdJLdH2oCy+rSa2kTjNXmuw@mail.gmail.com>
On Tue, Mar 14, 2017 at 04:22:52PM +0100, Dmitry Vyukov wrote:
> -static __always_inline int atomic_read(const atomic_t *v)
> +static __always_inline int arch_atomic_read(const atomic_t *v)
> {
> - return READ_ONCE((v)->counter);
> + return READ_ONCE_NOCHECK((v)->counter);
Should NOCHEKC come with a comment, because i've no idea why this is so.
> }
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Peter Zijlstra <peterz@infradead.org>
To: Dmitry Vyukov <dvyukov@google.com>
Cc: Will Deacon <will.deacon@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Andrew Morton <akpm@linux-foundation.org>,
Andrey Ryabinin <aryabinin@virtuozzo.com>,
Ingo Molnar <mingo@redhat.com>,
kasan-dev <kasan-dev@googlegroups.com>,
"linux-mm@kvack.org" <linux-mm@kvack.org>,
LKML <linux-kernel@vger.kernel.org>,
"x86@kernel.org" <x86@kernel.org>
Subject: Re: [PATCH] x86, kasan: add KASAN checks to atomic operations
Date: Tue, 14 Mar 2017 16:32:30 +0100 [thread overview]
Message-ID: <20170314153230.GR5680@worktop> (raw)
In-Reply-To: <CACT4Y+bjMLgXHv0Wwuo1fnEWitxfdJLdH2oCy+rSa2kTjNXmuw@mail.gmail.com>
On Tue, Mar 14, 2017 at 04:22:52PM +0100, Dmitry Vyukov wrote:
> -static __always_inline int atomic_read(const atomic_t *v)
> +static __always_inline int arch_atomic_read(const atomic_t *v)
> {
> - return READ_ONCE((v)->counter);
> + return READ_ONCE_NOCHECK((v)->counter);
Should NOCHEKC come with a comment, because i've no idea why this is so.
> }
next prev parent reply other threads:[~2017-03-14 15:32 UTC|newest]
Thread overview: 48+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-06 12:42 [PATCH] x86, kasan: add KASAN checks to atomic operations Dmitry Vyukov
2017-03-06 12:42 ` Dmitry Vyukov
2017-03-06 12:50 ` Dmitry Vyukov
2017-03-06 12:50 ` Dmitry Vyukov
2017-03-06 12:58 ` Peter Zijlstra
2017-03-06 12:58 ` Peter Zijlstra
2017-03-06 13:01 ` Peter Zijlstra
2017-03-06 13:01 ` Peter Zijlstra
2017-03-06 14:24 ` Dmitry Vyukov
2017-03-06 14:24 ` Dmitry Vyukov
2017-03-06 15:20 ` Peter Zijlstra
2017-03-06 15:20 ` Peter Zijlstra
2017-03-06 16:04 ` Mark Rutland
2017-03-06 16:04 ` Mark Rutland
2017-03-06 15:33 ` Peter Zijlstra
2017-03-06 15:33 ` Peter Zijlstra
2017-03-06 16:20 ` Mark Rutland
2017-03-06 16:20 ` Mark Rutland
2017-03-06 16:27 ` Dmitry Vyukov
2017-03-06 16:27 ` Dmitry Vyukov
2017-03-06 17:25 ` Mark Rutland
2017-03-06 17:25 ` Mark Rutland
2017-03-06 20:35 ` Peter Zijlstra
2017-03-06 20:35 ` Peter Zijlstra
2017-03-08 13:42 ` Dmitry Vyukov
2017-03-08 15:20 ` Mark Rutland
2017-03-08 15:20 ` Mark Rutland
2017-03-08 15:27 ` Dmitry Vyukov
2017-03-08 15:27 ` Dmitry Vyukov
2017-03-08 15:43 ` Mark Rutland
2017-03-08 15:43 ` Mark Rutland
2017-03-08 15:45 ` Dmitry Vyukov
2017-03-08 15:45 ` Dmitry Vyukov
2017-03-08 15:48 ` Mark Rutland
2017-03-08 15:48 ` Mark Rutland
2017-03-08 17:43 ` Will Deacon
2017-03-08 17:43 ` Will Deacon
2017-03-14 15:22 ` Dmitry Vyukov
2017-03-14 15:31 ` Peter Zijlstra
2017-03-14 15:31 ` Peter Zijlstra
2017-03-14 15:32 ` Peter Zijlstra [this message]
2017-03-14 15:32 ` Peter Zijlstra
2017-03-14 15:44 ` Mark Rutland
2017-03-14 15:44 ` Mark Rutland
2017-03-14 19:25 ` Dmitry Vyukov
2017-03-14 19:25 ` Dmitry Vyukov
2017-03-06 16:48 ` Andrey Ryabinin
2017-03-06 16:48 ` Andrey Ryabinin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314153230.GR5680@worktop \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=aryabinin@virtuozzo.com \
--cc=dvyukov@google.com \
--cc=kasan-dev@googlegroups.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mark.rutland@arm.com \
--cc=mingo@redhat.com \
--cc=will.deacon@arm.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.